- User Since
- Jan 31 2019, 12:17 (15 w, 5 d)
Sun, May 19
Fri, May 17
I can split this diff in two, if needed. I'm not sure this test should be created.
Sat, May 4
Tue, Apr 23
Update tests to match the merged spec (test vectors: V6, V7, I10, I4, I5, I2, I1).
Apr 11 2019
Apr 10 2019
Apr 4 2019
They don't have a fix. It seems they've never bumped into this problem. Core v18.0 is the only bug-free branch only because they removed the rpc entirely. I suppose we're only planning to remove that rpc in v20.0.
Yeah, the issue exists in core in all actively maintained branches, except for v18.0 (removed the rpc) which should be released soon. Thanks for handling this, Fabien!
Apr 2 2019
Remove extra space.
Mar 28 2019
Revert the mod n change.
Mar 27 2019
Mar 26 2019
Add mocktime to avoid time dependencies.
Mar 14 2019
Added functional test
Mar 1 2019
Feb 14 2019
Feb 13 2019
Feb 12 2019
Improved readability of the functional test.
Feb 11 2019
Refactored the ban testing code to only use public interfaces.
Feb 10 2019
Moved mempool reorg handling to other diff, refactored the functional test
Fixed pool access outside of crictical section
Separated the functional test and fixed abc-replay-protection
Feb 9 2019
Applied requested changes. Refactored unit test for readability.
Included another test for non replay protected txn crossing the fork boundary
Many small changes as requested.
Feb 8 2019
Solved lint error.
Included test cases in different txn orders
Feb 7 2019
Fixed mempool handling on reorg and added fixed/tested the ban logic
Feb 6 2019
I will resubmit this diff for review after Feb 15th
scriptSig -> signature scripts
Handled case when disconnectpool is nullptr, added better description
Included code to remove invalid transactions from the mempool on a reorg that deactivates the fork. Updated the test to check the state of the mempool when standardness checks are disabled.
Feb 5 2019
Feb 4 2019
Feb 3 2019
Included checks of the parsed results of IsWitnessProgram
Included a unit test for IsWitnessProgram, a few other test cases for ALLOW_SEGWIT_RECOVERY and created a wrapper for IsWitnessProgram()
Removed unused parameters from IsWitnessProgram
Refactored to be restrictive to segwit programs.
Feb 2 2019
You can try it by yourself in mainnet: