Page MenuHomePhabricator

florian (Florian Engel)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2019, 12:17 (29 w, 2 d)

Recent Activity

Fri, Aug 16

florian abandoned D2506: Update mandatory flags after Magnetic anomaly has activated.
Fri, Aug 16, 00:42

May 19 2019

florian updated the diff for D3065: Remove segwit recovery activation.

Address comment.

May 19 2019, 05:59

May 17 2019

florian added a comment to D3065: Remove segwit recovery activation.

I can split this diff in two, if needed. I'm not sure this test should be created.

May 17 2019, 17:40
florian added a task to D3065: Remove segwit recovery activation: T653: Clean up past upgrades.
May 17 2019, 17:36
florian added a revision to T653: Clean up past upgrades: D3065: Remove segwit recovery activation.
May 17 2019, 17:36
Herald added a reviewer for D3065: Remove segwit recovery activation: deadalnix.
May 17 2019, 17:35

May 4 2019

florian committed rABCdb32590c400b: Add additional unit tests for segwit recovery (authored by florian).
Add additional unit tests for segwit recovery
May 4 2019, 21:20
florian closed D2795: Add additional unit tests for segwit recovery.
May 4 2019, 21:20
florian updated the diff for D2795: Add additional unit tests for segwit recovery.

rebase

May 4 2019, 20:58

Apr 23 2019

florian updated the diff for D2795: Add additional unit tests for segwit recovery.

Update tests to match the merged spec (test vectors: V6, V7, I10, I4, I5, I2, I1).

Apr 23 2019, 19:24

Apr 11 2019

florian committed rABC5e3527194d8a: Add additional test in segwit recovery activation (authored by florian).
Add additional test in segwit recovery activation
Apr 11 2019, 00:47
florian closed D2796: Add additional test in segwit recovery activation.
Apr 11 2019, 00:47

Apr 10 2019

florian added inline comments to D2796: Add additional test in segwit recovery activation.
Apr 10 2019, 22:53
Herald added a reviewer for D2796: Add additional test in segwit recovery activation: deadalnix.
Apr 10 2019, 22:48
Herald added a reviewer for D2795: Add additional unit tests for segwit recovery: deadalnix.
Apr 10 2019, 22:39

Apr 4 2019

florian added a comment to D2771: Fix signrawtransaction failing when a wallet URI is specified.

They don't have a fix. It seems they've never bumped into this problem. Core v18.0 is the only bug-free branch only because they removed the rpc entirely. I suppose we're only planning to remove that rpc in v20.0.

Apr 4 2019, 17:41
florian accepted D2771: Fix signrawtransaction failing when a wallet URI is specified.

Yeah, the issue exists in core in all actively maintained branches, except for v18.0 (removed the rpc) which should be released soon. Thanks for handling this, Fabien!

Apr 4 2019, 17:02

Apr 2 2019

florian committed rABC8dfaa2198450: Add schnorr verify benchmark (authored by florian).
Add schnorr verify benchmark
Apr 2 2019, 22:41
florian closed D2749: Add schnorr verify benchmark.
Apr 2 2019, 22:41
florian committed rABC5ea73621a21f: Add schnorr sign benchmark (authored by florian).
Add schnorr sign benchmark
Apr 2 2019, 22:38
florian closed D2748: Add schnorr sign benchmark.
Apr 2 2019, 22:38
florian updated the diff for D2749: Add schnorr verify benchmark.

Remove extra space.

Apr 2 2019, 01:43
florian updated the diff for D2748: Add schnorr sign benchmark.

Remove extra space.

Apr 2 2019, 01:40
florian committed rABCc80bf903f979: Fix comment about s in schnorr sigs (authored by florian).
Fix comment about s in schnorr sigs
Apr 2 2019, 01:19
florian closed D2741: Fix comment about s in schnorr sigs.
Apr 2 2019, 01:18
florian updated the summary of D2741: Fix comment about s in schnorr sigs.
Apr 2 2019, 01:18

Mar 28 2019

florian updated the diff for D2741: Fix comment about s in schnorr sigs.

Revert the mod n change.

Mar 28 2019, 00:31
florian committed rABCb9c102a733b9: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp (authored by florian).
Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp
Mar 28 2019, 00:22
florian closed D2747: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp.
Mar 28 2019, 00:22
florian committed rABC095183ecff21: Fix unlocked_until in getwalletinfo rpc (authored by florian).
Fix unlocked_until in getwalletinfo rpc
Mar 28 2019, 00:18
florian closed D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 28 2019, 00:18
Herald added a reviewer for D2749: Add schnorr verify benchmark: deadalnix.
Mar 28 2019, 00:14

Mar 27 2019

Herald added a reviewer for D2748: Add schnorr sign benchmark: deadalnix.
Mar 27 2019, 23:42
Herald added a reviewer for D2747: Remove nonnull warning when calling secp256k1_schnorr_sign with NULL noncefp: deadalnix.
Mar 27 2019, 23:10

Mar 26 2019

Herald added a reviewer for D2741: Fix comment about s in schnorr sigs: deadalnix.
Mar 26 2019, 20:32
florian added inline comments to D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 26 2019, 18:32
florian updated the diff for D2633: Fix unlocked_until in getwalletinfo rpc.

Add mocktime to avoid time dependencies.

Mar 26 2019, 18:19
florian added inline comments to D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 26 2019, 18:16

Mar 14 2019

florian added inline comments to D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 14 2019, 19:54
florian updated the test plan for D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 14 2019, 19:53
florian updated the diff for D2633: Fix unlocked_until in getwalletinfo rpc.

Added functional test

Mar 14 2019, 19:52
florian updated the test plan for D2633: Fix unlocked_until in getwalletinfo rpc.
Mar 14 2019, 19:50

Mar 1 2019

Herald added a reviewer for D2633: Fix unlocked_until in getwalletinfo rpc: deadalnix.
Mar 1 2019, 01:01

Feb 14 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABCf19955048697: Add activation code for SEGWIT_RECOVERY (authored by florian).
Add activation code for SEGWIT_RECOVERY
Feb 14 2019, 00:07
florian closed D2479: Add activation code for SEGWIT_RECOVERY.
Feb 14 2019, 00:07

Feb 13 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC8ff468e92bf4: Improved mempool handling when changing validation rulesets (authored by florian).
Improved mempool handling when changing validation rulesets
Feb 13 2019, 15:23
florian closed D2527: Improved mempool handling when changing validation rulesets.
Feb 13 2019, 15:23

Feb 12 2019

florian updated the diff for D2527: Improved mempool handling when changing validation rulesets.

Improved readability of the functional test.

Feb 12 2019, 02:22

Feb 11 2019

florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Refactored the ban testing code to only use public interfaces.

Feb 11 2019, 17:55
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 11 2019, 17:51
florian committed rABC9cd4f98596e9: Add importMempool (authored by florian).
Add importMempool
Feb 11 2019, 04:04
florian closed D2525: Add importMempool.
Feb 11 2019, 04:04

Feb 10 2019

florian updated the diff for D2527: Improved mempool handling when changing validation rulesets.

Addressed comments.

Feb 10 2019, 21:19
florian added inline comments to D2527: Improved mempool handling when changing validation rulesets.
Feb 10 2019, 21:18
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 10 2019, 12:43
florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Moved mempool reorg handling to other diff, refactored the functional test

Feb 10 2019, 08:22
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 10 2019, 08:09
florian updated the summary of D2479: Add activation code for SEGWIT_RECOVERY.
Feb 10 2019, 08:04
florian updated the diff for D2525: Add importMempool.

Fixed pool access outside of crictical section

Feb 10 2019, 02:33
florian updated the diff for D2527: Improved mempool handling when changing validation rulesets.

Separated the functional test and fixed abc-replay-protection

Feb 10 2019, 01:03
florian updated the test plan for D2527: Improved mempool handling when changing validation rulesets.
Feb 10 2019, 00:59

Feb 9 2019

florian added inline comments to D2525: Add importMempool.
Feb 9 2019, 21:38
florian updated the diff for D2525: Add importMempool.

Applied requested changes. Refactored unit test for readability.

Feb 9 2019, 21:38
florian updated the diff for D2527: Improved mempool handling when changing validation rulesets.

Included another test for non replay protected txn crossing the fork boundary

Feb 9 2019, 03:57
florian added inline comments to D2525: Add importMempool.
Feb 9 2019, 01:30
florian updated the diff for D2525: Add importMempool.

Many small changes as requested.

Feb 9 2019, 01:23
florian updated the summary of D2527: Improved mempool handling when changing validation rulesets.
Feb 9 2019, 00:10

Feb 8 2019

florian updated the diff for D2527: Improved mempool handling when changing validation rulesets.

Solved lint error.

Feb 8 2019, 23:54
Herald added a reviewer for D2527: Improved mempool handling when changing validation rulesets: Restricted Project.
Feb 8 2019, 23:48
florian updated the diff for D2525: Add importMempool.

Included test cases in different txn orders

Feb 8 2019, 23:06
Herald added a reviewer for D2525: Add importMempool: Restricted Project.
Feb 8 2019, 19:52

Feb 7 2019

florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Fixed mempool handling on reorg and added fixed/tested the ban logic

Feb 7 2019, 19:58

Feb 6 2019

florian added inline comments to D2506: Update mandatory flags after Magnetic anomaly has activated.
Feb 6 2019, 16:58
florian committed rABCb1eb229c4c3f: Fix script error description (authored by florian).
Fix script error description
Feb 6 2019, 15:27
florian closed D2505: Fix script error description.
Feb 6 2019, 15:27
florian updated the diff for D2506: Update mandatory flags after Magnetic anomaly has activated.

I will resubmit this diff for review after Feb 15th

Feb 6 2019, 15:12
florian planned changes to D2506: Update mandatory flags after Magnetic anomaly has activated.
Feb 6 2019, 15:07
florian updated the diff for D2505: Fix script error description.

scriptSig -> signature scripts

Feb 6 2019, 14:41
florian updated the diff for D2505: Fix script error description.

signtures->scriptSig

Feb 6 2019, 14:24
florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Handled case when disconnectpool is nullptr, added better description

Feb 6 2019, 14:18
florian updated the summary of D2479: Add activation code for SEGWIT_RECOVERY.
Feb 6 2019, 07:08
florian updated the diff for D2479: Add activation code for SEGWIT_RECOVERY.

Included code to remove invalid transactions from the mempool on a reorg that deactivates the fork. Updated the test to check the state of the mempool when standardness checks are disabled.

Feb 6 2019, 07:03
Herald added a reviewer for D2506: Update mandatory flags after Magnetic anomaly has activated: deadalnix.
Feb 6 2019, 06:59
florian retitled D2505: Fix script error description from Fixed script error description to Fix script error description.
Feb 6 2019, 04:26
Herald added a reviewer for D2505: Fix script error description: deadalnix.
Feb 6 2019, 04:11

Feb 5 2019

florian requested review of D2479: Add activation code for SEGWIT_RECOVERY.
Feb 5 2019, 03:03

Feb 4 2019

florian updated the test plan for D2479: Add activation code for SEGWIT_RECOVERY.
Feb 4 2019, 13:55
florian committed rABC0d94d9df7e42: Add SCRIPT_ALLOW_SEGWIT_RECOVERY (authored by florian).
Add SCRIPT_ALLOW_SEGWIT_RECOVERY
Feb 4 2019, 13:15
florian closed D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 4 2019, 13:15

Feb 3 2019

florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Included checks of the parsed results of IsWitnessProgram

Feb 3 2019, 18:33
florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Included a unit test for IsWitnessProgram, a few other test cases for ALLOW_SEGWIT_RECOVERY and created a wrapper for IsWitnessProgram()

Feb 3 2019, 04:55
florian requested review of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 03:37
florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Removed unused parameters from IsWitnessProgram

Feb 3 2019, 02:47
florian retitled D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY from Add ALLOW_SEGWIT_RECOVERY to Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:32
florian planned changes to D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:26
florian updated the diff for D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.

Refactored to be restrictive to segwit programs.

Feb 3 2019, 02:26
florian updated the summary of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 3 2019, 02:24

Feb 2 2019

florian requested review of D2479: Add activation code for SEGWIT_RECOVERY.

You can try it by yourself in mainnet:

Feb 2 2019, 22:07
florian requested review of D2468: Add SCRIPT_ALLOW_SEGWIT_RECOVERY.
Feb 2 2019, 22:04
florian added inline comments to D2479: Add activation code for SEGWIT_RECOVERY.
Feb 2 2019, 02:01