Page MenuHomePhabricator

fpelliccioni (Fernando Pelliccioni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 18:09 (119 w, 3 d)

Recent Activity

Fri, Sep 20

fpelliccioni committed rABCea8cef58c8dc: debug log number of unknown wallet records on load (authored by fpelliccioni).
debug log number of unknown wallet records on load
Fri, Sep 20, 18:21
fpelliccioni closed D4079: debug log number of unknown wallet records on load.
Fri, Sep 20, 18:21
fpelliccioni committed rABC9f466fe7a8ec: Add compile time verification of assumptions we're currently making… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Add compile time verification of assumptions we're currently making…
Fri, Sep 20, 18:18
fpelliccioni closed D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Fri, Sep 20, 18:17
fpelliccioni updated the diff for D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Removes obvious type checks.

Fri, Sep 20, 13:16
fpelliccioni updated the diff for D4079: debug log number of unknown wallet records on load.

Test plan fixed.

Fri, Sep 20, 13:03
fpelliccioni updated the test plan for D4079: debug log number of unknown wallet records on load.
Fri, Sep 20, 13:01
fpelliccioni committed rABCcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost… (authored by fpelliccioni).
bench: Use non-throwing ParseDouble(...) instead of throwing boost…
Fri, Sep 20, 12:38
fpelliccioni closed D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).
Fri, Sep 20, 12:38
fpelliccioni committed rABC2ec61ddea958: [qt] send: Clear All also resets coin control options (authored by fpelliccioni).
[qt] send: Clear All also resets coin control options
Fri, Sep 20, 12:38
fpelliccioni closed D4078: [qt] send: Clear All also resets coin control options.
Fri, Sep 20, 12:37
fpelliccioni committed rABC2d6763dd0b83: [qt] Replaces numbered place marker %2 with %1. (authored by fpelliccioni).
[qt] Replaces numbered place marker %2 with %1.
Fri, Sep 20, 12:36
fpelliccioni closed D4077: [qt] Replaces numbered place marker %2 with %1..
Fri, Sep 20, 12:36

Thu, Sep 19

fpelliccioni committed rSTAGINGd6572b18700b: [trivial,doc] Fix memory consistency model in comment (authored by Jesse Cohen <jc@jc.lol>).
[trivial,doc] Fix memory consistency model in comment
Thu, Sep 19, 02:20
fpelliccioni committed rSTAGINGa3cc9379de00: [qt] coincontrol: Remove unused qt4 workaround (authored by MarcoFalke <falke.marco@gmail.com>).
[qt] coincontrol: Remove unused qt4 workaround
Thu, Sep 19, 02:19
fpelliccioni committed rSTAGINGb3925b2d6bb9: [build] .gitignore: add QT Creator artifacts (authored by Sjors Provoost <sjors@sprovoost.nl>).
[build] .gitignore: add QT Creator artifacts
Thu, Sep 19, 02:19
fpelliccioni committed rSTAGING74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (authored by Chris Stewart <stewart.chris1234@gmail.com>).
Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
Thu, Sep 19, 02:19
fpelliccioni committed rSTAGINGc635eefa921b: Fixes compilation of leveldb tests broken in D4004 (authored by fpelliccioni).
Fixes compilation of leveldb tests broken in D4004
Thu, Sep 19, 02:17
fpelliccioni committed rSTAGING39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Do not construct out-of-bound pointers in SHA2 code
Thu, Sep 19, 02:16
fpelliccioni committed rSTAGING4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
Thu, Sep 19, 02:16
fpelliccioni committed rSTAGING29fec420b3e2: Pull leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Pull leveldb subtree
Thu, Sep 19, 02:16
fpelliccioni committed rSTAGING4ab217db8523: [rebase] threads: fix unitialized members in sched_param (authored by Cory Fields <cory-nospam-@coryfields.com>).
[rebase] threads: fix unitialized members in sched_param
Thu, Sep 19, 02:10
fpelliccioni committed rSTAGING55441ec79bdb: Update univalue subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Update univalue subtree
Thu, Sep 19, 02:10
fpelliccioni committed rSTAGING85bc68c4608a: Merge leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Merge leveldb subtree
Thu, Sep 19, 02:10
fpelliccioni committed rSTAGING707568ec5670: Bump leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Bump leveldb subtree
Thu, Sep 19, 02:10
fpelliccioni committed rSTAGING5c1f643c9f97: wallet: Catch filesystem_error and raise InitError (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Catch filesystem_error and raise InitError
Thu, Sep 19, 02:08
fpelliccioni committed rSTAGING966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…
Thu, Sep 19, 02:08
fpelliccioni committed rSTAGING1bf9852e2c50: Default to defining endian-conversion DECLs in compat w/o config (authored by Matt Corallo <git@bluematt.me>).
Default to defining endian-conversion DECLs in compat w/o config
Thu, Sep 19, 02:06
fpelliccioni committed rSTAGING51fbdf464a64: Consistently log CValidationState on failure (authored by Ben Woosley <ben.woosley@gmail.com>).
Consistently log CValidationState on failure
Thu, Sep 19, 02:06
fpelliccioni committed rSTAGING8b217943d251: Add DynamicMemoryUsage() to LevelDB (authored by Evan Klitzke <evan@eklitzke.org>).
Add DynamicMemoryUsage() to LevelDB
Thu, Sep 19, 02:01
fpelliccioni committed rSTAGING7b0d5028a6b5: use base58 map instead of strchr() (authored by Kevin Pan <bit.kevin@gmail.com>).
use base58 map instead of strchr()
Thu, Sep 19, 02:01
fpelliccioni committed rSTAGING613c7d202468: trivial: Improve include comment in src/interfaces/wallet.h (authored by João Barbosa <joao.paulo.barbosa@gmail.com>).
trivial: Improve include comment in src/interfaces/wallet.h
Thu, Sep 19, 01:58

Wed, Sep 18

fpelliccioni updated the diff for D4005: cli: Ignore libevent warnings.

Code style: comment moved.

Wed, Sep 18, 18:13
fpelliccioni added inline comments to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Wed, Sep 18, 18:08
fpelliccioni added inline comments to D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Wed, Sep 18, 18:05
fpelliccioni updated the diff for D4078: [qt] send: Clear All also resets coin control options.

Test plan updated.

Wed, Sep 18, 17:53
fpelliccioni updated the test plan for D4078: [qt] send: Clear All also resets coin control options.
Wed, Sep 18, 17:52

Tue, Sep 17

fpelliccioni abandoned D4066: [build] Tune wildcards for LIBSECP256K1 target.

As I told Fabien a few hours ago, I will avoid (for the moment) doing backports related to the build system.

Tue, Sep 17, 19:55
fpelliccioni updated the diff for D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.

Fixed following Fabien suggestions.

Tue, Sep 17, 19:41
fpelliccioni planned changes to D4009: zmq: log outbound message high water mark when reusing socket.

It depends on other backports not done yet.

Tue, Sep 17, 19:20
fpelliccioni updated the diff for D4005: cli: Ignore libevent warnings.

updated test plan.

Tue, Sep 17, 18:56
fpelliccioni updated the test plan for D4005: cli: Ignore libevent warnings.
Tue, Sep 17, 18:55
fpelliccioni updated the test plan for D4005: cli: Ignore libevent warnings.
Tue, Sep 17, 18:53
fpelliccioni planned changes to D4075: Integration of property based testing into Bitcoin Core.

Needs documentation.
Needs to port to CMake.
Needs some testing.

Tue, Sep 17, 17:09
fpelliccioni updated the test plan for D4075: Integration of property based testing into Bitcoin Core.
Tue, Sep 17, 17:08
fpelliccioni updated the diff for D4077: [qt] Replaces numbered place marker %2 with %1..

test plan updated.

Tue, Sep 17, 16:14
fpelliccioni updated the test plan for D4077: [qt] Replaces numbered place marker %2 with %1..
Tue, Sep 17, 16:11

Fri, Sep 13

fpelliccioni created D4080: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).
Fri, Sep 13, 22:29
fpelliccioni created D4079: debug log number of unknown wallet records on load.
Fri, Sep 13, 22:29
fpelliccioni created D4078: [qt] send: Clear All also resets coin control options.
Fri, Sep 13, 22:28
fpelliccioni created D4077: [qt] Replaces numbered place marker %2 with %1..
Fri, Sep 13, 22:28
fpelliccioni created D4075: Integration of property based testing into Bitcoin Core.
Fri, Sep 13, 20:23
fpelliccioni committed rABCd6572b18700b: [trivial,doc] Fix memory consistency model in comment (authored by Jesse Cohen <jc@jc.lol>).
[trivial,doc] Fix memory consistency model in comment
Fri, Sep 13, 17:41
fpelliccioni closed D4068: [trivial,doc] Fix memory consistency model in comment.
Fri, Sep 13, 17:41
fpelliccioni committed rABCa3cc9379de00: [qt] coincontrol: Remove unused qt4 workaround (authored by MarcoFalke <falke.marco@gmail.com>).
[qt] coincontrol: Remove unused qt4 workaround
Fri, Sep 13, 17:41
fpelliccioni closed D4065: [qt] coincontrol: Remove unused qt4 workaround.
Fri, Sep 13, 17:40
fpelliccioni committed rABCb3925b2d6bb9: [build] .gitignore: add QT Creator artifacts (authored by Sjors Provoost <sjors@sprovoost.nl>).
[build] .gitignore: add QT Creator artifacts
Fri, Sep 13, 17:38
fpelliccioni closed D4063: [build] .gitignore: add QT Creator artifacts.
Fri, Sep 13, 17:38
fpelliccioni committed rABC74a94f46047a: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json (authored by Chris Stewart <stewart.chris1234@gmail.com>).
Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json
Fri, Sep 13, 17:36
fpelliccioni closed D4062: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.
Fri, Sep 13, 17:36
fpelliccioni added a comment to D4062: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.

check-all is unnecessary in that case. If you use cmake, I strongly advise you use ninja instead of make and it is way faster.

Fri, Sep 13, 17:19
fpelliccioni abandoned D4064: [depends] Allow depends system to support armv7l.

Talked with Fabien, it is not worth backporting it.

Fri, Sep 13, 17:15

Thu, Sep 12

fpelliccioni abandoned D4067: bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.

segwit related, I have to re-check it.

Thu, Sep 12, 21:09
fpelliccioni created D4068: [trivial,doc] Fix memory consistency model in comment.
Thu, Sep 12, 21:02
fpelliccioni created D4067: bitcoinconsensus: invalid flags error should be set to bitcoinconsensus_err.
Thu, Sep 12, 21:01
fpelliccioni created D4066: [build] Tune wildcards for LIBSECP256K1 target.
Thu, Sep 12, 20:55
fpelliccioni created D4065: [qt] coincontrol: Remove unused qt4 workaround.
Thu, Sep 12, 20:55
fpelliccioni created D4064: [depends] Allow depends system to support armv7l.
Thu, Sep 12, 20:54
fpelliccioni created D4063: [build] .gitignore: add QT Creator artifacts.
Thu, Sep 12, 20:53
fpelliccioni created D4062: Adding test case for SINGLE|ANYONECANPAY hash type in tx_valid.json.
Thu, Sep 12, 20:52
fpelliccioni committed rABCc635eefa921b: Fixes compilation of leveldb tests broken in D4004 (authored by fpelliccioni).
Fixes compilation of leveldb tests broken in D4004
Thu, Sep 12, 19:29
fpelliccioni closed D4044: Fixes compilation of leveldb tests broken in D4004.
Thu, Sep 12, 19:29

Wed, Sep 11

fpelliccioni committed rABC39e41a449cfb: Do not construct out-of-bound pointers in SHA2 code (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Do not construct out-of-bound pointers in SHA2 code
Wed, Sep 11, 20:32
fpelliccioni closed D4018: Do not construct out-of-bound pointers in SHA2 code.
Wed, Sep 11, 20:32
fpelliccioni committed rABC4210ed4fcc0e: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid…
Wed, Sep 11, 19:46
fpelliccioni closed D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).
Wed, Sep 11, 19:46
fpelliccioni committed rABC29fec420b3e2: Pull leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Pull leveldb subtree
Wed, Sep 11, 19:44
fpelliccioni closed D4016: Pull leveldb subtree.
Wed, Sep 11, 19:44
fpelliccioni added a reviewer for D4044: Fixes compilation of leveldb tests broken in D4004: Fabien.
Wed, Sep 11, 19:42
fpelliccioni created D4044: Fixes compilation of leveldb tests broken in D4004.
Wed, Sep 11, 19:39
fpelliccioni created D4043: Add compile time verification of assumptions we're currently making implicitly/tacitly.
Wed, Sep 11, 18:13

Fri, Sep 6

fpelliccioni added a comment to D4009: zmq: log outbound message high water mark when reusing socket.
In D4009#94136, @Fabien wrote:
Fri, Sep 6, 17:36
fpelliccioni created D4018: Do not construct out-of-bound pointers in SHA2 code.
Fri, Sep 6, 16:37
fpelliccioni created D4017: Avoid triggering undefined behaviour (std::memset(nullptr, 0, 0)) if an invalid string is passed to DecodeSecret(...).
Fri, Sep 6, 16:35
fpelliccioni created D4016: Pull leveldb subtree.
Fri, Sep 6, 16:35
fpelliccioni updated the diff for D4009: zmq: log outbound message high water mark when reusing socket.

Summary fixed.

Fri, Sep 6, 16:21
fpelliccioni added a comment to D4009: zmq: log outbound message high water mark when reusing socket.

Can you fix the summary? looks like some of it got cut off.

Fri, Sep 6, 16:19
fpelliccioni updated the summary of D4009: zmq: log outbound message high water mark when reusing socket.
Fri, Sep 6, 16:18
fpelliccioni updated the summary of D4009: zmq: log outbound message high water mark when reusing socket.
Fri, Sep 6, 16:17
fpelliccioni committed rABC4ab217db8523: [rebase] threads: fix unitialized members in sched_param (authored by Cory Fields <cory-nospam-@coryfields.com>).
[rebase] threads: fix unitialized members in sched_param
Fri, Sep 6, 16:12
fpelliccioni closed D4008: [rebase] threads: fix unitialized members in sched_param.
Fri, Sep 6, 16:12
fpelliccioni committed rABC55441ec79bdb: Update univalue subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Update univalue subtree
Fri, Sep 6, 16:09
fpelliccioni closed D4007: Update univalue subtree.
Fri, Sep 6, 16:09
fpelliccioni committed rABC85bc68c4608a: Merge leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Merge leveldb subtree
Fri, Sep 6, 16:07
fpelliccioni closed D4006: Merge leveldb subtree.
Fri, Sep 6, 16:07
fpelliccioni committed rABC707568ec5670: Bump leveldb subtree (authored by MarcoFalke <falke.marco@gmail.com>).
Bump leveldb subtree
Fri, Sep 6, 16:03
fpelliccioni closed D4004: Bump leveldb subtree.
Fri, Sep 6, 16:03

Thu, Sep 5

fpelliccioni committed rABC5c1f643c9f97: wallet: Catch filesystem_error and raise InitError (authored by MarcoFalke <falke.marco@gmail.com>).
wallet: Catch filesystem_error and raise InitError
Thu, Sep 5, 19:20
fpelliccioni closed D3987: wallet: Catch filesystem_error and raise InitError.
Thu, Sep 5, 19:20
fpelliccioni committed rABC966fa58918e3: During IBD, when doing pruning, prune 10% extra to avoid pruning again soon… (authored by Luke Dashjr <luke-jr+git@utopios.org>).
During IBD, when doing pruning, prune 10% extra to avoid pruning again soon…
Thu, Sep 5, 19:20