Page MenuHomePhabricator

fpelliccioni (Fernando Pelliccioni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 18:09 (127 w, 5 d)

Recent Activity

Today

fpelliccioni abandoned D4280: Minor cleanups for AcceptToMemoryPool.
Tue, Nov 19, 17:06
fpelliccioni abandoned D4075: Integration of property based testing into Bitcoin Core.
Tue, Nov 19, 17:05
fpelliccioni abandoned D4009: zmq: log outbound message high water mark when reusing socket.
Tue, Nov 19, 17:05

Tue, Oct 29

fpelliccioni committed rABCf316cd272e95: rpc: Expose g_is_mempool_loaded via getmempoolinfo (authored by MarcoFalke <falke.marco@gmail.com>).
rpc: Expose g_is_mempool_loaded via getmempoolinfo
Tue, Oct 29, 14:46
fpelliccioni closed D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Tue, Oct 29, 14:46
fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

rebase from master

Tue, Oct 29, 14:29

Fri, Oct 25

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Applies backport changes.

Fri, Oct 25, 14:58
fpelliccioni committed rABCe12d2c2449ee: bench: Benchmark MempoolToJSON (authored by MarcoFalke <falke.marco@gmail.com>).
bench: Benchmark MempoolToJSON
Fri, Oct 25, 13:56
fpelliccioni closed D4234: bench: Benchmark MempoolToJSON.
Fri, Oct 25, 13:56

Thu, Oct 24

fpelliccioni requested review of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Please see my previous comment clarifying how I made the rebase.

Thu, Oct 24, 19:12
fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

Actually do the rebase an the backport, not just run the git rebase command.

Thu, Oct 24, 18:39
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fixes forward declarations order.

Thu, Oct 24, 18:21

Wed, Oct 23

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

rebased

Wed, Oct 23, 19:16
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

rebased

Wed, Oct 23, 18:33
fpelliccioni updated the test plan for D4234: bench: Benchmark MempoolToJSON.
Wed, Oct 23, 18:07
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fixes wrong rebase

Wed, Oct 23, 16:19
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

rebased from master

Wed, Oct 23, 15:56
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Wed, Oct 23, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Wed, Oct 23, 14:43
fpelliccioni updated the test plan for D4186: refactor: Avoid locking tx pool cs thrice.
Wed, Oct 23, 14:43

Tue, Oct 22

fpelliccioni planned changes to D4280: Minor cleanups for AcceptToMemoryPool.

Have to check what happened with the tests.

Tue, Oct 22, 20:03
fpelliccioni updated the test plan for D4280: Minor cleanups for AcceptToMemoryPool.
Tue, Oct 22, 19:47
fpelliccioni committed rABCa76b928ad0d6: mempool: remove unused magic number from consistency check (authored by Gregory Sanders <gsanders87@gmail.com>).
mempool: remove unused magic number from consistency check
Tue, Oct 22, 19:43
fpelliccioni closed D4278: mempool: remove unused magic number from consistency check.
Tue, Oct 22, 19:43
fpelliccioni updated the diff for D4280: Minor cleanups for AcceptToMemoryPool.

removed comment

Tue, Oct 22, 19:42
fpelliccioni created D4280: Minor cleanups for AcceptToMemoryPool.
Tue, Oct 22, 19:35
fpelliccioni updated the test plan for D4278: mempool: remove unused magic number from consistency check.
Tue, Oct 22, 13:39
fpelliccioni created D4278: mempool: remove unused magic number from consistency check.
Tue, Oct 22, 13:38

Oct 18 2019

fpelliccioni requested review of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 18 2019, 14:26
fpelliccioni requested review of D4234: bench: Benchmark MempoolToJSON.
Oct 18 2019, 14:26
fpelliccioni committed rABCd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>).
[mempool] Mark mempool import fails that were found in mempool as 'already…
Oct 18 2019, 14:24
fpelliccioni closed D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Oct 18 2019, 14:24

Oct 17 2019

fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.

It's not clear you go the dependency in the right order.in any case, it seems that you have https://github.com/bitcoin/bitcoin/pull/11062 to go through first.

Oct 17 2019, 17:46
fpelliccioni added a comment to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I think you got the dependency reversed.

Oct 17 2019, 17:46
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 17 2019, 17:39
fpelliccioni created D4266: [mempool] Mark mempool import fails that were found in mempool as 'already there'.
Oct 17 2019, 17:39

Oct 16 2019

fpelliccioni added inline comments to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 16 2019, 15:47

Oct 15 2019

fpelliccioni updated the diff for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

fix the rebase

Oct 15 2019, 14:05
fpelliccioni added a comment to D4234: bench: Benchmark MempoolToJSON.

It looks like you have dependencies to backport first.

Oct 15 2019, 13:58
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix rebase error

Oct 15 2019, 13:47
fpelliccioni updated the summary of D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 15 2019, 13:46

Oct 11 2019

fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix squashing

Oct 11 2019, 21:14
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix squashing.

Oct 11 2019, 21:12
fpelliccioni planned changes to D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.

I have to fix the squash

Oct 11 2019, 21:10
fpelliccioni updated the test plan for D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 11 2019, 21:09
fpelliccioni created D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.
Oct 11 2019, 21:08
fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

bench code fixed.

Oct 11 2019, 13:09

Oct 10 2019

fpelliccioni updated the diff for D4234: bench: Benchmark MempoolToJSON.

fix cmake script style.

Oct 10 2019, 17:45
fpelliccioni updated the test plan for D4234: bench: Benchmark MempoolToJSON.
Oct 10 2019, 17:44
fpelliccioni created D4234: bench: Benchmark MempoolToJSON.
Oct 10 2019, 17:43

Oct 9 2019

fpelliccioni committed rSTAGING8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).
mempool, validation: Explain cs_main locking semantics
Oct 9 2019, 20:12
fpelliccioni committed rSTAGING33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make objects in range declarations immutable by default. Avoid unnecessary…
Oct 9 2019, 20:12
fpelliccioni committed rSTAGING50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>).
cli: Ignore libevent warnings
Oct 9 2019, 20:12
fpelliccioni committed rSTAGINGfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant assignments (dead stores)
Oct 9 2019, 20:11
fpelliccioni committed rSTAGING5822a6e6efca: refactor: Avoid locking tx pool cs thrice (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Avoid locking tx pool cs thrice
Oct 9 2019, 20:11
fpelliccioni committed rSTAGINGa0dd249c1862: Return void instead of bool for functions that cannot fail (authored by practicalswift <practicalswift@users.noreply.github.com>).
Return void instead of bool for functions that cannot fail
Oct 9 2019, 20:11
fpelliccioni committed rSTAGING6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks (authored by MarcoFalke <falke.marco@gmail.com>).
validation: Pass tx pool reference into CheckSequenceLocks
Oct 9 2019, 20:10
fpelliccioni committed rSTAGING44a1e1cd6c81: doxygen: Fix member comments (authored by MarcoFalke <falke.marco@gmail.com>).
doxygen: Fix member comments
Oct 9 2019, 20:10
fpelliccioni committed rABC8408a0cdcf41: mempool, validation: Explain cs_main locking semantics (authored by MarcoFalke <falke.marco@gmail.com>).
mempool, validation: Explain cs_main locking semantics
Oct 9 2019, 17:21
fpelliccioni closed D4227: mempool, validation: Explain cs_main locking semantics.
Oct 9 2019, 17:21
fpelliccioni updated the diff for D4227: mempool, validation: Explain cs_main locking semantics.

fix squashing

Oct 9 2019, 12:37

Oct 8 2019

fpelliccioni planned changes to D4227: mempool, validation: Explain cs_main locking semantics.

I don't know what happened with Squash... I lost some of the changes...

Oct 8 2019, 19:12
fpelliccioni updated the test plan for D4227: mempool, validation: Explain cs_main locking semantics.
Oct 8 2019, 19:10
fpelliccioni created D4227: mempool, validation: Explain cs_main locking semantics.
Oct 8 2019, 19:09
fpelliccioni abandoned D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

Duplicated D4220

Oct 8 2019, 17:47
fpelliccioni added a comment to D4220: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

Oct 8 2019, 16:44
fpelliccioni added a comment to D4226: [wallet] `createwallet` RPC - create new wallet at runtime.

This is a duplicate of D4220. In addition, it looks like either you either forgot to squash your changes or you are working on a branch with a dependency.

Oct 8 2019, 16:41
fpelliccioni committed rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>).
Make objects in range declarations immutable by default. Avoid unnecessary…
Oct 8 2019, 16:08
fpelliccioni closed D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 8 2019, 16:08
fpelliccioni updated the summary of D4226: [wallet] `createwallet` RPC - create new wallet at runtime.
Oct 8 2019, 16:06
fpelliccioni created D4226: [wallet] `createwallet` RPC - create new wallet at runtime.
Oct 8 2019, 16:05

Oct 7 2019

fpelliccioni committed rABC50ae4433e7af: cli: Ignore libevent warnings (authored by Cory Fields <cory-nospam-@coryfields.com>).
cli: Ignore libevent warnings
Oct 7 2019, 20:50
fpelliccioni closed D4005: cli: Ignore libevent warnings.
Oct 7 2019, 20:50
fpelliccioni updated the summary of D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 17:52
fpelliccioni abandoned D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Was superseded by D4221.

Oct 7 2019, 17:50
fpelliccioni created D4221: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 17:47
fpelliccioni updated the summary of D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 14:24
fpelliccioni updated the diff for D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Applying const T x : seq where T is a built-in type.

Oct 7 2019, 14:23
fpelliccioni abandoned D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Duplicated with D4191.
Reason: arc usage error.

Oct 7 2019, 14:20
fpelliccioni created D4219: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 7 2019, 14:08
fpelliccioni committed rABCfb43752bb641: Remove redundant assignments (dead stores) (authored by practicalswift <practicalswift@users.noreply.github.com>).
Remove redundant assignments (dead stores)
Oct 7 2019, 13:08
fpelliccioni closed D4189: Remove redundant assignments (dead stores).
Oct 7 2019, 13:08

Oct 4 2019

fpelliccioni added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Part of the PR are missing.

It is a partial application of the PR, I forgot to clarify it, sorry. (summary edited).
I didn't apply the rule for built-in types, because it makes no sense:
for (int x : seq)
is preferred over
for (int const& x : seq).
Have I missed anything else?

for (const int x : seq) is even better. There are still some missing, for instance in qt/bitcoingui.cpp .

Oct 4 2019, 20:27
fpelliccioni updated the diff for D4189: Remove redundant assignments (dead stores).

test plan fixed.

Oct 4 2019, 20:23
fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).
Oct 4 2019, 20:23
fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).
Oct 4 2019, 20:22
fpelliccioni added a comment to D4189: Remove redundant assignments (dead stores).

The test plan doesn't run.
The test plan is meant to describe the step you took to ensure that this patch is good. Clearly, the step described do not match what you have done, as they simply do not work.

Oct 4 2019, 20:22

Oct 3 2019

fpelliccioni committed rABC5822a6e6efca: refactor: Avoid locking tx pool cs thrice (authored by MarcoFalke <falke.marco@gmail.com>).
refactor: Avoid locking tx pool cs thrice
Oct 3 2019, 13:44
fpelliccioni closed D4186: refactor: Avoid locking tx pool cs thrice.
Oct 3 2019, 13:44
fpelliccioni committed rABCa0dd249c1862: Return void instead of bool for functions that cannot fail (authored by practicalswift <practicalswift@users.noreply.github.com>).
Return void instead of bool for functions that cannot fail
Oct 3 2019, 13:34
fpelliccioni closed D4179: Return void instead of bool for functions that cannot fail.
Oct 3 2019, 13:33
fpelliccioni added a comment to D4179: Return void instead of bool for functions that cannot fail.

The test plan is meant to actually be ran.

Oct 3 2019, 13:32
fpelliccioni added a comment to D4179: Return void instead of bool for functions that cannot fail.

I see that you use make check-all in many tests. If you are using cmake, you should use ninja as it is faster. But right now, cmake is only a secondary option, so make sure the autotool build works.

Oct 3 2019, 13:31
fpelliccioni updated the diff for D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

update the summary to clarify that it is a partial application of the PR.

Oct 3 2019, 13:24
fpelliccioni updated the summary of D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..
Oct 3 2019, 13:19
fpelliccioni added a comment to D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..

Part of the PR are missing.

Oct 3 2019, 13:19
fpelliccioni updated the diff for D4189: Remove redundant assignments (dead stores).

updated test plan.

Oct 3 2019, 12:44
fpelliccioni updated the diff for D4186: refactor: Avoid locking tx pool cs thrice.

fixes test plan.

Oct 3 2019, 11:52
fpelliccioni updated the test plan for D4189: Remove redundant assignments (dead stores).
Oct 3 2019, 11:51

Oct 2 2019

fpelliccioni updated the diff for D4186: refactor: Avoid locking tx pool cs thrice.

fixes building error.

Oct 2 2019, 18:08