Page MenuHomePhabricator

fpelliccioni (Fernando Pelliccioni)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 18:09 (136 w, 5 d)

Recent Activity

Yesterday

fpelliccioni committed rABCbd6d5140b5c1: Make last disconnected block BLOCK_FAILED_VALID, even when aborted (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Make last disconnected block BLOCK_FAILED_VALID, even when aborted
Tue, Jan 21, 21:45
fpelliccioni closed D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Tue, Jan 21, 21:45

Mon, Jan 20

fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

fixes code comments

Mon, Jan 20, 17:39
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

reverted code

Mon, Jan 20, 17:29
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 20, 17:27
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

remove reverted code

Mon, Jan 20, 17:26
fpelliccioni abandoned D4945: Revert D4942 locking 'time'.

The final revert is done in D4946

Mon, Jan 20, 17:20
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 20, 15:34
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

rebase from master

Mon, Jan 20, 15:31

Thu, Jan 16

fpelliccioni retitled D4950: Fully revert D4803 due to TSAN test failures from Partially revert D4803 due to TSAN test failures to Fully revert D4803 due to TSAN test failures.
Thu, Jan 16, 01:05
fpelliccioni updated the diff for D4950: Fully revert D4803 due to TSAN test failures.

full revert

Thu, Jan 16, 01:04

Wed, Jan 15

fpelliccioni updated the test plan for D4950: Fully revert D4803 due to TSAN test failures.
Wed, Jan 15, 19:14
fpelliccioni added a reverting change for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex: D4950: Fully revert D4803 due to TSAN test failures.
Wed, Jan 15, 19:13
fpelliccioni created D4950: Fully revert D4803 due to TSAN test failures.
Wed, Jan 15, 19:13
fpelliccioni updated the diff for D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.

fixes

Wed, Jan 15, 18:04
fpelliccioni committed rABCe7fc0238127a: Optimization: don't add txn back to mempool after 10 invalidates (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Optimization: don't add txn back to mempool after 10 invalidates
Wed, Jan 15, 17:37
fpelliccioni closed D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Wed, Jan 15, 17:37
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebase from master

Wed, Jan 15, 17:10
fpelliccioni committed rABCa9734a4e30ae: Prevent callback overruns in InvalidateBlock and RewindBlockIndex (authored by fpelliccioni).
Prevent callback overruns in InvalidateBlock and RewindBlockIndex
Wed, Jan 15, 17:08
fpelliccioni closed D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Wed, Jan 15, 17:07
fpelliccioni updated the summary of D4945: Revert D4942 locking 'time'.
Wed, Jan 15, 12:53
fpelliccioni updated the diff for D4945: Revert D4942 locking 'time'.

lapsus

Wed, Jan 15, 12:52
fpelliccioni planned changes to D4945: Revert D4942 locking 'time'.
Wed, Jan 15, 12:52
fpelliccioni updated the summary of D4945: Revert D4942 locking 'time'.
Wed, Jan 15, 12:51
fpelliccioni created D4945: Revert D4942 locking 'time'.
Wed, Jan 15, 12:50

Tue, Jan 14

fpelliccioni updated the summary of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Tue, Jan 14, 21:27
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebased

Tue, Jan 14, 21:26
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebase from master

Tue, Jan 14, 21:23
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebase from master

Tue, Jan 14, 21:21
fpelliccioni committed rABCbaef60890b54: Call FinalizeBlockAndInvalidate without cs_main held (authored by fpelliccioni).
Call FinalizeBlockAndInvalidate without cs_main held
Tue, Jan 14, 21:13
fpelliccioni closed D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 21:13
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

linting

Tue, Jan 14, 20:03
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

lock frame reduced

Tue, Jan 14, 20:02
fpelliccioni added inline comments to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 19:49
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

rebased

Tue, Jan 14, 17:22
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

add whitespace

Tue, Jan 14, 17:19
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

revert not related with PR code

Tue, Jan 14, 17:17
fpelliccioni updated the summary of D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Tue, Jan 14, 17:12
fpelliccioni planned changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Tue, Jan 14, 16:11
fpelliccioni added a reviewer for D4942: Call FinalizeBlockAndInvalidate without cs_main held: markblundeberg.
Tue, Jan 14, 16:10
fpelliccioni updated the diff for D4942: Call FinalizeBlockAndInvalidate without cs_main held.

rebased from master

Tue, Jan 14, 16:09
fpelliccioni committed rABC3fb45c049a4c: Release cs_main during InvalidateBlock iterations (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Release cs_main during InvalidateBlock iterations
Tue, Jan 14, 16:05
fpelliccioni closed D4802: Release cs_main during InvalidateBlock iterations.
Tue, Jan 14, 16:05
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

rebased from master

Tue, Jan 14, 15:56
fpelliccioni planned changes to D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 15:53
fpelliccioni created D4942: Call FinalizeBlockAndInvalidate without cs_main held.
Tue, Jan 14, 15:52
fpelliccioni committed rABC9096e76f01e5: Call InvalidateBlock without cs_main held (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Call InvalidateBlock without cs_main held
Tue, Jan 14, 15:28
fpelliccioni closed D4758: Call InvalidateBlock without cs_main held.
Tue, Jan 14, 15:28
fpelliccioni updated the diff for D4758: Call InvalidateBlock without cs_main held.

rebase from master

Tue, Jan 14, 15:20
fpelliccioni committed rABC7504e09fda75: Call RewindBlockIndex without cs_main held (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>).
Call RewindBlockIndex without cs_main held
Tue, Jan 14, 15:19
fpelliccioni closed D4757: Call RewindBlockIndex without cs_main held.
Tue, Jan 14, 15:19
fpelliccioni updated the diff for D4757: Call RewindBlockIndex without cs_main held.

rebase from master

Tue, Jan 14, 15:12

Mon, Jan 13

fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

braces

Mon, Jan 13, 18:16
fpelliccioni requested review of D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:15
fpelliccioni added a comment to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

This clearly includes a lot of code that isn't in the original PR. Where does the clocking mechanism changes come from?

Mon, Jan 13, 18:13
fpelliccioni retitled D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted from Granular invalidateblock and RewindBlockIndex to Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:04
fpelliccioni planned changes to D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:02
fpelliccioni created D4929: Make last disconnected block BLOCK_FAILED_VALID, even when aborted.
Mon, Jan 13, 18:01

Fri, Jan 10

fpelliccioni updated the test plan for D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Fri, Jan 10, 18:59
fpelliccioni updated the diff for D4804: Optimization: don't add txn back to mempool after 10 invalidates.

rebase

Fri, Jan 10, 18:57
fpelliccioni updated the test plan for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Fri, Jan 10, 18:35
fpelliccioni added inline comments to D4758: Call InvalidateBlock without cs_main held.
Fri, Jan 10, 18:34
fpelliccioni updated the diff for D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.

Call FinalizeBlockAndInvalidate without cs_main held

Fri, Jan 10, 18:32
fpelliccioni updated the test plan for D4802: Release cs_main during InvalidateBlock iterations.
Fri, Jan 10, 13:47

Wed, Jan 8

fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

Remove code that removes from setBlockIndexCandidates as FindMostWorkChain() is in charge of it.

Wed, Jan 8, 18:46

Tue, Jan 7

fpelliccioni added inline comments to D4802: Release cs_main during InvalidateBlock iterations.
Tue, Jan 7, 16:01
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

fixes suggested

Tue, Jan 7, 15:32

Fri, Jan 3

fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

fixes tests

Fri, Jan 3, 16:21
fpelliccioni updated the summary of D4758: Call InvalidateBlock without cs_main held.
Fri, Jan 3, 16:12
fpelliccioni updated the test plan for D4758: Call InvalidateBlock without cs_main held.
Fri, Jan 3, 16:11
fpelliccioni updated the diff for D4758: Call InvalidateBlock without cs_main held.

applying changes to UnwindBlock

Fri, Jan 3, 16:10
fpelliccioni planned changes to D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Fri, Jan 3, 12:55
fpelliccioni planned changes to D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Fri, Jan 3, 12:54
fpelliccioni planned changes to D4802: Release cs_main during InvalidateBlock iterations.
Fri, Jan 3, 12:54

Thu, Jan 2

fpelliccioni updated the summary of D4757: Call RewindBlockIndex without cs_main held.
Thu, Jan 2, 20:49
fpelliccioni updated the diff for D4802: Release cs_main during InvalidateBlock iterations.

rebasing

Thu, Jan 2, 20:41
fpelliccioni updated the diff for D4758: Call InvalidateBlock without cs_main held.

rebasing

Thu, Jan 2, 20:33
fpelliccioni updated the diff for D4757: Call RewindBlockIndex without cs_main held.

rebased

Thu, Jan 2, 20:22

Thu, Dec 26

fpelliccioni retitled D4804: Optimization: don't add txn back to mempool after 10 invalidates from Granular invalidateblock and RewindBlockIndex to Optimization: don't add txn back to mempool after 10 invalidates.
Thu, Dec 26, 19:30
fpelliccioni created D4804: Optimization: don't add txn back to mempool after 10 invalidates.
Thu, Dec 26, 19:29
fpelliccioni retitled D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex from Granular invalidateblock and RewindBlockIndex to Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Thu, Dec 26, 19:18
fpelliccioni created D4803: Prevent callback overruns in InvalidateBlock and RewindBlockIndex.
Thu, Dec 26, 19:16
fpelliccioni updated the summary of D4802: Release cs_main during InvalidateBlock iterations.
Thu, Dec 26, 18:56
fpelliccioni edited reviewers for D4802: Release cs_main during InvalidateBlock iterations, added: markblundeberg; removed: Fabien.
Thu, Dec 26, 18:55
fpelliccioni updated the summary of D4802: Release cs_main during InvalidateBlock iterations.
Thu, Dec 26, 18:55
fpelliccioni retitled D4802: Release cs_main during InvalidateBlock iterations from Granular invalidateblock and RewindBlockIndex to Release cs_main during InvalidateBlock iterations.
Thu, Dec 26, 18:54
fpelliccioni created D4802: Release cs_main during InvalidateBlock iterations.
Thu, Dec 26, 18:52

Tue, Dec 24

fpelliccioni added a comment to D4758: Call InvalidateBlock without cs_main held.

Something seems a bit off here -- note that ABC has renamed the 'inner' InvalidateBlock to UnwindBlock in D1952 (not sure why). I think you might be putting the lock in the wrong place, and it should rather go on UnwindBlock.

I didn't want to change the semantics of UnwindBlock because this function is used by ParkBlock.
In any case, I will create another Diff to change ParkBlock.

Hmm, however, in the original PR there will get many many more changes made to UnwindBlock (called InvalidateBlock in Core) -- https://github.com/bitcoin/bitcoin/pull/15402/files#diff-24efdb00bfbe56b140fb006b562cc70bL2787 . The essence of the PR is that UnwindBlock will only take short-term locks during its execution. If we start off like this then it seems none of the following commits will make sense.

Tue, Dec 24, 12:53
fpelliccioni updated the summary of D4757: Call RewindBlockIndex without cs_main held.
Tue, Dec 24, 12:36

Dec 19 2019

fpelliccioni added a comment to D4758: Call InvalidateBlock without cs_main held.

Something seems a bit off here -- note that ABC has renamed the 'inner' InvalidateBlock to UnwindBlock in D1952 (not sure why). I think you might be putting the lock in the wrong place, and it should rather go on UnwindBlock.

Dec 19 2019, 18:04
fpelliccioni added a comment to D4757: Call RewindBlockIndex without cs_main held.

Heh, unfortunate title for this diff now that RewindBlockIndex is gone :-D

Dec 19 2019, 18:02
fpelliccioni accepted D4768: [CMAKE] Add a status message to inform the user that ccache is used.
Dec 19 2019, 15:59
fpelliccioni accepted D4768: [CMAKE] Add a status message to inform the user that ccache is used.
Dec 19 2019, 14:23

Dec 18 2019

fpelliccioni accepted D4728: stop rewinding post-segwit blocks on startup.
Dec 18 2019, 22:10
fpelliccioni requested review of D4758: Call InvalidateBlock without cs_main held.
Dec 18 2019, 18:49
fpelliccioni edited reviewers for D4758: Call InvalidateBlock without cs_main held, added: markblundeberg; removed: Fabien.
Dec 18 2019, 18:48
fpelliccioni retitled D4758: Call InvalidateBlock without cs_main held from Granular invalidateblock and RewindBlockIndex to Call InvalidateBlock without cs_main held.
Dec 18 2019, 18:47
fpelliccioni planned changes to D4758: Call InvalidateBlock without cs_main held.
Dec 18 2019, 18:45
fpelliccioni created D4758: Call InvalidateBlock without cs_main held.
Dec 18 2019, 18:44
fpelliccioni accepted D4728: stop rewinding post-segwit blocks on startup.
Dec 18 2019, 17:48