Page MenuHomePhabricator

hungsam (Hung Sam)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 22 2021, 03:41 (126 w, 6 d)

Recent Activity

Feb 22 2022

hungsam added a comment to D11062: [Cashtab] fix fee calculation.

I was trying to be precise since we are dealing with 'money'.
One or two satoshis may not seem much now but may worth much more in the future.
Beside, the code is pretty simple once we are clear about the structure of a tx.

Feb 22 2022, 02:38

Feb 16 2022

hungsam requested review of D11062: [Cashtab] fix fee calculation.
Feb 16 2022, 02:48

Feb 3 2022

hungsam closed D10969: [Cashtab] fix stale cached data.
Feb 3 2022, 23:51
hungsam committed rABCacc98ce62717: [Cashtab] fix stale cached data (authored by hungsam).
[Cashtab] fix stale cached data
Feb 3 2022, 23:50
hungsam requested review of D10969: [Cashtab] fix stale cached data.
Feb 3 2022, 01:32

Jan 19 2022

hungsam abandoned D10623: [Cashtab] remove hydratedUtxoDetails from wallet state.

will not be needed after we introduce State Management library such as Redux

Jan 19 2022, 23:32
hungsam closed D10792: [Cashtab] cache api calls with Service Worker.
Jan 19 2022, 22:45
hungsam committed rABC939f819b649f: [Cashtab] cache api calls with Service Worker (authored by hungsam).
[Cashtab] cache api calls with Service Worker
Jan 19 2022, 22:45

Jan 11 2022

hungsam updated the diff for D10792: [Cashtab] cache api calls with Service Worker.

Respond to feedback
remove google fonts caches
remove status code 0 from CacheableResponsePlugin

Jan 11 2022, 01:42

Jan 8 2022

hungsam requested review of D10792: [Cashtab] cache api calls with Service Worker.
Jan 8 2022, 06:10

Dec 18 2021

hungsam added inline comments to D10692: [Cashtab] Option to send encrypted messages.
Dec 18 2021, 04:46

Dec 13 2021

hungsam closed D10622: T1920 - fix excessive API Calls on Tx History Fetching.
Dec 13 2021, 22:35
hungsam committed rABC205de92b29e9: T1920 - fix excessive API Calls on Tx History Fetching (authored by hungsam).
T1920 - fix excessive API Calls on Tx History Fetching
Dec 13 2021, 22:35

Dec 9 2021

hungsam updated the diff for D10622: T1920 - fix excessive API Calls on Tx History Fetching.

put the scriptSig classifying logic in a try catch block

Dec 9 2021, 19:38
hungsam updated the diff for D10622: T1920 - fix excessive API Calls on Tx History Fetching.

found a way to classify the scriptSig,
hence updated the diff to parse the tx data based on the type of scriptSig

Dec 9 2021, 02:41

Dec 8 2021

hungsam updated the diff for D10622: T1920 - fix excessive API Calls on Tx History Fetching.

fix lint warnings

Dec 8 2021, 04:39
hungsam updated the diff for D10622: T1920 - fix excessive API Calls on Tx History Fetching.

rebase to the latest master and update replyAddress feature implementation

Dec 8 2021, 00:53

Dec 4 2021

hungsam added a comment to D10616: [Cashtab] Patch for @generated script on osx.

It works, no error.

Dec 4 2021, 00:42
hungsam added a comment to D10623: [Cashtab] remove hydratedUtxoDetails from wallet state.
  • Weird. I just retest and can confirm that sending tx will remove the hydratedUtxoDetails from from both the sending and receiving wallets.
  • The test plan should have more details (my bad, sorry)
  • Here are the steps I did
    • inspect localstorage and verify that hydratedUtxoDetails exists
    • send some xec to another wallet
    • wait for utxos to refresh (10s)
    • refresh the localstorage
    • verify that hydratedUtxoDetails was removed
    • switch to the receiving wallet
    • wait for utxos to refresh (10s)
    • refresh the localstorage
    • verify that hydratedUtxoDetails was removed
Dec 4 2021, 00:34

Dec 3 2021

hungsam requested review of D10623: [Cashtab] remove hydratedUtxoDetails from wallet state.
Dec 3 2021, 05:32
hungsam added a comment to D10614: [Cashtab] Android mobile app.
  • app was successfully installed
  • icon on home screen appears fine, the "e" appears bigger compare to PWA
Dec 3 2021, 03:07
hungsam added a comment to D10616: [Cashtab] Patch for @generated script on osx.

getting "invalid command code ."

Dec 3 2021, 00:08

Dec 2 2021

hungsam requested review of D10622: T1920 - fix excessive API Calls on Tx History Fetching.
Dec 2 2021, 23:56
hungsam closed D10550: [Cashtab] add publicKey property for each of the Path in the wallet.
Dec 2 2021, 22:07
hungsam committed rABCb8860f5ce45f: [Cashtab] add publicKey property for each of the Path in the wallet (authored by hungsam).
[Cashtab] add publicKey property for each of the Path in the wallet
Dec 2 2021, 22:07
hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

rebase to the latest master - that fixes the unit test failure

Dec 2 2021, 20:53
hungsam closed D10612: [Cashtab] update "Migrate legacy wallet on testnet" unit test.
Dec 2 2021, 20:20
hungsam committed rABC8d77b112ed06: [Cashtab] update "Migrate legacy wallet on testnet" unit test (authored by hungsam).
[Cashtab] update "Migrate legacy wallet on testnet" unit test
Dec 2 2021, 20:20
hungsam added a comment to D10602: [Cashtab] Adjust useWebAuthentication to soft fail when visiting from a non https:// source.

The same, on both LAN and Netlify

Dec 2 2021, 19:39
hungsam abandoned D10610: [Cashtab] Refactoring wallet state - disccusion.
Dec 2 2021, 05:12
hungsam requested review of D10612: [Cashtab] update "Migrate legacy wallet on testnet" unit test.
Dec 2 2021, 03:03
hungsam added a comment to D10602: [Cashtab] Adjust useWebAuthentication to soft fail when visiting from a non https:// source.

tested on

  • Samsung S20 FE, Android 11
    • Chrome 96.0.4664.45
    • Firefox 94.1.2
    • Edge 96.0.1054.36
Dec 2 2021, 02:06

Dec 1 2021

hungsam requested review of D10610: [Cashtab] Refactoring wallet state - disccusion.
Dec 1 2021, 23:02
hungsam added a comment to D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

The failure in "Migrating legacy wallet on testnet" was caused by different returned data on Path145 and Path245. Path1899 has the correct data as expected (except additional publicKey).

Dec 1 2021, 02:27

Nov 30 2021

hungsam added inline comments to D10550: [Cashtab] add publicKey property for each of the Path in the wallet.
Nov 30 2021, 22:01
hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

update per feedback

Nov 30 2021, 05:28

Nov 29 2021

hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

rebase to latest master
revert previous fix to 'Mirgrating legacy wallet on testnet' unit test

Nov 29 2021, 23:59
hungsam closed D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.
Nov 29 2021, 23:03
hungsam committed rABC4f64348f48b9: add the ability to lock / unlock the wallet with user's device platform… (authored by hungsam).
add the ability to lock / unlock the wallet with user's device platform…
Nov 29 2021, 23:03
hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

update snapshots test

Nov 29 2021, 22:17
hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

rebase to the latest master branch

Nov 29 2021, 22:13
hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

fix unit test failure on testnet

Nov 29 2021, 04:26

Nov 28 2021

hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

fix unit test failure in "Migrating legacy wallet on testnet"

Nov 28 2021, 23:19

Nov 27 2021

hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

add @generated to the first line of updated snapshots

Nov 27 2021, 01:41
hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

rebase to the latest master

Nov 27 2021, 01:10
hungsam abandoned D10583: rebase to the latest master.
Nov 27 2021, 01:03
hungsam added inline comments to D10550: [Cashtab] add publicKey property for each of the Path in the wallet.
Nov 27 2021, 01:01
hungsam requested review of D10583: rebase to the latest master.
Nov 27 2021, 00:50

Nov 26 2021

hungsam updated the diff for D10550: [Cashtab] add publicKey property for each of the Path in the wallet.

Address unit test failture

  • fix Migrating legacy wallet on mainnet test failure
  • failure in "Migrating legacy wallet on testnet" caused by previous update

as well as this update. Should I wait or go ahead and fix the test with
Path's details on test net?

Nov 26 2021, 07:37
hungsam requested review of D10550: [Cashtab] add publicKey property for each of the Path in the wallet.
Nov 26 2021, 06:31
hungsam abandoned D10549: [Cashtab] add publicKey property for each of the Path in the wallet.
Nov 26 2021, 06:11
hungsam requested review of D10549: [Cashtab] add publicKey property for each of the Path in the wallet.
Nov 26 2021, 06:06

Nov 18 2021

hungsam added a comment to D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

I notice that you are accessing the app through a LAN IP, make sure that it support HTTPS, (or you can accessing it through localhost,). Web Authentication requires HTTPS.
Alternatively, you can build and deploy it to Netlify or Heroku. Here is a link to my Netlify deployment cashtab.netlify.app

Nov 18 2021, 18:53
hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

fix error when PublicKeyCredential is undefined. PublicKeyCredential requires https.

Nov 18 2021, 06:06

Nov 11 2021

hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

update snapshots (now have @generated added to the end of first line)

Nov 11 2021, 05:14
hungsam updated the diff for D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.

update snapshots

Nov 11 2021, 04:34
hungsam added a comment to D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.
  • Tested on Samsung S20 FE, Samsung J7 Prime, Iphone SE, Ipad, Surface 5, Surface Pro 5, Desktop with Windows 10, Laptop with Windows 11
  • I did notice the test failures and working the address that.
  • About the New unit tests for this feature, should it be included in this diff? should it be another diff after this?
Nov 11 2021, 01:05

Nov 9 2021

hungsam requested review of D10443: add the ability to lock / unlock the wallet with user's device platform autheticator.
Nov 9 2021, 12:34