Page MenuHomePhabricator

josephroyking (Joey)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (31 w, 3 d)

Recent Activity

Fri, May 28

josephroyking requested review of D9605: [Cashtab] Extension version bump.
Fri, May 28, 21:59
josephroyking requested review of D9604: [Cashtab] Replace web hosted pkg with npm module.
Fri, May 28, 16:19

Wed, May 26

josephroyking updated the diff for D9586: [Cashtab] Patch bug in fee calculation for token creation.

Removing diff error import

Wed, May 26, 17:21
josephroyking requested review of D9586: [Cashtab] Patch bug in fee calculation for token creation.
Wed, May 26, 17:19
josephroyking requested changes to D9569: [Cashtab] Remove console logging when in production environment.

For now, I still have slpBalancesAndUtxos in the console in prod -- it helps for testing in case there is some unforeseen issue.

Wed, May 26, 16:27

Tue, May 25

josephroyking accepted D9585: [cashtab] update REST endpoint url.
Tue, May 25, 16:53

Sun, May 23

josephroyking planned changes to D9570: [Cashtab] Only hydrate changed utxos.

CAUTION: Only run this diff with new wallets created for testing. Still issues in utxo matching. Running with an existing wallet may lead to balance errors and require re-importing the wallet.

Sun, May 23, 20:07
josephroyking requested review of D9570: [Cashtab] Only hydrate changed utxos.
Sun, May 23, 20:05
josephroyking accepted D9568: [Cashtab] Reduce bundle size by about ~50%.
Sun, May 23, 18:02

Wed, May 19

josephroyking requested review of D9555: [Cashtab] Reduce default fee.
Wed, May 19, 12:58

Sat, May 15

josephroyking accepted D9535: [website] Add info for people who forgot to upgrade their node.
Sat, May 15, 22:17
josephroyking accepted D9531: [website] Update upgrade message to post-upgrade.
Sat, May 15, 13:53

May 13 2021

josephroyking requested review of D9521: [Cashtab] Compare latest utxo set to stored wallet state.
May 13 2021, 14:02

May 12 2021

josephroyking requested review of D9516: [Cashtab] Bugfix in haveUtxosChanged.
May 12 2021, 20:19

May 11 2021

josephroyking updated the diff for D9496: [Cashtab] Show token info on Send Token screen.

Rebase

May 11 2021, 19:43

May 10 2021

josephroyking requested review of D9496: [Cashtab] Show token info on Send Token screen.
May 10 2021, 22:19
josephroyking requested review of D9495: [Cashtab] Change dust param from BCHA to sats.
May 10 2021, 20:59

May 9 2021

josephroyking accepted D9488: [website] Update Cain sponsor link.
May 9 2021, 05:06

May 7 2021

josephroyking accepted D9486: [website] Add an image to the upgrade page.
May 7 2021, 21:53
josephroyking accepted D9485: [website] Add dedicated upgrade page.
May 7 2021, 17:31
josephroyking requested review of D9484: [Cashtab] Patch z-index css issue in forms vs footer.
May 7 2021, 15:42

May 6 2021

josephroyking updated the summary of D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 20:24
josephroyking updated the diff for D9481: [Cashtab] Reduce bundle size by 70kb (10%).

Only include used lodash functions

May 6 2021, 20:22
josephroyking requested review of D9481: [Cashtab] Reduce bundle size by 70kb (10%).
May 6 2021, 20:05
josephroyking requested review of D9480: [Cashtab] standardize balance header components.
May 6 2021, 13:52

May 5 2021

josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Mark snapshots @generated

May 5 2021, 23:30
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Improve speed of form by making it its own react component, parse Genesis transactions in txHistory, unit tests for each

May 5 2021, 23:26
josephroyking requested review of D9479: [Cashtab] Patch validation bug on settings page.
May 5 2021, 17:52
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Unit tests for token genesis validation functions and css bug fix

May 5 2021, 11:39

May 4 2021

josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Remove duplicate import

May 4 2021, 22:00
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Handle invalid wallet case with thrown error + add unit test for this

May 4 2021, 21:59
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Hide unit test mock for createToken function

May 4 2021, 21:49
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Add unit test for new createToken function, correct css bug in new TokenCollapse component

May 4 2021, 21:48
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Updating snapshots on unit tests

May 4 2021, 21:14
josephroyking updated the diff for D9475: [Cashtab] MVP token creation.

Hide generated snapshot file

May 4 2021, 21:07
josephroyking requested review of D9475: [Cashtab] MVP token creation.
May 4 2021, 21:03
josephroyking accepted D9472: [cashtab] enable gzip compression when serving cashtab.
May 4 2021, 16:26

Apr 30 2021

josephroyking accepted D9466: [cashtab] replace deprecated eslint-loader, bump eslint version.
Apr 30 2021, 23:41
josephroyking updated the diff for D9467: [Cashtab] Use live wallet.state tokens obj if present.

Mark snapshot as generated

Apr 30 2021, 22:37
josephroyking requested review of D9467: [Cashtab] Use live wallet.state tokens obj if present.
Apr 30 2021, 22:35

Apr 29 2021

josephroyking updated the diff for D9460: [Cashtab] Reduce bundle size.

Back out antd upgrade in this diff, use same version of nodejs as last package.json change

Apr 29 2021, 15:57
josephroyking requested review of D9460: [Cashtab] Reduce bundle size.
Apr 29 2021, 15:08
josephroyking abandoned D9458: [Cashtab] Remove largest npm bundles and bug fix.
Apr 29 2021, 15:00
josephroyking requested review of D9459: [Cashtab] bug fix in utxo diff check.
Apr 29 2021, 14:48
josephroyking updated the diff for D9458: [Cashtab] Remove largest npm bundles and bug fix.

Remove commented out import

Apr 29 2021, 13:23
josephroyking requested review of D9458: [Cashtab] Remove largest npm bundles and bug fix.
Apr 29 2021, 13:19

Apr 28 2021

josephroyking requested review of D9451: [Cashtab] Use wallet.state for balance on Send screen.
Apr 28 2021, 12:43

Apr 26 2021

josephroyking accepted D9447: [website] Add warning about coin splitting scams.
Apr 26 2021, 21:47
josephroyking updated the diff for D9443: [Cashtab] load wallet from storage before calling API.

Allow useEffect call to update savedWallets list in Configure.js; do not call it twice with the previous wallet

Apr 26 2021, 20:16
josephroyking updated the diff for D9443: [Cashtab] load wallet from storage before calling API.

Handle case of cashtab user loading with unmigrated wallets, ensure that wallet object state is kept current

Apr 26 2021, 15:08

Apr 23 2021

josephroyking updated the diff for D9443: [Cashtab] load wallet from storage before calling API.

Removing obsolete dev comment

Apr 23 2021, 15:36
josephroyking updated the diff for D9443: [Cashtab] load wallet from storage before calling API.

Removing comments used in development, marking mock as generated

Apr 23 2021, 15:33
josephroyking requested review of D9443: [Cashtab] load wallet from storage before calling API.
Apr 23 2021, 15:29

Apr 20 2021

josephroyking requested review of D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Apr 20 2021, 18:01
josephroyking updated the diff for D9424: [Cashtab] Load from cache on startup.

Implementing isValidStoredWallet in useWallet.js

Apr 20 2021, 13:47
josephroyking added a comment to D9424: [Cashtab] Load from cache on startup.

So the previous content of the if statement was not a bool ?

Apr 20 2021, 13:44

Apr 19 2021

josephroyking updated the diff for D9424: [Cashtab] Load from cache on startup.

Modified isValidStoredWallet to return bool (required some changes, is now a more specific validation function)

Apr 19 2021, 21:28
josephroyking updated the diff for D9424: [Cashtab] Load from cache on startup.

Responding to code review feedback

Apr 19 2021, 14:26
josephroyking added inline comments to D9424: [Cashtab] Load from cache on startup.
Apr 19 2021, 14:26

Apr 15 2021

josephroyking requested review of D9424: [Cashtab] Load from cache on startup.
Apr 15 2021, 14:28

Apr 13 2021

josephroyking requested review of D9400: [Cashtab] Cache wallet state in indexedDb.
Apr 13 2021, 17:03

Apr 12 2021

josephroyking updated the diff for D9393: [Cashtab] Batch utxo requests to hydrateUtxos.

Remove extra comment, mark mocks as generated

Apr 12 2021, 19:31

Apr 9 2021

josephroyking requested review of D9393: [Cashtab] Batch utxo requests to hydrateUtxos.
Apr 9 2021, 17:24
josephroyking requested review of D9392: [Cashtab] fix typo.
Apr 9 2021, 14:30

Apr 8 2021

josephroyking requested review of D9391: [Cashtab] Temp disable token send for 9-decimal tokens.
Apr 8 2021, 16:10

Mar 31 2021

josephroyking added a comment to D9359: [Cashtab] Add latest features to browser extension.

Yes -- done

Mar 31 2021, 13:16
josephroyking updated the diff for D9359: [Cashtab] Add latest features to browser extension.

Rebase to include D9362

Mar 31 2021, 13:15

Mar 30 2021

josephroyking requested review of D9362: [Cashtab] Exclude slp utxos if tokenQty is 0.
Mar 30 2021, 19:43
josephroyking updated the diff for D9359: [Cashtab] Add latest features to browser extension.

rebase to include D9358

Mar 30 2021, 16:11

Mar 29 2021

josephroyking requested review of D9359: [Cashtab] Add latest features to browser extension.
Mar 29 2021, 22:44
josephroyking requested review of D9358: [Cashtab] Add fiat price value to tx history.
Mar 29 2021, 18:33

Mar 26 2021

josephroyking updated the diff for D9348: [Cashtab] Parse token txs in tx history.

Add unit tests with mocks for parsing token txs, limit rendered tx count to 5 (api load evident in testing), set rendered tx count as a parameter in Ticker.js

Mar 26 2021, 22:54

Mar 25 2021

josephroyking accepted D9349: [website] Fix image alt tag for STEX exchange.
Mar 25 2021, 02:36

Mar 24 2021

josephroyking requested review of D9348: [Cashtab] Parse token txs in tx history.
Mar 24 2021, 19:12
josephroyking accepted D9346: [website] Add Huobi to list of BCHA-supporting exchanges.
Mar 24 2021, 03:29

Mar 23 2021

josephroyking updated the diff for D9344: [Cashtab] toggle display between tx history and tokens.

Less ambiguous send/receive icons

Mar 23 2021, 18:27

Mar 22 2021

josephroyking updated the diff for D9344: [Cashtab] toggle display between tx history and tokens.

Better active pane underline css (previously did not line up in Firefox)

Mar 22 2021, 21:44
josephroyking requested review of D9344: [Cashtab] toggle display between tx history and tokens.
Mar 22 2021, 21:33

Mar 19 2021

josephroyking accepted D9336: [WEBSITE] Add an upgrade notice banner to the release page.
Mar 19 2021, 17:55
josephroyking requested review of D9337: [Cashtab] Upgrading pkg dependencies.
Mar 19 2021, 17:18

Mar 18 2021

josephroyking updated the diff for D9328: [Cashtab] Add tx history.

Handle unconfirmed txs, remove redundant txHistory prop and instead only use parsedTxHistory to check if wallet is new

Mar 18 2021, 16:01
josephroyking added inline comments to D9328: [Cashtab] Add tx history.
Mar 18 2021, 12:45
josephroyking updated the diff for D9328: [Cashtab] Add tx history.

Resolving comments. Keeping explorer.be.cash for now though because it parses token txs.

Mar 18 2021, 12:43
josephroyking requested review of D9328: [Cashtab] Add tx history.
Mar 18 2021, 00:33

Mar 12 2021

josephroyking requested review of D9322: [Cashtab] Move all colors to theme.
Mar 12 2021, 21:02

Mar 11 2021

josephroyking requested review of D9321: [Cashtab] Remove all colors from App.css.
Mar 11 2021, 20:09
josephroyking requested review of D9315: [Cashtab] migrating more form css to styled components.
Mar 11 2021, 04:32

Mar 9 2021

josephroyking requested review of D9312: [Cashtab] Form elements to themed styled components.
Mar 9 2021, 18:29

Mar 8 2021

josephroyking requested review of D9308: [Cashtab] Add theming to better organize color changes.
Mar 8 2021, 22:42
josephroyking requested review of D9307: [Cashtab] remove unused qr code border css.
Mar 8 2021, 21:54

Mar 4 2021

josephroyking requested review of D9299: [Cashtab] Remove legacy css.
Mar 4 2021, 21:47
josephroyking accepted D9298: [website] Clean up social media links.
Mar 4 2021, 20:39

Mar 3 2021

josephroyking requested review of D9296: [Cashtab] Pull spinner color out of css.
Mar 3 2021, 18:49

Mar 2 2021

josephroyking updated the diff for D9289: [Cashtab] Error handling for formatBalance.

Return x instead of '0' in catch loop

Mar 2 2021, 13:29
josephroyking requested review of D9289: [Cashtab] Error handling for formatBalance.
Mar 2 2021, 13:17

Mar 1 2021

josephroyking requested review of D9287: [Cashtab] Replace commas as thousands separator with space.
Mar 1 2021, 23:58
josephroyking requested review of D9286: [Cashtab] URGENT patch balance display bug in Safari.
Mar 1 2021, 23:32
josephroyking requested review of D9285: [Cashtab] Migrate some css to styled components.
Mar 1 2021, 22:14

Feb 26 2021

josephroyking requested review of D9283: [Cashtab] Add commas to formatted displays of large numbers.
Feb 26 2021, 23:35
josephroyking requested review of D9282: [Cashtab] Improve nav buttons.
Feb 26 2021, 22:17