Page MenuHomePhabricator

josephroyking (Joey)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 5 2020, 18:28 (17 w, 4 d)

Recent Activity

Thu, Mar 4

josephroyking requested review of D9299: [Cashtab] Remove legacy css.
Thu, Mar 4, 21:47
josephroyking accepted D9298: [website] Clean up social media links.
Thu, Mar 4, 20:39

Wed, Mar 3

josephroyking requested review of D9296: [Cashtab] Pull spinner color out of css.
Wed, Mar 3, 18:49

Tue, Mar 2

josephroyking updated the diff for D9289: [Cashtab] Error handling for formatBalance.

Return x instead of '0' in catch loop

Tue, Mar 2, 13:29
josephroyking requested review of D9289: [Cashtab] Error handling for formatBalance.
Tue, Mar 2, 13:17

Mon, Mar 1

josephroyking requested review of D9287: [Cashtab] Replace commas as thousands separator with space.
Mon, Mar 1, 23:58
josephroyking requested review of D9286: [Cashtab] URGENT patch balance display bug in Safari.
Mon, Mar 1, 23:32
josephroyking requested review of D9285: [Cashtab] Migrate some css to styled components.
Mon, Mar 1, 22:14

Fri, Feb 26

josephroyking requested review of D9283: [Cashtab] Add commas to formatted displays of large numbers.
Fri, Feb 26, 23:35
josephroyking requested review of D9282: [Cashtab] Improve nav buttons.
Fri, Feb 26, 22:17
josephroyking requested review of D9281: [Cashtab] Move toSmallestDenomination function to utils.
Fri, Feb 26, 21:19
josephroyking requested review of D9280: [Cashtab] Replace toBitcoinCash function.
Fri, Feb 26, 18:55

Mon, Feb 22

josephroyking updated the diff for D9250: [Cashtab] Enable special features if wallet has specific eToken.

Implementing suggested changes

Mon, Feb 22, 20:18

Sat, Feb 20

josephroyking requested review of D9250: [Cashtab] Enable special features if wallet has specific eToken.
Sat, Feb 20, 22:07

Thu, Feb 18

josephroyking updated the test plan for D9243: [Cashtab] fix css issue with long wallet display names.
Thu, Feb 18, 14:27

Wed, Feb 17

josephroyking requested review of D9243: [Cashtab] fix css issue with long wallet display names.
Wed, Feb 17, 21:08
josephroyking updated the diff for D9233: [Cashtab] show active wallet on home.

Bold, bump font size, remove margin bottom, remove unnecessary !important flag

Wed, Feb 17, 17:55

Tue, Feb 16

josephroyking requested review of D9235: [cashtab-components] More unit tests for helper functions.
Tue, Feb 16, 21:16
josephroyking accepted D9234: [website] Add MXC.com to list of exchanges on BCHA page.
Tue, Feb 16, 20:38
josephroyking updated the diff for D9233: [Cashtab] show active wallet on home.

Apply active wallet label in standardized way to all screens

Tue, Feb 16, 19:12
josephroyking added a comment to D9233: [Cashtab] show active wallet on home.

Here's what it looks like

Tue, Feb 16, 14:21
josephroyking requested review of D9233: [Cashtab] show active wallet on home.
Tue, Feb 16, 14:20
josephroyking accepted D9231: [CI] Run cashtab components tests on CI.
Tue, Feb 16, 14:13

Sat, Feb 13

josephroyking accepted D9224: [website] Remove Kucoin from exchanges list.
Sat, Feb 13, 22:25
josephroyking accepted D9223: [website] Update exchanges list for BCHA page.
Sat, Feb 13, 14:22
josephroyking accepted D9222: [website] Fix some image alt tags.
Sat, Feb 13, 14:15

Fri, Feb 12

josephroyking requested review of D9221: [Cashtab] Update cashtab docs links to point to web wallet docs.
Fri, Feb 12, 23:18
josephroyking accepted D9219: [website] Add be.cash explorer to BCHA info page.
Fri, Feb 12, 18:47
josephroyking accepted D9220: [website] Add Coin Dance to BCHA info page.
Fri, Feb 12, 18:46

Thu, Feb 11

josephroyking requested review of D9216: [cashtab-components] adding unit test framework.
Thu, Feb 11, 21:28
josephroyking updated the diff for D9215: [Cashtab] Improve design on Settings page.

Update unit test snapshot to match typo fix

Thu, Feb 11, 20:04
josephroyking updated the diff for D9215: [Cashtab] Improve design on Settings page.

"Backup" instead of "Back up"

Thu, Feb 11, 19:55
josephroyking added a comment to D9215: [Cashtab] Improve design on Settings page.

Currently in prod:

Thu, Feb 11, 19:53
josephroyking requested review of D9215: [Cashtab] Improve design on Settings page.
Thu, Feb 11, 19:49
josephroyking added a comment to D9213: [Cashtab] Clean up onboarding page + docs link.

Here's how it looks with this update

Thu, Feb 11, 13:15
josephroyking requested review of D9213: [Cashtab] Clean up onboarding page + docs link.
Thu, Feb 11, 13:14

Wed, Feb 10

josephroyking updated the diff for D9209: [cashtab-docs] remove BCH logo from twitter card.

Swap color pattern to match original

Wed, Feb 10, 22:43
josephroyking requested review of D9209: [cashtab-docs] remove BCH logo from twitter card.
Wed, Feb 10, 22:40
josephroyking requested review of D9208: [cashtab-docs] Add google analytics.
Wed, Feb 10, 19:42
josephroyking requested review of D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.

Removed as they were not present in the card generated for docs.cashtabapp.com, which now works. So, they are either causing an error or unnecessary.

Wed, Feb 10, 19:33
josephroyking requested review of D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.
Wed, Feb 10, 19:20
josephroyking requested review of D9206: [Cashtab] Add twitter card.
Wed, Feb 10, 18:57
josephroyking requested review of D9205: [cashtab-docs] patch title so twitter card shows distinct title, tagline.
Wed, Feb 10, 18:40
josephroyking requested review of D9204: [cashtab-docs] correct url to match deployment to fix tiwtter card.
Wed, Feb 10, 17:23
josephroyking requested review of D9203: [docs-cashtab] night mode default and twitter preview card.
Wed, Feb 10, 15:53

Feb 5 2021

josephroyking updated the diff for D9180: [Cashtab] Apply BigNumber to all base unit calcs in sendBch.

Capitalization nit in test title

Feb 5 2021, 16:11
josephroyking requested review of D9180: [Cashtab] Apply BigNumber to all base unit calcs in sendBch.
Feb 5 2021, 16:10
josephroyking accepted D9179: doc: elaborate on release notes wrt netmasks.

Looks good to me.

Feb 5 2021, 15:20

Feb 4 2021

josephroyking requested review of D9177: [Cashtab] change hover text for wallet mgmt icons.
Feb 4 2021, 21:34
josephroyking requested review of D9174: [Docusaurus] Adding docker deployment files.
Feb 4 2021, 19:54
josephroyking requested review of D9173: [Cashtab] Remove final instance of toSatoshi().
Feb 4 2021, 19:30
josephroyking requested review of D9167: [Cashtab] Incoming notifications use ticker variable.
Feb 4 2021, 15:04
josephroyking requested review of D9166: [Cashtab] Remove instance of toSatoshi from tx builder.
Feb 4 2021, 14:57
josephroyking accepted D9165: [backport#14848] docs: Fix broken Gmane URL in security-check.py.

Confirm that previous link is dead and new link is live. I am not personally familiar with what is being explained by https://marc.info/?l=binutils&m=1498883354122353 but the subject matches the code context.

Feb 4 2021, 13:59
josephroyking updated the diff for D9161: [Cashtab] Remove mint artifact object of arrays style input.

Removing bcha-specific variable name

Feb 4 2021, 13:55

Feb 3 2021

josephroyking added a comment to D9160: [Docusaurus] fix broken link to BCHA info page.

Handled this in latest amendment to D9155, thanks!

Feb 3 2021, 22:46
josephroyking updated the diff for D9155: [Docs] MVP documentation.

Remove hello from title, update desc from default, fix /bcha/ page broken link

Feb 3 2021, 22:45
josephroyking requested review of D9161: [Cashtab] Remove mint artifact object of arrays style input.
Feb 3 2021, 22:41
josephroyking requested review of D9155: [Docs] MVP documentation.
Feb 3 2021, 19:33
josephroyking updated the diff for D9144: [Cashtab] Patch validation error preventing send of amounts with less than 8 decimal places.

Adding unit test for this case

Feb 3 2021, 14:45
josephroyking requested review of D9144: [Cashtab] Patch validation error preventing send of amounts with less than 8 decimal places.
Feb 3 2021, 14:43
josephroyking requested review of D9139: [Cashtab] Typo fix.
Feb 3 2021, 13:34
josephroyking requested review of D9136: [Cashtab] Replace remaining instances of CashTab with Cashtab.
Feb 3 2021, 03:37

Feb 2 2021

josephroyking updated the diff for D9127: [Cashtab] Replace toSatoshi method in satoshisToSend calc.

More unit tests, tests pass when currency.cashDecimals is changed, throw validation error if input decimals do not match cashDecimals

Feb 2 2021, 21:46

Feb 1 2021

josephroyking updated the diff for D9087: [Cashtab] Adding stub dev docs with facebook docusaurus.

Replace docusaurus stub settings and copy, add extension stub page

Feb 1 2021, 22:29
josephroyking requested review of D9127: [Cashtab] Replace toSatoshi method in satoshisToSend calc.
Feb 1 2021, 21:40
josephroyking updated the diff for D9087: [Cashtab] Adding stub dev docs with facebook docusaurus.

Replacing yarn with npm, removing blog, replacing docusaurus stubs with cashtab stubs

Feb 1 2021, 20:17
josephroyking updated the diff for D9091: [Web - New] Adding cashtab-components source.

README patch, .gitignore remove yarn

Feb 1 2021, 14:27

Jan 29 2021

josephroyking updated the diff for D9091: [Web - New] Adding cashtab-components source.

Delete yarn.lock (bitcoin-abc repo uses npm, not yarn)

Jan 29 2021, 13:48
josephroyking updated the test plan for D9091: [Web - New] Adding cashtab-components source.
Jan 29 2021, 13:46
josephroyking requested review of D9102: [Cashtab] replace legacy DUST param with constant.

Eventually, the remainder parameter and all similar parameters in the sendBch function will need to be a BigNumber, and compare operations will need to use BigNumber methods like .gte instead of >=. For now, this change only replaces the one-off DUST variable with the now-established app-wide constant currency.dust. Because this diff does not apply any BigNumber methods, it is only replacing DUST with currency.dust; the test makes sure that we are still getting a number of the same type.

Jan 29 2021, 11:20

Jan 28 2021

josephroyking requested review of D9102: [Cashtab] replace legacy DUST param with constant.
Jan 28 2021, 14:05
josephroyking updated the diff for D9100: [Cashtab] Clean up unit tests.

Add 1.01 fee as constant in unit test to match previous version

Jan 28 2021, 12:08
josephroyking requested review of D9100: [Cashtab] Clean up unit tests.
Jan 28 2021, 12:05
josephroyking added a comment to D9056: [Cashtab] Add unit tests for function that sends BCHA.

Abandoned in favor of alternative approach provided by (landed) D9088

Jan 28 2021, 11:41

Jan 27 2021

josephroyking requested review of D9091: [Web - New] Adding cashtab-components source.
Jan 27 2021, 21:01
josephroyking requested review of D9089: [Cashtab patch] Adjust input field step for cash or crypto.
Jan 27 2021, 20:16
josephroyking requested review of D9088: [Cashtab] Make tx fee in sats/byte a param.
Jan 27 2021, 20:05
josephroyking requested review of D9087: [Cashtab] Adding stub dev docs with facebook docusaurus.
Jan 27 2021, 19:21

Jan 26 2021

josephroyking updated the diff for D9056: [Cashtab] Add unit tests for function that sends BCHA.

Refactor unit tests for standardized fee levels

Jan 26 2021, 21:22

Jan 25 2021

josephroyking requested review of D9056: [Cashtab] Add unit tests for function that sends BCHA.
Jan 25 2021, 22:14
josephroyking updated the diff for D9054: [Cashtab] replace BCHA decimal unit with a constant.

Removing comment with hardcoded 8

Jan 25 2021, 16:49
josephroyking added a comment to D9054: [Cashtab] replace BCHA decimal unit with a constant.

There is a .decimals parameter for token utxos, which can be between 0 and 9 inclusive depending on the SLPA token. I wanted to avoid duplicating this key, which is used directly on the SendToken.js page.

Jan 25 2021, 16:45
josephroyking updated the diff for D9054: [Cashtab] replace BCHA decimal unit with a constant.

Replace '8' with currency.cashDecimals in validation error msg

Jan 25 2021, 15:58
josephroyking requested review of D9054: [Cashtab] replace BCHA decimal unit with a constant.
Jan 25 2021, 15:55
josephroyking abandoned D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.

Implemented in other diffs

Jan 25 2021, 15:34
josephroyking requested review of D9052: [Cashtab] Match app send min to backend send min with constant.
Jan 25 2021, 12:34

Jan 23 2021

josephroyking updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Fix typo in comment, "more" to "no more"

Jan 23 2021, 15:13
josephroyking updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Clarify comment in function

Jan 23 2021, 10:35
josephroyking updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Ensure function fiatToCrypto returns a string, add unit test

Jan 23 2021, 10:34

Jan 22 2021

josephroyking updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Ensure testedAmount is still validated as a BigNumber if user selected USD

Jan 22 2021, 17:14
josephroyking updated the diff for D9045: [Cashtab] Implement BigNumber.js for crypto amounts.

Remove unused BigNumber.js import from validation.test.js

Jan 22 2021, 17:08
josephroyking requested review of D9045: [Cashtab] Implement BigNumber.js for crypto amounts.
Jan 22 2021, 17:06
josephroyking updated the diff for D9021: [Cashtab] Add unit tests for send BCHA amount validation.

Function rename in Send.js

Jan 22 2021, 12:02
josephroyking updated the diff for D9021: [Cashtab] Add unit tests for send BCHA amount validation.

Make all test inputs strings, better function name for validation method

Jan 22 2021, 11:35

Jan 21 2021

josephroyking requested review of D9021: [Cashtab] Add unit tests for send BCHA amount validation.
Jan 21 2021, 22:01
josephroyking planned changes to D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.

Cashtab does not have unit tests for these validation functions, will create some to support this change.

Jan 21 2021, 21:13
josephroyking requested review of D9019: [Cashtab] Convert BCHA send form validation to use BigNumber.js.
Jan 21 2021, 21:01
josephroyking added a comment to D9018: [Cashtab] Reject transactions lower than backend dust limit.

The figure 0.00000546 is the dust limit of the bch-api backend. If the app attempts to broadcast a transaction sending less then 0.00000546 BCHA, an error will be returned from the API. These hard coded 546-sat figures will be replaced by currency.ticker once the app sending limit is brought in line with the backend limit in a future diff.

Jan 21 2021, 20:24
josephroyking requested review of D9018: [Cashtab] Reject transactions lower than backend dust limit.
Jan 21 2021, 20:11