- User Since
- Nov 5 2020, 18:28 (17 w, 4 d)
Thu, Mar 4
Wed, Mar 3
Tue, Mar 2
Return x instead of '0' in catch loop
Mon, Mar 1
Fri, Feb 26
Mon, Feb 22
Implementing suggested changes
Sat, Feb 20
Thu, Feb 18
Wed, Feb 17
Bold, bump font size, remove margin bottom, remove unnecessary !important flag
Tue, Feb 16
Apply active wallet label in standardized way to all screens
Here's what it looks like
Sat, Feb 13
Fri, Feb 12
Thu, Feb 11
Update unit test snapshot to match typo fix
"Backup" instead of "Back up"
Currently in prod:
Here's how it looks with this update
Wed, Feb 10
Swap color pattern to match original
Removed as they were not present in the card generated for docs.cashtabapp.com, which now works. So, they are either causing an error or unnecessary.
Feb 5 2021
Capitalization nit in test title
Looks good to me.
Feb 4 2021
Confirm that previous link is dead and new link is live. I am not personally familiar with what is being explained by https://marc.info/?l=binutils&m=1498883354122353 but the subject matches the code context.
Removing bcha-specific variable name
Feb 3 2021
Handled this in latest amendment to D9155, thanks!
Remove hello from title, update desc from default, fix /bcha/ page broken link
Adding unit test for this case
Feb 2 2021
More unit tests, tests pass when currency.cashDecimals is changed, throw validation error if input decimals do not match cashDecimals
Feb 1 2021
Replace docusaurus stub settings and copy, add extension stub page
Replacing yarn with npm, removing blog, replacing docusaurus stubs with cashtab stubs
README patch, .gitignore remove yarn
Jan 29 2021
Delete yarn.lock (bitcoin-abc repo uses npm, not yarn)
Eventually, the remainder parameter and all similar parameters in the sendBch function will need to be a BigNumber, and compare operations will need to use BigNumber methods like .gte instead of >=. For now, this change only replaces the one-off DUST variable with the now-established app-wide constant currency.dust. Because this diff does not apply any BigNumber methods, it is only replacing DUST with currency.dust; the test makes sure that we are still getting a number of the same type.
Jan 28 2021
Add 1.01 fee as constant in unit test to match previous version
Abandoned in favor of alternative approach provided by (landed) D9088
Jan 27 2021
Jan 26 2021
Refactor unit tests for standardized fee levels
Jan 25 2021
Removing comment with hardcoded 8
There is a .decimals parameter for token utxos, which can be between 0 and 9 inclusive depending on the SLPA token. I wanted to avoid duplicating this key, which is used directly on the SendToken.js page.
Replace '8' with currency.cashDecimals in validation error msg
Implemented in other diffs
Jan 23 2021
Fix typo in comment, "more" to "no more"
Clarify comment in function
Ensure function fiatToCrypto returns a string, add unit test
Jan 22 2021
Ensure testedAmount is still validated as a BigNumber if user selected USD
Remove unused BigNumber.js import from validation.test.js
Function rename in Send.js
Make all test inputs strings, better function name for validation method
Jan 21 2021
Cashtab does not have unit tests for these validation functions, will create some to support this change.
The figure 0.00000546 is the dust limit of the bch-api backend. If the app attempts to broadcast a transaction sending less then 0.00000546 BCHA, an error will be returned from the API. These hard coded 546-sat figures will be replaced by currency.ticker once the app sending limit is brought in line with the backend limit in a future diff.