Page MenuHomePhabricator

kieran709 (kieran oconnell)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 28 2021, 14:42 (61 w, 6 h)

Recent Activity

Today

kieran709 closed D12684: [Cashtab] Remove unused screenshots folder.
Tue, Nov 29, 21:09
kieran709 committed rABC842e09e1e2d5: [Cashtab] Remove unused screenshots folder (authored by kieran709).
[Cashtab] Remove unused screenshots folder
Tue, Nov 29, 21:09
kieran709 requested review of D12692: [xec-web-components][Pt1]Create component lib: Initial commit.
Tue, Nov 29, 21:08
kieran709 abandoned D12686: [xec-web-components] Initial commit for xec-web-components library.
Tue, Nov 29, 17:50
kieran709 accepted D12662: [Cashtab] [Simplify wallet structure p8] Remove debug logging.
Tue, Nov 29, 16:06

Yesterday

kieran709 accepted D12661: [Cashtab] [Simplify wallet structure p7] Patch bug in variable definition.
Mon, Nov 28, 23:46
kieran709 accepted D12660: [Cashtab] [Simplify wallet structure p6] Ensure last final variable calcs match final variable names.
Mon, Nov 28, 23:44
kieran709 accepted D12659: [Cashtab] [Simplify wallet structure p5] Remove function specific variable name change.
Mon, Nov 28, 23:28
kieran709 accepted D12681: [Cashtab] [deprecate etoken addresses p4] Add temp info blurb to Receive.
Mon, Nov 28, 23:17
kieran709 accepted D12680: [Cashtab] [deprecate etoken addresses p3] Remove address switch on receive screen.
Mon, Nov 28, 23:15
kieran709 accepted D12679: [Cashtab] [deprecate etoken addresses p2] Remove type-specific address descriptors from placeholders and error msgs.
Mon, Nov 28, 23:13
kieran709 accepted D12677: [Cashtab] [deprecate etoken addresses p1] Support token sends to ecash: addresses.
Mon, Nov 28, 23:11
kieran709 added a reviewer for D12686: [xec-web-components] Initial commit for xec-web-components library: emack.
Mon, Nov 28, 23:06
kieran709 updated the diff for D12686: [xec-web-components] Initial commit for xec-web-components library.

Removed content from README as it was irrelevant to the library.

Mon, Nov 28, 22:47
kieran709 requested review of D12686: [xec-web-components] Initial commit for xec-web-components library.
Mon, Nov 28, 22:44
kieran709 requested review of D12684: [Cashtab] Remove unused screenshots folder.
Mon, Nov 28, 19:29
kieran709 abandoned D12683: [xec-web-components][TEST] xec-web-components initial commit.
Mon, Nov 28, 19:13
kieran709 requested review of D12683: [xec-web-components][TEST] xec-web-components initial commit.
Mon, Nov 28, 19:11
kieran709 closed D12640: [Cashtab] Patch overlapping text on amount input error Send.js.
Mon, Nov 28, 19:03
kieran709 committed rABC5d37f08561d1: [Cashtab] Patch overlapping text on amount input error Send.js (authored by kieran709).
[Cashtab] Patch overlapping text on amount input error Send.js
Mon, Nov 28, 19:03
kieran709 accepted D12641: [Cashtab] Remove unused imports from test file.
Mon, Nov 28, 19:01
kieran709 accepted D12682: [Cashtab] Improve SEO.
Mon, Nov 28, 18:10

Sat, Nov 26

kieran709 accepted D12625: [Cashtab] [Simplify wallet structure p4] Remove parent artifact object slpBalancesAndUtxos.
Sat, Nov 26, 08:16

Fri, Nov 25

kieran709 added a reviewer for D12640: [Cashtab] Patch overlapping text on amount input error Send.js: emack.
Fri, Nov 25, 21:54
kieran709 updated the summary of D12640: [Cashtab] Patch overlapping text on amount input error Send.js.
Fri, Nov 25, 21:36
kieran709 requested review of D12640: [Cashtab] Patch overlapping text on amount input error Send.js.
Fri, Nov 25, 21:35
kieran709 accepted D12638: [Cashtab] Patch dependency webpack error for local-ecpair.
Fri, Nov 25, 19:32
kieran709 closed D12609: [Cashtab] Patch address input height in Send.js.
Fri, Nov 25, 16:37
kieran709 committed rABC5ec163c4a1d8: [Cashtab] Patch address input height in Send.js (authored by kieran709).
[Cashtab] Patch address input height in Send.js
Fri, Nov 25, 16:37

Thu, Nov 24

kieran709 requested review of D12609: [Cashtab] Patch address input height in Send.js.
Thu, Nov 24, 16:43
kieran709 abandoned D12603: [Cashtab] Test diff.
Thu, Nov 24, 03:54
kieran709 requested review of D12603: [Cashtab] Test diff.
Thu, Nov 24, 03:53

Tue, Nov 22

kieran709 abandoned D11941: [xec-web-components] Create XEC components library with an address converter.
Tue, Nov 22, 15:06
kieran709 accepted D12497: [Cashtab] Deprecate address validator artifact.
Tue, Nov 22, 15:05

Mon, Nov 21

kieran709 closed D12525: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message.
Mon, Nov 21, 19:02
kieran709 closed D12536: [Cashtab][Move Msg Switch pt3] Add transition effect to address inputs.
Mon, Nov 21, 19:02
kieran709 committed rABC2e37ce4c73a1: [Cashtab][Move Msg Switch pt3] Add transition effect to address inputs (authored by kieran709).
[Cashtab][Move Msg Switch pt3] Add transition effect to address inputs
Mon, Nov 21, 19:02
kieran709 committed rABCff0cf3abed48: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message (authored by kieran709).
[Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message
Mon, Nov 21, 19:02
kieran709 closed D12520: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.
Mon, Nov 21, 19:02
kieran709 committed rABCf00dba6af1d9: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced… (authored by kieran709).
[Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced…
Mon, Nov 21, 19:02
kieran709 closed D12534: [Cashtab] Improve Sign and Verify collapse labels.
Mon, Nov 21, 17:06
kieran709 committed rABCe8118bec1965: [Cashtab] Improve Sign and Verify collapse labels (authored by kieran709).
[Cashtab] Improve Sign and Verify collapse labels
Mon, Nov 21, 17:06
kieran709 accepted D12547: [Cashtab] [Extension] [Code cleanup p5 retry] Update comments and function name for triggerApprovalModal.
Mon, Nov 21, 17:03
kieran709 accepted D12546: [Cashtab] [Extension] [Code cleanup p4 retry] Update comments and function name for triggerUi.
Mon, Nov 21, 16:51
kieran709 accepted D12545: [Cashtab] [Extension] [Code cleanup p3 retry] Remove commented out testing code from background.js.
Mon, Nov 21, 16:47
kieran709 accepted D12544: [Cashtab] [Extension] [Code cleanup p2 retry] Remove unused window variable from background.js.
Mon, Nov 21, 16:46
kieran709 accepted D12543: [Cashtab] [Extension] [Code cleanup p1 retry] Remove unused variables from background.js.
Mon, Nov 21, 16:24
kieran709 closed D12473: [Cashtab] Visual navigation aid added for hamburger menu options.
Mon, Nov 21, 16:05
kieran709 committed rABC7a47dd3f8685: [Cashtab] Visual navigation aid added for hamburger menu options (authored by kieran709).
[Cashtab] Visual navigation aid added for hamburger menu options
Mon, Nov 21, 16:05

Fri, Nov 18

kieran709 requested review of D12536: [Cashtab][Move Msg Switch pt3] Add transition effect to address inputs.
Fri, Nov 18, 17:54
kieran709 requested review of D12534: [Cashtab] Improve Sign and Verify collapse labels.
Fri, Nov 18, 16:21

Thu, Nov 17

kieran709 requested review of D12525: [Cashtab][Move msg switch p2] Advanced collapse in Send.js re-titled to Message.
Thu, Nov 17, 20:16
kieran709 retitled D12520: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen from [Cashtab][Pt1] Move multi recipients switch out of the Advanvced Collapse on Send Screen to [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.
Thu, Nov 17, 19:45
kieran709 updated the diff for D12520: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.

Responding to review feedback, content jumping has been addressed. Instead of conditionally rendering the single and multi address inputs, they have been placed in a div with a fixed min-height. Oon click the max-height of the single / multi address input is reduced to 0.

Thu, Nov 17, 17:27
kieran709 retitled D12520: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen from [Cashtab] Move multi recipients switch out of the Advanvced Collapse on Send Screen to [Cashtab][Pt1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.
Thu, Nov 17, 17:07
kieran709 closed D12519: [Cashtab] Add support for Nigerian Naira.
Thu, Nov 17, 15:57
kieran709 committed rABC8e9881c81988: [Cashtab] Add support for Nigerian Naira (authored by kieran709).
[Cashtab] Add support for Nigerian Naira
Thu, Nov 17, 15:57
kieran709 updated the diff for D12473: [Cashtab] Visual navigation aid added for hamburger menu options.

Responding to review feedback

Thu, Nov 17, 15:55

Wed, Nov 16

kieran709 requested review of D12520: [Cashtab][Move msg switch p1] Move multi recipients switch out of the Advanvced Collapse on Send Screen.
Wed, Nov 16, 19:25
kieran709 requested review of D12519: [Cashtab] Add support for Nigerian Naira.
Wed, Nov 16, 18:19
kieran709 updated the diff for D12473: [Cashtab] Visual navigation aid added for hamburger menu options.

After some consideration, the visual navigation aid has been moved below the Cashtab logo.

Wed, Nov 16, 17:50
kieran709 updated the diff for D12473: [Cashtab] Visual navigation aid added for hamburger menu options.

Responding to review feedback. Navigation aid has been added above the Cashtab logo, and the active NavItem is highlighted.

Wed, Nov 16, 17:46
kieran709 accepted D12500: [Cashtab] Improve extension build script error handling.
Wed, Nov 16, 15:23

Tue, Nov 15

kieran709 accepted D12502: [Cashtab] [Extension] [Code cleanup p2] Remove unused window variable from background.js.
Tue, Nov 15, 15:59
kieran709 accepted D12501: [Cashtab] [Extension] [Code cleanup p1] Remove unused variables from background.js.
Tue, Nov 15, 15:30

Thu, Nov 10

kieran709 requested review of D12473: [Cashtab] Visual navigation aid added for hamburger menu options.
Thu, Nov 10, 18:03

Tue, Nov 8

kieran709 closed D12439: [Cashtab] Patched vertical alignment of NavItems in hamburger menu.
Tue, Nov 8, 23:00
kieran709 committed rABCf905533957e2: [Cashtab] Patched vertical alignment of NavItems in hamburger menu (authored by kieran709).
[Cashtab] Patched vertical alignment of NavItems in hamburger menu
Tue, Nov 8, 23:00
kieran709 requested review of D12439: [Cashtab] Patched vertical alignment of NavItems in hamburger menu.
Tue, Nov 8, 22:41
kieran709 closed D12431: [Cashtab][Pt 4/4] Move message signing and verification to new screen - Create snapshot test.
Tue, Nov 8, 17:26
kieran709 committed rABCa281a7f3184b: [Cashtab][Pt 4/4] Move message signing and verification to new screen - Create… (authored by kieran709).
[Cashtab][Pt 4/4] Move message signing and verification to new screen - Create…
Tue, Nov 8, 17:26
kieran709 closed D12430: [Cashtab][Pt 3/4] Move message signing and verification to new screen - create new SignVerifyMsg component.
Tue, Nov 8, 17:26
kieran709 closed D12428: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove Verification & Signing from Send.js.
Tue, Nov 8, 17:26
kieran709 committed rABC3eae42cbf944: [Cashtab][Pt 3/4] Move message signing and verification to new screen - create… (authored by kieran709).
[Cashtab][Pt 3/4] Move message signing and verification to new screen - create…
Tue, Nov 8, 17:26
kieran709 committed rABC0d347bd988d3: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove… (authored by kieran709).
[Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove…
Tue, Nov 8, 17:26
kieran709 closed D12426: [Cashtab][Pt 1/4] Move message signing and verification to new screen - Create icon & NavItem.
Tue, Nov 8, 17:26
kieran709 committed rABC97fb4118b0a6: [Cashtab][Pt 1/4] Move message signing and verification to new screen - Create… (authored by kieran709).
[Cashtab][Pt 1/4] Move message signing and verification to new screen - Create…
Tue, Nov 8, 17:26

Mon, Nov 7

kieran709 requested review of D12431: [Cashtab][Pt 4/4] Move message signing and verification to new screen - Create snapshot test.
Mon, Nov 7, 18:32
kieran709 requested review of D12430: [Cashtab][Pt 3/4] Move message signing and verification to new screen - create new SignVerifyMsg component.
Mon, Nov 7, 18:24
kieran709 updated the diff for D12426: [Cashtab][Pt 1/4] Move message signing and verification to new screen - Create icon & NavItem.

Updated styling and added the same changes to extension.

Mon, Nov 7, 17:58
kieran709 requested review of D12428: [Cashtab][Pt 2/4] Move message signing and verification to new screen - Remove Verification & Signing from Send.js.
Mon, Nov 7, 17:44
kieran709 requested review of D12426: [Cashtab][Pt 1/4] Move message signing and verification to new screen - Create icon & NavItem.
Mon, Nov 7, 17:18
kieran709 abandoned D12417: [Cashtab] Move message signing and verification to new screen.

To keep it clean I am going to abandon this diff and begin the process of pushing it up stacked as mentioned in the review.

Mon, Nov 7, 15:55
kieran709 closed D12392: [Cashtab] Token balance should show full decimals.
Mon, Nov 7, 15:06
kieran709 committed rABCe23741199731: [Cashtab] Token balance should show full decimals (authored by kieran709).
[Cashtab] Token balance should show full decimals
Mon, Nov 7, 15:06

Fri, Nov 4

kieran709 updated the diff for D12417: [Cashtab] Move message signing and verification to new screen.

Updated extension

Fri, Nov 4, 16:45
kieran709 requested review of D12417: [Cashtab] Move message signing and verification to new screen.
Fri, Nov 4, 16:34

Thu, Nov 3

kieran709 closed D12409: [Cashtab] Disabled scroll wheel within input fields.
Thu, Nov 3, 14:20
kieran709 committed rABC7a3969b8bf62: [Cashtab] Disabled scroll wheel within input fields (authored by kieran709).
[Cashtab] Disabled scroll wheel within input fields
Thu, Nov 3, 14:20

Wed, Nov 2

kieran709 updated the diff for D12392: [Cashtab] Token balance should show full decimals.

Responding to review feedback, optionalLocale is now defaultLocale, and is defined as 'en', if navigator.language is available, locale is set by the browser.

Wed, Nov 2, 14:51
kieran709 closed D12410: [Cashtab] Remove all unused imports in chronik.test.js.
Wed, Nov 2, 14:32
kieran709 committed rABCc7aefa86d285: [Cashtab] Remove all unused imports in chronik.test.js (authored by kieran709).
[Cashtab] Remove all unused imports in chronik.test.js
Wed, Nov 2, 14:32

Tue, Nov 1

kieran709 updated the diff for D12410: [Cashtab] Remove all unused imports in chronik.test.js.

Responding to review feedback, removed unused currency import in chronik.test.js and updated diff details to reflect this change.

Tue, Nov 1, 20:56
kieran709 retitled D12410: [Cashtab] Remove all unused imports in chronik.test.js from [Cashtab] Remove unused BigNumber import chronik.test.js to [Cashtab] Remove all unused imports in chronik.test.js.
Tue, Nov 1, 20:55
kieran709 updated the diff for D12409: [Cashtab] Disabled scroll wheel within input fields.

Responding to review feedback, removed onWheel from inputProps in SendToken.js which was left in by mistake in last push, added comments to explain why target.blur() is used in this case instead of event.preventDefault().

Tue, Nov 1, 20:53
kieran709 updated the diff for D12392: [Cashtab] Token balance should show full decimals.

Responding to review feedback. Because toLocaleString does not work on a string, the initial unformattedTokenBalance must be converted back to a number in order to be formatted as a localeString. As far as I can tell, using new BigNumber(unformattedTokenBalance).toLocalteString(optionalLocale, {minimumFractionDigits: tokenBalance}) has no effect which was the catalyst for the creation of this new function originally. The workaround is, as stated, do the initial conversion of unformattedTokenBalance to a BigNumber, get the appropriate amount of decimal places with toFixed(tokenDecimal), and in the next step, convert that string into a number which maintains the decimals from the previous step, and finally setting that to localeString with the minimumFractionDigits option set to tokenDecimal. I tried to find a more elegant way to do this, but this has been my best attempt today. Additionally, with consideration to the new optionalLocale parameter, checks have been added along with fallback values in case the optionalLocale is not provided to the function.

Tue, Nov 1, 20:44
kieran709 requested review of D12410: [Cashtab] Remove all unused imports in chronik.test.js.
Tue, Nov 1, 17:07
kieran709 closed D12408: [Cashtab] Removed isGenesisTx console.log from chronik.js.
Tue, Nov 1, 16:53
kieran709 committed rABC715f40ca8348: [Cashtab] Removed isGenesisTx console.log from chronik.js (authored by kieran709).
[Cashtab] Removed isGenesisTx console.log from chronik.js
Tue, Nov 1, 16:53
kieran709 updated the diff for D12409: [Cashtab] Disabled scroll wheel within input fields.

Responding to review feedback.

Tue, Nov 1, 16:49