Page MenuHomePhabricator

kyuupichan (Neil)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 8 2017, 23:06 (118 w, 6 d)

Recent Activity

Jul 16 2018

kyuupichan accepted D1569: Refactor IsCompressedOrUncompressedPubKey.
Jul 16 2018, 11:35
kyuupichan requested changes to D1569: Refactor IsCompressedOrUncompressedPubKey.
Jul 16 2018, 00:09

Apr 5 2018

kyuupichan committed rABC427bef944508: [macOS] remove Growl support, remove unused code (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[macOS] remove Growl support, remove unused code
Apr 5 2018, 05:23
kyuupichan closed D1243: [macOS] remove Growl support, remove unused code.
Apr 5 2018, 05:22
Herald added a reviewer for D1243: [macOS] remove Growl support, remove unused code: Restricted Project.
Apr 5 2018, 04:42

Feb 25 2018

kyuupichan added inline comments to D1133: Accept network messages for 32MB blocks and larger..
Feb 25 2018, 14:30

Feb 15 2018

kyuupichan added a comment to D1094: unit test for OP_DIV.

In C++ there is a corner-case where the maximal negative integer, divided by -1, overflows. Is there something similar in script?

Feb 15 2018, 01:35

Dec 7 2017

kyuupichan added a comment to D755: Start differenciating txid and txhash.

I agree it seems premature. I'm not convinced it is solving a problem anyone has; should be low priority IMO until it's shown to be a) not useful in itself, and b) blocking other useful stuff people actually are asking to do. I've seen no evidence of either.

Dec 7 2017, 13:34

Nov 5 2017

kyuupichan accepted D635: Comment, cast and assert cleanup in pow.cpp.

Looks good to me.

Nov 5 2017, 03:10

Oct 22 2017

kyuupichan added inline comments to D622: Implement weighted-time difficulty adjustment algorithm.
Oct 22 2017, 22:14
kyuupichan added inline comments to D622: Implement weighted-time difficulty adjustment algorithm.
Oct 22 2017, 22:11
kyuupichan requested changes to D622: Implement weighted-time difficulty adjustment algorithm.
Oct 22 2017, 21:51

Oct 18 2017

kyuupichan accepted D611: Remove IsUAHFenableForCurrentBlock.

Seems harmless

Oct 18 2017, 13:51

Oct 17 2017

kyuupichan added inline comments to D601: Implement simple moving average over work difficulty adjustement algorithm..
Oct 17 2017, 02:46

Oct 7 2017

kyuupichan added inline comments to D571: Implement the proposed difficulty adjustement algorithm proposed in the ML.
Oct 7 2017, 05:32

Oct 6 2017

kyuupichan updated the diff for D578: Proposed new algo for BCC difficulty adjustments.

Squashed / rebased.

Oct 6 2017, 00:19

Oct 5 2017

kyuupichan committed rABCe9bc0d3f5981: Fix seeder compilation warnings (authored by kyuupichan).
Fix seeder compilation warnings
Oct 5 2017, 22:29
kyuupichan closed D585: Fix seeder compilation warnings by committing rABCe9bc0d3f5981: Fix seeder compilation warnings.
Oct 5 2017, 22:29
Herald added 1 blocking reviewer(s) for D585: Fix seeder compilation warnings: Restricted Project.
Oct 5 2017, 14:01
kyuupichan committed rABC26bef497950b: Port of bitcoin/#10958 - leveldb patches (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Port of bitcoin/#10958 - leveldb patches
Oct 5 2017, 13:11
kyuupichan closed D584: Port of bitcoin/#10958 - leveldb patches by committing rABC26bef497950b: Port of bitcoin/#10958 - leveldb patches (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Oct 5 2017, 13:11
Herald added 1 blocking reviewer(s) for D584: Port of bitcoin/#10958 - leveldb patches: Restricted Project.
Oct 5 2017, 08:33
kyuupichan updated the diff for D578: Proposed new algo for BCC difficulty adjustments.

Fix typos.

Oct 5 2017, 07:56
kyuupichan updated the diff for D578: Proposed new algo for BCC difficulty adjustments.

Raise difficulty if blocks are too fast over a 2016 block period

Oct 5 2017, 04:08
kyuupichan added a comment to D578: Proposed new algo for BCC difficulty adjustments.

When considering the DARI, it seems like this algorithm encourages oscillations in hashpower. Can you link to your simulations?

Oct 5 2017, 01:41
kyuupichan committed rABC69311e16a624: Update to LevelDB 1.20 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Update to LevelDB 1.20
Oct 5 2017, 01:22
kyuupichan closed D580: Update to LevelDB 1.20 Port of bitcoin core #10544. by committing rABC69311e16a624: Update to LevelDB 1.20 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Oct 5 2017, 01:22

Oct 4 2017

Herald added 1 blocking reviewer(s) for D580: Update to LevelDB 1.20 Port of bitcoin core #10544.: Restricted Project.
Oct 4 2017, 13:59
kyuupichan accepted D579: Update seeder to use int64_t instead of time_t for Darwin.

Builds and makes check for me.

Oct 4 2017, 06:37
kyuupichan added inline comments to D579: Update seeder to use int64_t instead of time_t for Darwin.
Oct 4 2017, 05:39

Oct 1 2017

Herald added 1 blocking reviewer(s) for D578: Proposed new algo for BCC difficulty adjustments: Restricted Project.
Oct 1 2017, 09:16
kyuupichan requested changes to D571: Implement the proposed difficulty adjustement algorithm proposed in the ML.

Just some minor typos

Oct 1 2017, 03:22

Sep 25 2017

kyuupichan committed rABC0d6c1360cd6b: Include MacOS headers in global namespace (authored by kyuupichan).
Include MacOS headers in global namespace
Sep 25 2017, 12:56
kyuupichan closed D556: Include MacOS headers in global namespace by committing rABC0d6c1360cd6b: Include MacOS headers in global namespace.
Sep 25 2017, 12:56
Herald added 1 blocking reviewer(s) for D556: Include MacOS headers in global namespace: Restricted Project.
Sep 25 2017, 08:10

Jul 26 2017

kyuupichan added a comment to D379: Be nice to peer that relay non replay protected transactions..

Agree an explanatory comment for the reason for the 2 checks is warranted. It's not obvious.

Jul 26 2017, 12:30
kyuupichan accepted D379: Be nice to peer that relay non replay protected transactions..
Jul 26 2017, 12:29

Jul 24 2017

kyuupichan accepted D371: Reject non replay protected transactions after the fork..

Looks good to me.

Jul 24 2017, 12:31

Jul 21 2017

kyuupichan committed rABC975051f9df46: Set testnet anti-replay sunset to be in the future (authored by kyuupichan).
Set testnet anti-replay sunset to be in the future
Jul 21 2017, 08:01
kyuupichan closed D357: Set testnet anti-replay sunset to be in the future by committing rABC975051f9df46: Set testnet anti-replay sunset to be in the future.
Jul 21 2017, 08:01
kyuupichan accepted D356: Bump version for 0.14.5 release.
Jul 21 2017, 06:21
Herald added a reviewer for D357: Set testnet anti-replay sunset to be in the future: Restricted Project.
Jul 21 2017, 06:18

Jul 19 2017

kyuupichan accepted D340: Some formatting in coins.cpp.
Jul 19 2017, 04:50
kyuupichan committed rABCbfdc41751e50: Remove obsolete dead code. (authored by kyuupichan).
Remove obsolete dead code.
Jul 19 2017, 04:49
kyuupichan closed D333: Remove obsolete dead code. by committing rABCbfdc41751e50: Remove obsolete dead code..
Jul 19 2017, 04:49

Jul 15 2017

Herald added a reviewer for D333: Remove obsolete dead code.: Restricted Project.
Jul 15 2017, 09:17
kyuupichan accepted D329: Use modern c style imports.
Jul 15 2017, 04:26
kyuupichan requested changes to D330: Lint C files..
Jul 15 2017, 04:23

Jul 6 2017

kyuupichan accepted D298: Add a difficulty adjustement mechanism in case of abrupt hashrate loss.
Jul 6 2017, 13:53
kyuupichan accepted D297: Make a copy of PrecomputedTransactionData in the CScriptCheck.

Looks good to me but I'n not an expert in this part of the codebase.

Jul 6 2017, 12:19
kyuupichan requested changes to D298: Add a difficulty adjustement mechanism in case of abrupt hashrate loss.
Jul 6 2017, 08:35

Jun 23 2017

kyuupichan accepted D274: Format validationinterface.{h,cpp}.
Jun 23 2017, 23:00
kyuupichan accepted D275: Format indirectmap.h and limitedmap.h.
Jun 23 2017, 22:59

Jun 20 2017

kyuupichan accepted D240: Make sure the maximum block size is greater than 1MB.
Jun 20 2017, 23:22