Page MenuHomePhabricator

sken (sken)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2018, 05:51 (105 w, 2 d)

Recent Activity

Sat, Mar 21

sken added a comment to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

It doesn't replace finalize, but its the recommended way of handling resources. IMO, anyone with java experience would understand this, and treat this class as such. we can make it clear on the release notes and the comment

Sat, Mar 21, 02:32
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

requested changes

Sat, Mar 21, 02:30

Fri, Mar 20

sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Forgot to add this last minute change

Fri, Mar 20, 22:54
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

make requested changes and implement Autocloseable into the class

Fri, Mar 20, 22:52
sken added inline comments to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Fri, Mar 20, 22:51

Thu, Mar 19

sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Make requested changes

Thu, Mar 19, 19:36
sken added a comment to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

I responded to some of those comments and made the requested changes regardless. we can roll some of them back. as for isEnabled name im open to suggestions, i cant think of something more concise ;). Also, i added isValid to indicate the instance has a valid context. as you said, users dont need to know what context is, only if it works or it doesnt

Thu, Mar 19, 19:33
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

clean all resources in test

Thu, Mar 19, 03:26
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

make requested changes and add proposed ones

Thu, Mar 19, 02:30
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

make requested changes and add proposed ones

Thu, Mar 19, 02:05
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

rolling back diff (hopefully)

Thu, Mar 19, 01:40
sken added a comment to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

arc diff just did somethign strange to that py file. is there a way to revert that?

Thu, Mar 19, 01:28
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

make requested changes and also add the proposed ones

Thu, Mar 19, 01:25
sken added a comment to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

the context is set to -1 at "cleanup" (line 200~) when the context in the native lib is destroyed. We can set it up to -1 before assigning it at the constructor call. that way we can handle the case where the exception thrown at construction is caught for some dumb reason. Perhaps we should also check if the context is not -1 before every lib call. Theres also fixing cloneContext, which IMO should result in returning a new NativeSecp256k1 class with the cloned native lib context in, but i was hoping to fix that on another ticket

Thu, Mar 19, 01:02

Wed, Mar 18

sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Remove Secp256k1Context and move the loading to NativeSecp256k1

Wed, Mar 18, 06:28
sken added inline comments to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Wed, Mar 18, 06:14
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Roll back formating changes

Wed, Mar 18, 06:07

Tue, Mar 17

sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

checking if library is enabled, otherwise throw exception

Tue, Mar 17, 21:00
sken added inline comments to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Tue, Mar 17, 16:54
sken added a comment to D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

The getContext used to have the benefit of checking that the context is properly initialized. Now there is no such check, so if cleanup is called, then something else is, you'll get an horrible crash instead. I do not think this is somethign java devs expect.

Tue, Mar 17, 16:40
sken updated the summary of D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Tue, Mar 17, 06:22
sken updated the summary of D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Tue, Mar 17, 03:30
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

Fix spacing issue

Tue, Mar 17, 03:26
sken updated the diff for D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.

fixing typo

Tue, Mar 17, 03:22
sken created D5490: [SECP256K1] turn NativeSecp256k1 class into a regular class.
Tue, Mar 17, 03:18