use auto

Rebase on patches that address feedback

Cleanup ctime include

Use duration literals where possible.

Fix port boundary at 65535

Add unit tests for integer args bounds

Use constants in tests

Make argsManager a pointer to gArgs

Renamed dnsseed -> bitcoin-seeder. There were two other places in the README that also have not been updated.

Refactor gArgs out of CDnsSeedOpts and pass in ArgsManager for finer control while testing

In D10828#242951, @Fabien wrote:

What do you think of passing an ArgsManager to the CDnsSeedOpts instead ? So in main you can pass gArgs, and in tests whatever local dummy ArgsManager you want. This makes it possible to keep the method as is with the added benefit of making it simple to test by removing the dependency to the global variable gArgs.

• Rename files so opts -> options
• Fix #include nits

In D10748#241247, @Fabien wrote:

This deserves a unit test.
You can just call ParseCommandLine() with various values to check the behavior.

Also the port number can have an upper bound as well.

• Add a dump soon after startup (up to 10 sec)
• Assert thread data pointer
• Add bounds checking
• Use std::chrono

In D10390#233504, @deadalnix wrote:

Please send a link to the PR itself so we can see the discussion and associated code.

In D10366#233344, @Fabien wrote:

When a seed node address is fetched from other seeders

AFAIK these seeds are pulled from a hardcoded list and not fetched from the network. Are you referring to something else ?

• Added comment about IPv6 transformation
• Use constant for args help text