Page MenuHomePhabricator

tobias_ruck (Tobias Ruck)
User

Projects

User does not belong to any projects.

User Details

User Since
Tue, Jan 7, 15:08 (3 w, 1 d)

Recent Activity

Tue, Jan 21

tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Tue, Jan 21, 15:19
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Updated comments

Tue, Jan 21, 14:53
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE. to Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Tue, Jan 21, 14:47
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Removed empty line in interpreter.cpp. Fused loops in op_reversebytes_test.cpp and other refactorings, expanded palindromes test vector.

Tue, Jan 21, 14:42

Sat, Jan 18

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Fixed the, and I quote, quibble, which has been pointed out by @markblundeberg

Sat, Jan 18, 19:07

Tue, Jan 14

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

That fixed it. Thanks Mark!

Tue, Jan 14, 21:12
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Rebased onto the changes from master.

Tue, Jan 14, 20:39
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Build Bitcoin-ABC / Diffs / Diff Testing failed. Snippet of first build failure: ` [17:32:02]W: [Step 1/1] + case "$ABC_BUILD_NAME" in [17:32:02] : [Step 1/1] Error: Invalid build name 'build-diff' [17:32:02]W: [Step 1/1] + echo 'Error: Invalid build name '\''build-diff'\''' [17:32:02]W: [Step 1/1] + exit 2 [17:32:02]W: [Step 1/1] Process exited with code 2 [17:32:02]E: [Step 1/1] Process exited with code 2 (Step: Command Line) `

This seems like a configuration error. Does someone know what‘s going on there?

Tue, Jan 14, 19:43
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Tue, Jan 14, 17:33
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed opcode to OP_REVERSEBYTES (which is the final name now), refactored & amended tests.

Tue, Jan 14, 17:31
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Tue, Jan 14, 16:16

Sat, Jan 11

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:
In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.
Also added tests for unexecuted branches, clarified tests for not yet activated case.
Merged D4859 into this diff.

I'm not a fan of the new name... "Endian" to me seems hardware specific, and usually implies some power-of-2 number of bytes.... If you're worried about confusion, using the word "Endian" to me seems more confusing. It's possible people may use for things other than endian conversion, since it can reverse the byte order for any arbitrary-length string.
How about "OP_REVERSE_BYTES", or "OP_BYTE_SWAP"?
In any case, I guess this is a bit bike-sheddy, so not super-important either way.

Sat, Jan 11, 22:40

Fri, Jan 10

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Collapsed reversed_data generation code.

Fri, Jan 10, 01:01
tobias_ruck abandoned D4859: Added OP_BSWAP opcode without tests or behavior..

Accidentially updated wrong diff....

Fri, Jan 10, 01:00
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Collapsed reversed_data generation code.

Fri, Jan 10, 00:57

Thu, Jan 9

tobias_ruck updated the summary of D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Thu, Jan 9, 16:46
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Implemented OP_BSWAP logic, added (always disabled) activation flag, added tests for OP_BSWAP. to Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..
Thu, Jan 9, 16:45
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

Thu, Jan 9, 16:41
tobias_ruck abandoned D4859: Added OP_BSWAP opcode without tests or behavior..

will be merged with D4871

Thu, Jan 9, 16:16
tobias_ruck abandoned D4864: Fixed OP_BSWAP opcode number in script.py..

moved to D4871

Thu, Jan 9, 16:15
tobias_ruck closed D4862: Added guide for OSX users on how to install clang-format-8..
Thu, Jan 9, 11:29
tobias_ruck committed rABC55577b249220: Added guide for OSX users on how to install clang-format-8. (authored by tobias_ruck).
Added guide for OSX users on how to install clang-format-8.
Thu, Jan 9, 11:29
tobias_ruck updated the summary of D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Thu, Jan 9, 09:27
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Coordinated SCRIPT_ENABLE_OP_BSWAP script flag bit with @markblundeberg

Thu, Jan 9, 00:29
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed bswap_opcode_tests.cpp to op_bswap_tests.cpp

Thu, Jan 9, 00:26
tobias_ruck updated the test plan for D4862: Added guide for OSX users on how to install clang-format-8..
Thu, Jan 9, 00:11
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Squashed commits into one (commit amend failed previously)

Thu, Jan 9, 00:07

Wed, Jan 8

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg

Wed, Jan 8, 22:41
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Implemented OP_BSWAP logic, added (always disabled) activation flag, moved previous bswap_tests.cpp to byteswap_tests.cpp, added tests for OP_BSWAP. to Implemented OP_BSWAP logic, added (always disabled) activation flag, added tests for OP_BSWAP..
Wed, Jan 8, 22:36
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Applied review by @deadalnix. T707

Wed, Jan 8, 22:35
tobias_ruck updated the test plan for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Wed, Jan 8, 19:20
tobias_ruck created D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Wed, Jan 8, 19:19
tobias_ruck updated the summary of D4859: Added OP_BSWAP opcode without tests or behavior..
Wed, Jan 8, 19:04
tobias_ruck triaged T707: OP_BSWAP as Normal priority.
Wed, Jan 8, 19:03 · Restricted Project
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Added OP_BSWAP opcode without tests or behavior.

Wed, Jan 8, 17:09
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Fixed OP_BSWAP opcode number in script.py

Wed, Jan 8, 17:02
tobias_ruck created D4864: Fixed OP_BSWAP opcode number in script.py..
Wed, Jan 8, 15:41
tobias_ruck created D4862: Added guide for OSX users on how to install clang-format-8..
Wed, Jan 8, 15:35
tobias_ruck created D4859: Added OP_BSWAP opcode without tests or behavior..
Wed, Jan 8, 15:26