Page MenuHomePhabricator

tobias_ruck (Tobias Ruck)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 15:08 (129 w, 2 d)

Recent Activity

Wed, Jun 29

tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Return $messages instead of array() when rustfmt made no changes to the code

Wed, Jun 29, 23:40
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Fix comments in .rustfmt.toml, don't group rules but sort by alphabet. Use rustfmt +abc-nightly in the linter.

Wed, Jun 29, 23:37
tobias_ruck requested review of D11688: [Chronik] Install nightly rust toolchain dependency (as "abc-nightly").
Wed, Jun 29, 23:20
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Use nightly rustfmt, which simplifies the linter substantially

Wed, Jun 29, 15:55
tobias_ruck accepted D11687: [linter] Fix a outdated comment on clang format version.
Wed, Jun 29, 15:33
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:15
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:14
tobias_ruck updated the summary of D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.
Wed, Jun 29, 11:14
tobias_ruck updated the diff for D11671: [Chronik] Add `rustfmt` linter, to style check Rust files.

Use cargo fmt -- --check to lint files, which outputs a diff, and process that.

Wed, Jun 29, 11:12

Mon, Jun 27

tobias_ruck published D11671: [Chronik] Add `rustfmt` linter, to style check Rust files for review.
Mon, Jun 27, 17:54
tobias_ruck closed D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
Mon, Jun 27, 12:43
tobias_ruck committed rABC5615fb72f897: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it (authored by tobias_ruck).
[Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it
Mon, Jun 27, 12:43
tobias_ruck updated the diff for D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.

something bizzare happened with my git, adding missing files

Mon, Jun 27, 12:31
tobias_ruck updated the diff for D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
  • Removed ALGO_NAME associated const
  • Added copyright
  • Fixed + tested Debug impl
Mon, Jun 27, 10:19
tobias_ruck updated the diff for D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
  • Check for minimum Rust version
  • Simplify CMake following Fabiens diff
Mon, Jun 27, 09:45

Sat, Jun 25

tobias_ruck updated the summary of D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
Sat, Jun 25, 21:16
tobias_ruck updated the diff for D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.

Resolve issues raised:

Sat, Jun 25, 21:15
tobias_ruck updated subscribers of D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.

There are several copyright headers missing.

Sat, Jun 25, 17:24
tobias_ruck retitled D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it from Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it to [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
Sat, Jun 25, 16:10
tobias_ruck updated the test plan for D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
Sat, Jun 25, 12:10

Fri, Jun 24

tobias_ruck requested review of D11668: [Chronik] Add minimal bitcoinsuite-core Rust crate + CMake to `cargo test` it.
Fri, Jun 24, 21:00
tobias_ruck closed D11663: Install dependencies for Chronik: Rust and Corrosion.
Fri, Jun 24, 13:50
tobias_ruck committed rABC0a3e7327bde7: Install dependencies for Chronik: Rust and Corrosion (authored by tobias_ruck).
Install dependencies for Chronik: Rust and Corrosion
Fri, Jun 24, 13:50
tobias_ruck updated the test plan for D11663: Install dependencies for Chronik: Rust and Corrosion.
Fri, Jun 24, 13:44
tobias_ruck updated the diff for D11663: Install dependencies for Chronik: Rust and Corrosion.

tar xzf (mandatory xkcd https://xkcd.com/1168/)

Fri, Jun 24, 13:42
tobias_ruck updated the test plan for D11663: Install dependencies for Chronik: Rust and Corrosion.
Fri, Jun 24, 13:34
tobias_ruck updated the diff for D11663: Install dependencies for Chronik: Rust and Corrosion.

Install specific Rust version via rustup

Fri, Jun 24, 13:13

Thu, Jun 23

tobias_ruck requested review of D11663: Install dependencies for Chronik: Rust and Corrosion.
Thu, Jun 23, 21:47

May 16 2022

tobias_ruck added a comment to D11385: [Cashtab] Commence implementation of chronik.

In this case, it can be handled client-side. A library can provide a wrapper around chronik-client to accept addresses.

May 16 2022, 18:10
tobias_ruck added a comment to D11385: [Cashtab] Commence implementation of chronik.

hash160 instead of addresses -- this complication should be handled server side, not app side. chronik should accept ecash addresses.

May 16 2022, 17:55

Sep 24 2021

tobias_ruck closed D10198: Fix incorrect comment in intmath_tests.cpp.
Sep 24 2021, 19:40
tobias_ruck committed rABCc9532822d419: Fix incorrect comment in intmath_tests.cpp (authored by tobias_ruck).
Fix incorrect comment in intmath_tests.cpp
Sep 24 2021, 19:40
tobias_ruck requested review of D10198: Fix incorrect comment in intmath_tests.cpp.
Sep 24 2021, 18:46

Sep 23 2021

tobias_ruck closed D9928: Add AddInt63Overflow and SubInt63Overflow.
Sep 23 2021, 15:56
tobias_ruck committed rABCd91e8262c060: Add AddInt63Overflow and SubInt63Overflow (authored by tobias_ruck).
Add AddInt63Overflow and SubInt63Overflow
Sep 23 2021, 15:56
tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Add CheckArithmeticResult to intmat_tests for less copy-pasta

Sep 23 2021, 02:40

Sep 16 2021

tobias_ruck closed D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.
Sep 16 2021, 16:29
tobias_ruck committed rABCe3c96f8ddab2: Fix spelling of "unreachable" in OP_CHECKMULTISIG (authored by tobias_ruck).
Fix spelling of "unreachable" in OP_CHECKMULTISIG
Sep 16 2021, 16:29
tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Verify [Add|Sub]Int63OverflowEmulated and [Add|Sub]Int63Overflow overflow for the same operands and produce the same result for for non-overflowing operands.

Sep 16 2021, 07:16
tobias_ruck updated the diff for D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.

Actually fix the typo in "unreachable" in OP_CHECKMULTISIG

Sep 16 2021, 06:59

Sep 15 2021

tobias_ruck requested review of D10126: Fix spelling of "unreachable" in OP_CHECKMULTISIG.
Sep 15 2021, 23:05
tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Add comment for the int64_t == long long int assertion.

Sep 15 2021, 16:28

Sep 14 2021

tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Update detection of built-ins.

Sep 14 2021, 19:04

Aug 25 2021

tobias_ruck updated the diff for D9928: Add AddInt63Overflow and SubInt63Overflow.

Fix spelling of available.

Aug 25 2021, 04:47
tobias_ruck requested review of D9928: Add AddInt63Overflow and SubInt63Overflow.
Aug 25 2021, 04:44
tobias_ruck closed D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.
Aug 25 2021, 02:36
tobias_ruck committed rABC31dd07e9b675: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated (authored by tobias_ruck).
Add AddInt63OverflowEmulated and SubInt63OverflowEmulated
Aug 25 2021, 02:36
tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Use loop in GenInt63 instead of recursion

Aug 25 2021, 01:48

Aug 21 2021

tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Re-run tests

Aug 21 2021, 22:35

Aug 19 2021

tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Use assignment operator for bitshift in GenInt63

Aug 19 2021, 08:37

Aug 15 2021

tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Fixed GenInt63 out of bounds case

Aug 15 2021, 07:37

Aug 7 2021

tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Simplified GenInt63 using apparently non-UB

Aug 7 2021, 00:36

Aug 6 2021

tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Improve GenInt63, generates random positive uniform 63-bit number first, then maps to random uniform bit-length and then negates with 50% chance.

Aug 6 2021, 03:52

Aug 5 2021

tobias_ruck retitled D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated from Add AddInt63Emulated and SubInt63Emulated to Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.
Aug 5 2021, 22:11
tobias_ruck updated the diff for D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.

Inlined and removed intmath.cpp and intmath_util.h. Renamed functions in intmath.h. Fixed copyright notice. Simplified conditional code.

Aug 5 2021, 22:08
tobias_ruck abandoned D9843: Add 64-bit overflow check to CScriptNum.

Replaced by D9848

Aug 5 2021, 02:09
tobias_ruck requested review of D9848: Add AddInt63OverflowEmulated and SubInt63OverflowEmulated.
Aug 5 2021, 02:08

Jul 28 2021

tobias_ruck updated the diff for D9843: Add 64-bit overflow check to CScriptNum.

Add multiprecision/cpp_int.hpp Boost dependency (Lord have mercy)

Jul 28 2021, 06:07
tobias_ruck updated the diff for D9843: Add 64-bit overflow check to CScriptNum.

Fix off-by-one error in overflow_add_int64 and overflow_sub_int64 (doesn't seem to appear on Darwin/clang)

Jul 28 2021, 05:55
tobias_ruck requested review of D9843: Add 64-bit overflow check to CScriptNum.
Jul 28 2021, 04:44

Jun 29 2021

tobias_ruck closed D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 29 2021, 00:06
tobias_ruck committed rABC038e6a22db0b: Add -uaclientname and -uaclientversion config options to set the client name… (authored by tobias_ruck).
Add -uaclientname and -uaclientversion config options to set the client name…
Jun 29 2021, 00:06

Jun 28 2021

tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Rebased from master

Jun 28 2021, 14:54
tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Merged FormatUserAgent and FormatSubVersionUserAgent

Jun 28 2021, 14:25

Jun 25 2021

tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Updated commit message

Jun 25 2021, 05:28
tobias_ruck retitled D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message. from Add -uaclient config option to set the client name and version of the user agent in the version message. to Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 25 2021, 05:26

Jun 24 2021

tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Changed to -uaclientname and -uaclientversion as discussed.

Jun 24 2021, 17:45

Jun 7 2021

tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Changed FormatSubVersion to FormatUserAgent and solely use FormatSubVersionUserAgent now

Jun 7 2021, 19:56

Jun 6 2021

tobias_ruck retitled D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message. from Add -useragent config option to explicitly set the User Agent in the version message. to Add -uaclient config option to set the client name and version of the user agent in the version message..
Jun 6 2021, 22:03
tobias_ruck updated the diff for D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

Changed to -uaclient, which sets the client name and version of the user agent, staying compatible with -uacomment

Jun 6 2021, 22:02
tobias_ruck closed D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 17:16
tobias_ruck committed rABC27d01668269f: Add FormatSubVersionUserAgent. (authored by tobias_ruck).
Add FormatSubVersionUserAgent.
Jun 6 2021, 17:16
tobias_ruck requested review of D9637: Add FormatSubVersionUserAgent..
Jun 6 2021, 12:54

Jun 4 2021

tobias_ruck added a comment to D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..

So what should I do instead

Jun 4 2021, 15:12
tobias_ruck requested review of D9628: Add -uaclientname and -uaclientversion config options to set the client name and version of the user agent in the version message..
Jun 4 2021, 02:37

Aug 20 2020

tobias_ruck closed T707: OP_REVERSEBYTES as Resolved.
Aug 20 2020, 08:17 · Restricted Project

May 21 2020

tobias_ruck committed rABCf4413871d32a: decremented EXPECTED_VIOLATION_COUNT (authored by tobias_ruck).
decremented EXPECTED_VIOLATION_COUNT
May 21 2020, 15:17
tobias_ruck closed D6188: decremented EXPECTED_VIOLATION_COUNT.
May 21 2020, 15:16
tobias_ruck requested review of D6188: decremented EXPECTED_VIOLATION_COUNT.
May 21 2020, 08:02

May 20 2020

tobias_ruck committed rSTAGING76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled (authored by tobias_ruck).
Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled
May 20 2020, 21:35
tobias_ruck committed rABC76700c0e5e59: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled (authored by tobias_ruck).
Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled
May 20 2020, 21:34
tobias_ruck closed D6173: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled.
May 20 2020, 21:34
tobias_ruck requested review of D6173: Removed activation logic for OP_REVERSEBYTES to pretend it was always enabled.
May 20 2020, 18:56

May 5 2020

tobias_ruck committed rSTAGINGa546a8d17f10: Speed up OP_REVERSEBYTES test significantly (authored by tobias_ruck).
Speed up OP_REVERSEBYTES test significantly
May 5 2020, 19:02

Apr 18 2020

tobias_ruck committed rABCa546a8d17f10: Speed up OP_REVERSEBYTES test significantly (authored by tobias_ruck).
Speed up OP_REVERSEBYTES test significantly
Apr 18 2020, 08:22
tobias_ruck closed D5729: Speed up OP_REVERSEBYTES test significantly.
Apr 18 2020, 08:22

Apr 17 2020

tobias_ruck updated the diff for D5729: Speed up OP_REVERSEBYTES test significantly.

ok ok i admit this is cleaner now :rolling_eyes:

Apr 17 2020, 19:16

Apr 16 2020

tobias_ruck updated the diff for D5729: Speed up OP_REVERSEBYTES test significantly.

I'm not sure if this is what you want but it does look cleaner now, so maybe.

Apr 16 2020, 14:42
tobias_ruck updated the diff for D5729: Speed up OP_REVERSEBYTES test significantly.

Made the test less functional and more loopy.

Apr 16 2020, 10:10

Apr 15 2020

tobias_ruck updated the diff for D5729: Speed up OP_REVERSEBYTES test significantly.

Refactored test cases

Apr 15 2020, 00:24

Apr 14 2020

tobias_ruck updated the diff for D5729: Speed up OP_REVERSEBYTES test significantly.

Actually use exhaustive test cases in curated flags case

Apr 14 2020, 20:00
tobias_ruck created D5729: Speed up OP_REVERSEBYTES test significantly.
Apr 14 2020, 19:53

Apr 7 2020

tobias_ruck committed rSTAGINGfcf22e8fcc94: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Apr 7 2020, 22:59
tobias_ruck committed rSTAGING9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Apr 7 2020, 22:59
tobias_ruck committed rSTAGING8b77228835ac: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag (authored by tobias_ruck).
Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag
Apr 7 2020, 22:51
tobias_ruck committed rSTAGING55577b249220: Added guide for OSX users on how to install clang-format-8. (authored by tobias_ruck).
Added guide for OSX users on how to install clang-format-8.
Apr 7 2020, 22:20

Feb 18 2020

tobias_ruck updated the test plan for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 18 2020, 18:23

Feb 13 2020

tobias_ruck committed rABC9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Feb 13 2020, 05:34
tobias_ruck closed D5283: OP_REVERSEBYTES activation logic.
Feb 13 2020, 05:34
tobias_ruck created D5283: OP_REVERSEBYTES activation logic.
Feb 13 2020, 03:05