Page MenuHomePhabricator

tobias_ruck (Tobias Ruck)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2020, 15:08 (13 w, 1 d)

Recent Activity

Yesterday

tobias_ruck committed rSTAGINGfcf22e8fcc94: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Tue, Apr 7, 22:59
tobias_ruck committed rSTAGING9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Tue, Apr 7, 22:59
tobias_ruck committed rSTAGING8b77228835ac: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag (authored by tobias_ruck).
Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag
Tue, Apr 7, 22:51
tobias_ruck committed rSTAGING55577b249220: Added guide for OSX users on how to install clang-format-8. (authored by tobias_ruck).
Added guide for OSX users on how to install clang-format-8.
Tue, Apr 7, 22:20

Feb 18 2020

tobias_ruck updated the test plan for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 18 2020, 18:23

Feb 13 2020

tobias_ruck committed rABC9bd868e48eb0: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Feb 13 2020, 05:34
tobias_ruck closed D5283: OP_REVERSEBYTES activation logic.
Feb 13 2020, 05:34
tobias_ruck created D5283: OP_REVERSEBYTES activation logic.
Feb 13 2020, 03:05

Feb 12 2020

tobias_ruck committed rABCfcf22e8fcc94: OP_REVERSEBYTES activation logic (authored by tobias_ruck).
OP_REVERSEBYTES activation logic
Feb 12 2020, 07:11
tobias_ruck closed D5130: OP_REVERSEBYTES activation logic.
Feb 12 2020, 07:11

Feb 9 2020

tobias_ruck updated the diff for D5130: OP_REVERSEBYTES activation logic.

Fixed rebasing

Feb 9 2020, 13:10
tobias_ruck updated the diff for D5130: OP_REVERSEBYTES activation logic.

Resolved scary activation flag duplication; activation logic is now solely in GetNextBlockScriptFlags, as per @markblundeberg‘s refactoring (D5220).

Feb 9 2020, 12:19

Feb 6 2020

tobias_ruck updated the task description for T707: OP_REVERSEBYTES.
Feb 6 2020, 18:52 · Restricted Project
tobias_ruck committed rABC8b77228835ac: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag (authored by tobias_ruck).
Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag
Feb 6 2020, 15:38
tobias_ruck closed D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Feb 6 2020, 15:38

Feb 5 2020

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Moved the comment about FIRST_UNDEFINED_OP_VALUE.

Feb 5 2020, 14:16

Feb 3 2020

tobias_ruck updated the diff for D5130: OP_REVERSEBYTES activation logic.

Resolved lint issues

Feb 3 2020, 14:33

Feb 2 2020

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Rebased onto master

Feb 2 2020, 18:42
tobias_ruck created D5130: OP_REVERSEBYTES activation logic.
Feb 2 2020, 18:19

Jan 21 2020

tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 21 2020, 15:19
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Updated comments

Jan 21 2020, 14:53
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE. to Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 21 2020, 14:47
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Removed empty line in interpreter.cpp. Fused loops in op_reversebytes_test.cpp and other refactorings, expanded palindromes test vector.

Jan 21 2020, 14:42

Jan 18 2020

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Fixed the, and I quote, quibble, which has been pointed out by @markblundeberg

Jan 18 2020, 19:07

Jan 14 2020

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

That fixed it. Thanks Mark!

Jan 14 2020, 21:12
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Rebased onto the changes from master.

Jan 14 2020, 20:39
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Snippet of first build failure:

[17:32:02]W:	 [Step 1/1] + case "$ABC_BUILD_NAME" in
[17:32:02] :	 [Step 1/1] Error: Invalid build name 'build-diff'
[17:32:02]W:	 [Step 1/1] + echo 'Error: Invalid build name '\''build-diff'\'''
[17:32:02]W:	 [Step 1/1] + exit 2
[17:32:02]W:	 [Step 1/1] Process exited with code 2
[17:32:02]E:	 [Step 1/1] Process exited with code 2 (Step: Command Line)

This seems like a configuration error. Does someone know what‘s going on there?

Jan 14 2020, 19:43
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 14 2020, 17:33
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed opcode to OP_REVERSEBYTES (which is the final name now), refactored & amended tests.

Jan 14 2020, 17:31
tobias_ruck added inline comments to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 14 2020, 16:16

Jan 11 2020

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

In a previous proposal, this opcode has been named OP_REVERSE. After that, it has been renamed to OP_BSWAP, as that is a more technically accurate term, which is commonly used for reversing the byteorder of integers [14] [15]. However, after some more consideration, it has been renamed to OP_ENDIAN_REVERSE following Boost‘s nomenclature [16]. This is because OP_BSWAP is lexically very similar to the already existing OP_SWAP and would make Script harder to read. Also, while the technical term for the instruction is indeed bswap, it isn‘t well known for developers of higher level languages and could thus spark confusion that would be avoided by using the name OP_ENDIAN_REVERSE, which is more self-descriptive.

Also added tests for unexecuted branches, clarified tests for not yet activated case.

Merged D4859 into this diff.

I'm not a fan of the new name... "Endian" to me seems hardware specific, and usually implies some power-of-2 number of bytes.... If you're worried about confusion, using the word "Endian" to me seems more confusing. It's possible people may use for things other than endian conversion, since it can reverse the byte order for any arbitrary-length string.

How about "OP_REVERSE_BYTES", or "OP_BYTE_SWAP"?

In any case, I guess this is a bit bike-sheddy, so not super-important either way.

Jan 11 2020, 22:40

Jan 10 2020

tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Collapsed reversed_data generation code.

Jan 10 2020, 01:01
tobias_ruck abandoned D4859: Added OP_BSWAP opcode without tests or behavior..

Accidentially updated wrong diff....

Jan 10 2020, 01:00
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Collapsed reversed_data generation code.

Jan 10 2020, 00:57

Jan 9 2020

tobias_ruck updated the summary of D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 9 2020, 16:46
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Implemented OP_BSWAP logic, added (always disabled) activation flag, added tests for OP_BSWAP. to Added OP_ENDIAN_REVERSE+implementation, added (always disabled) activation flag, added tests for OP_ENDIAN_REVERSE..
Jan 9 2020, 16:45
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed to OP_ENDIAN_REVERSE, reasons can be found in the PR:

Jan 9 2020, 16:41
tobias_ruck abandoned D4859: Added OP_BSWAP opcode without tests or behavior..

will be merged with D4871

Jan 9 2020, 16:16
tobias_ruck abandoned D4864: Fixed OP_BSWAP opcode number in script.py..

moved to D4871

Jan 9 2020, 16:15
tobias_ruck closed D4862: Added guide for OSX users on how to install clang-format-8..
Jan 9 2020, 11:29
tobias_ruck committed rABC55577b249220: Added guide for OSX users on how to install clang-format-8. (authored by tobias_ruck).
Added guide for OSX users on how to install clang-format-8.
Jan 9 2020, 11:29
tobias_ruck updated the summary of D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 9 2020, 09:27
tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Coordinated SCRIPT_ENABLE_OP_BSWAP script flag bit with @markblundeberg

Jan 9 2020, 00:29
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Renamed bswap_opcode_tests.cpp to op_bswap_tests.cpp

Jan 9 2020, 00:26
tobias_ruck updated the test plan for D4862: Added guide for OSX users on how to install clang-format-8..
Jan 9 2020, 00:11
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Squashed commits into one (commit amend failed previously)

Jan 9 2020, 00:07

Jan 8 2020

tobias_ruck added a comment to D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

I‘ve left the SCRIPT_ENABLE_OP_BSWAP flag at bit 22, this should be coordinated with @markblundeberg

Jan 8 2020, 22:41
tobias_ruck retitled D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag from Implemented OP_BSWAP logic, added (always disabled) activation flag, moved previous bswap_tests.cpp to byteswap_tests.cpp, added tests for OP_BSWAP. to Implemented OP_BSWAP logic, added (always disabled) activation flag, added tests for OP_BSWAP..
Jan 8 2020, 22:36
tobias_ruck updated the diff for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.

Applied review by @deadalnix. T707

Jan 8 2020, 22:35
tobias_ruck updated the test plan for D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 8 2020, 19:20
tobias_ruck created D4871: Added OP_REVERSEBYTES+implementation, added (always disabled) activation flag.
Jan 8 2020, 19:19
tobias_ruck updated the summary of D4859: Added OP_BSWAP opcode without tests or behavior..
Jan 8 2020, 19:04
tobias_ruck triaged T707: OP_REVERSEBYTES as Normal priority.
Jan 8 2020, 19:03 · Restricted Project
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Added OP_BSWAP opcode without tests or behavior.

Jan 8 2020, 17:09
tobias_ruck updated the diff for D4859: Added OP_BSWAP opcode without tests or behavior..

Fixed OP_BSWAP opcode number in script.py

Jan 8 2020, 17:02
tobias_ruck created D4864: Fixed OP_BSWAP opcode number in script.py..
Jan 8 2020, 15:41
tobias_ruck created D4862: Added guide for OSX users on how to install clang-format-8..
Jan 8 2020, 15:35
tobias_ruck created D4859: Added OP_BSWAP opcode without tests or behavior..
Jan 8 2020, 15:26