Paths

Table of Contentst

Diffusion Bitcoin ABC 15c3a21cc738

util: Move util/string.h functions to util namespace
15c3a21cc738
Actions

Tags

None

Subscribers

None

Description

util: Move util/string.h functions to util namespace

Summary:
There are no changes to behavior. Changes in this commit are all additions, and
are easiest to review using "git diff -U0 --word-diff-regex=." options.

Motivation for this change is to keep util functions with really generic names
like "Split" and "Join" out of the global namespace so it is easier to see
where these functions are defined, and so they don't interfere with function
overloading, especially since the util library is a dependency of the kernel
library and intended to be used with external code.

This is a partial backport of core#29015
https://github.com/bitcoin/bitcoin/pull/29015/changes/4f74c59334d496f28e1a5c0d84c412f9020b366f

Depends on D19754

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D19755

Details

Provenance

Ryan Ofsky <ryan@ofsky.org>	Authored on Dec 6 2023, 20:13
PiRK	Committed on Mar 31 2026, 15:10
PiRK	Pushed on Mar 31 2026, 15:10

Reviewer

Restricted Project

Differential Revision

D19755: util: Move util/string.h functions to util namespace

Parents

rABC494029df0ca6: util: add TransactionError includes and namespace declarations

Branches

Unknown

Tags

Unknown

Event Timeline

PiRK committed rABC15c3a21cc738: util: Move util/string.h functions to util namespace (authored by Ryan Ofsky <ryan@ofsky.org>).Mar 31 2026, 15:10

PiRK added an edge: D19755: util: Move util/string.h functions to util namespace.

Changes (64)

Path

Size

src/

avalanche/

test/

processor_tests.cpp

bitcoin-cli.cpp

common/

iguana/

init/

node/

kernel_notifications.cpp

ui_interface.cpp

qt/

optionsmodel.cpp

walletcontroller.cpp

rpc/

script/

seeder/

test/

options_tests.cpp

test/

addrman_tests.cpp

blockchain_tests.cpp

fuzz/

base_encode_decode.cpp

script_parsing.cpp

getarg_tests.cpp

logging_tests.cpp

miner_tests.cpp

scriptflags.cpp

serialize_tests.cpp

settings_tests.cpp

timedata_tests.cpp

util_threadnames_tests.cpp

validation_chainstatemanager_tests.cpp

util/

wallet/

rpc/

scriptpubkeyman.cpp

rABC15c3a21cc738

src/avalanche/test/processor_tests.cpp

Loading...

src/base58.cpp

Loading...

src/bitcoin-cli.cpp

Loading...

src/bitcoin-tx.cpp

Loading...

src/common/configfile.cpp

Loading...

src/common/system.cpp

Loading...

src/core_read.cpp

Loading...

src/httprpc.cpp

Loading...

src/i2p.cpp

Loading...

src/iguana/iguana.cpp

Loading...

src/init.cpp

Loading...

src/init/common.cpp

Loading...

src/logging.cpp

Loading...

src/logging.h

Loading...

src/netaddress.cpp

Loading...

src/netaddress.h

Loading...

src/netbase.cpp

Loading...

src/node/kernel_notifications.cpp

Loading...

src/node/ui_interface.cpp

Loading...

src/qt/bitcoin.cpp

Loading...

src/qt/optionsmodel.cpp

Loading...

src/qt/walletcontroller.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mempool.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/net.cpp

Loading...

src/rpc/server.cpp

Loading...

src/rpc/util.cpp

Loading...

src/script/descriptor.cpp

Loading...

src/seeder/test/options_tests.cpp

Loading...

src/test/addrman_tests.cpp

Loading...

src/test/blockchain_tests.cpp

Loading...

src/test/fuzz/base_encode_decode.cpp

Loading...

src/test/fuzz/integer.cpp

Loading...

src/test/fuzz/locale.cpp

Loading...

src/test/fuzz/script_parsing.cpp

Loading...

src/test/fuzz/string.cpp

Loading...

src/test/getarg_tests.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/logging_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/net_tests.cpp

Loading...

src/test/rpc_tests.cpp

Loading...

src/test/scriptflags.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/settings_tests.cpp

Loading...

src/test/timedata_tests.cpp

Loading...

src/test/util_tests.cpp

Loading...

src/test/util_threadnames_tests.cpp

Loading...

src/test/validation_chainstatemanager_tests.cpp

Loading...

src/torcontrol.cpp

Loading...

src/util/moneystr.cpp

Loading...

src/util/strencodings.h

Loading...

src/util/string.cpp

Loading...

src/util/string.h

Loading...

src/validation.cpp

Loading...

src/wallet/load.cpp

Loading...

src/wallet/rpc/backup.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/scriptpubkeyman.cpp

Loading...

src/wallet/transaction.h

Loading...

src/wallet/wallet.cpp

Loading...

src/warnings.cpp

Loading...