rpc: avoid copying into UniValue
3e38179e660a
Actions

Description

rpc: avoid copying into UniValue

Summary:

These are simple (and hopefully obviously correct) copies that can be moves
instead.

Backport of core#30115.

Also use references for params getters when possible.

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D19129

Details

Provenance

Cory Fields <cory-nospam-@coryfields.com>	Authored on May 13 2024, 20:20
Fabien	Committed on Dec 15 2025, 09:42
Fabien	Pushed on Dec 15 2025, 09:42

Reviewer

Restricted Project

Differential Revision

D19129: rpc: avoid copying into UniValue

Parents

rABC50095a964da2: [Automated] Update seeds

Branches

Unknown

Tags

Unknown

Event Timeline

Fabien committed rABC3e38179e660a: rpc: avoid copying into UniValue (authored by Cory Fields <cory-nospam-@coryfields.com>).Dec 15 2025, 09:42

Fabien added an edge: D19129: rpc: avoid copying into UniValue.

Changes (17)

Path

Size

src/

rpc/

rawtransaction_util.cpp

test/

wallet/

test/

zmq/

rABC3e38179e660a

View Options

src/bitcoin-cli.cpp

View Options

src/core_write.cpp

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/client.cpp

View Options

src/rpc/mempool.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/misc.cpp

View Options

src/rpc/net.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/rpc/rawtransaction_util.cpp

View Options

src/rpc/server.cpp

View Options

src/rpc/util.cpp

View Options

src/test/script_tests.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

rpc: avoid copying into UniValue3e38179e660aActions

Description

Details

Event Timeline

Changes (17)

rABC3e38179e660a

src/bitcoin-cli.cpp

src/core_write.cpp

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/client.cpp

src/rpc/mempool.cpp

src/rpc/mining.cpp

src/rpc/misc.cpp

src/rpc/net.cpp

src/rpc/rawtransaction.cpp

src/rpc/rawtransaction_util.cpp

src/rpc/server.cpp

src/rpc/util.cpp

src/test/script_tests.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_tests.cpp

src/zmq/zmqrpc.cpp

rpc: avoid copying into UniValue
3e38179e660a
Actions