Use serialization parameters for CAddress serialization
Summary:
This also cleans up the addrman (de)serialization code paths to only
allow Disk serialization. Some unit tests previously forced a
Network serialization, which does not make sense, because Bitcoin ABC
in production will always Disk serialize.
This cleanup idea was suggested by Pieter Wuille and implemented by Anthony
Towns.
Co-authored-by: Pieter Wuille <pieter@wuille.net>
Co-authored-by: Anthony Towns <aj@erisian.com.au>
This concludes backport of core#25284
https://github.com/bitcoin/bitcoin/pull/25284/commits/fac81affb527132945773a5315bd27fec61ec52f
Depends on D19056
Test Plan:
ninja all check-all bitcoin-fuzzers
Run the seeder for a while, check there are results (cat dnsseed.dump).
Reviewers: #bitcoin_abc, Fabien
Reviewed By: #bitcoin_abc, Fabien
Differential Revision: https://reviews.bitcoinabc.org/D19057