HomePhabricator

mapport: Cleanups to port mapping module post UPnP drop

Description

mapport: Cleanups to port mapping module post UPnP drop

Summary:
Remove dead/unreachable assertions in DispatchMapPort, then drop some logic that was used for switching between mapping protocols and is now unneeded.

This is a backport of core#31157 and concludes backport of core#31130
https://github.com/bitcoin/bitcoin/pull/31130/changes/40e5f26a3ff77e50df808f6f850c617aec2df203
Depends on D19805

Test Plan: ninja all check-all

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D19806

Details

Provenance
Antoine Poinsot <darosior@protonmail.com>Authored on Oct 25 2024, 19:07
PiRKCommitted on Apr 9 2026, 15:55
PiRKPushed on Apr 9 2026, 15:55
Reviewer
Restricted Project
Differential Revision
D19806: mapport: Cleanups to port mapping module post UPnP drop
Parents
rABC5a49cd66c32c: net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures
Branches
Unknown
Tags
Unknown