diff --git a/src/qt/receiverequestdialog.cpp b/src/qt/receiverequestdialog.cpp index 59445ef0f..9ea40a7f2 100644 --- a/src/qt/receiverequestdialog.cpp +++ b/src/qt/receiverequestdialog.cpp @@ -1,196 +1,215 @@ // Copyright (c) 2011-2016 The Bitcoin Core developers +// Copyright (c) 2017 The Bitcoin developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include "receiverequestdialog.h" #include "ui_receiverequestdialog.h" #include "bitcoinunits.h" #include "config.h" +#include "dstencode.h" #include "guiconstants.h" #include "guiutil.h" #include "optionsmodel.h" #include "walletmodel.h" #include #include #include #include #include #include #if QT_VERSION < 0x050000 #include #endif #if defined(HAVE_CONFIG_H) #include "config/bitcoin-config.h" /* for USE_QRCODE */ #endif #ifdef USE_QRCODE #include #endif QRImageWidget::QRImageWidget(QWidget *parent) : QLabel(parent), contextMenu(0) { contextMenu = new QMenu(this); QAction *saveImageAction = new QAction(tr("&Save Image..."), this); connect(saveImageAction, SIGNAL(triggered()), this, SLOT(saveImage())); contextMenu->addAction(saveImageAction); QAction *copyImageAction = new QAction(tr("&Copy Image"), this); connect(copyImageAction, SIGNAL(triggered()), this, SLOT(copyImage())); contextMenu->addAction(copyImageAction); } QImage QRImageWidget::exportImage() { if (!pixmap()) return QImage(); return pixmap()->toImage(); } void QRImageWidget::mousePressEvent(QMouseEvent *event) { if (event->button() == Qt::LeftButton && pixmap()) { event->accept(); QMimeData *mimeData = new QMimeData; mimeData->setImageData(exportImage()); QDrag *drag = new QDrag(this); drag->setMimeData(mimeData); drag->exec(); } else { QLabel::mousePressEvent(event); } } void QRImageWidget::saveImage() { if (!pixmap()) return; QString fn = GUIUtil::getSaveFileName(this, tr("Save QR Code"), QString(), tr("PNG Image (*.png)"), nullptr); if (!fn.isEmpty()) { exportImage().save(fn); } } void QRImageWidget::copyImage() { if (!pixmap()) return; QApplication::clipboard()->setImage(exportImage()); } void QRImageWidget::contextMenuEvent(QContextMenuEvent *event) { if (!pixmap()) return; contextMenu->exec(event->globalPos()); } ReceiveRequestDialog::ReceiveRequestDialog(const Config *cfg, QWidget *parent) : QDialog(parent), ui(new Ui::ReceiveRequestDialog), model(0), cfg(cfg) { ui->setupUi(this); #ifndef USE_QRCODE ui->btnSaveAs->setVisible(false); ui->lblQRCode->setVisible(false); #endif connect(ui->btnSaveAs, SIGNAL(clicked()), ui->lblQRCode, SLOT(saveImage())); } ReceiveRequestDialog::~ReceiveRequestDialog() { delete ui; } void ReceiveRequestDialog::setModel(OptionsModel *_model) { this->model = _model; if (_model) connect(_model, SIGNAL(displayUnitChanged(int)), this, SLOT(update())); // update the display unit if necessary update(); } +// Addresses are stored in the database with the encoding that the client was +// configured with at the time of creation. +// +// This converts to clients current configuration. +QString ToCurrentEncoding(const QString &addr, const Config &cfg) { + if (!IsValidDestinationString(addr.toStdString(), cfg.GetChainParams())) { + // We have something sketchy as input. Do not try to convert. + return addr; + } + CTxDestination dst = + DecodeDestination(addr.toStdString(), cfg.GetChainParams()); + return QString::fromStdString( + EncodeDestination(dst, cfg.GetChainParams(), cfg)); +} + void ReceiveRequestDialog::setInfo(const SendCoinsRecipient &_info) { this->info = _info; + // Display addresses with currently configured encoding. + this->info.address = ToCurrentEncoding(this->info.address, *cfg); update(); } void ReceiveRequestDialog::update() { if (!model) return; QString target = info.label; if (target.isEmpty()) target = info.address; setWindowTitle(tr("Request payment to %1").arg(target)); QString uri = GUIUtil::formatBitcoinURI(*cfg, info); ui->btnSaveAs->setEnabled(false); QString html; html += ""; html += "" + tr("Payment information") + "
"; html += "" + tr("URI") + ": "; html += "" + GUIUtil::HtmlEscape(uri) + "
"; html += "" + tr("Address") + ": " + GUIUtil::HtmlEscape(info.address) + "
"; if (info.amount != Amount(0)) html += "" + tr("Amount") + ": " + BitcoinUnits::formatHtmlWithUnit(model->getDisplayUnit(), info.amount) + "
"; if (!info.label.isEmpty()) html += "" + tr("Label") + ": " + GUIUtil::HtmlEscape(info.label) + "
"; if (!info.message.isEmpty()) html += "" + tr("Message") + ": " + GUIUtil::HtmlEscape(info.message) + "
"; ui->outUri->setText(html); #ifdef USE_QRCODE int fontSize = cfg->UseCashAddrEncoding() ? 10 : 12; ui->lblQRCode->setText(""); if (!uri.isEmpty()) { // limit URI length if (uri.length() > MAX_URI_LENGTH) { ui->lblQRCode->setText(tr("Resulting URI too long, try to reduce " "the text for label / message.")); } else { QRcode *code = QRcode_encodeString(uri.toUtf8().constData(), 0, QR_ECLEVEL_L, QR_MODE_8, 1); if (!code) { ui->lblQRCode->setText(tr("Error encoding URI into QR Code.")); return; } QImage qrImage = QImage(code->width + 8, code->width + 8, QImage::Format_RGB32); qrImage.fill(0xffffff); uint8_t *p = code->data; for (int y = 0; y < code->width; y++) { for (int x = 0; x < code->width; x++) { qrImage.setPixel(x + 4, y + 4, ((*p & 1) ? 0x0 : 0xffffff)); p++; } } QRcode_free(code); QImage qrAddrImage = QImage(QR_IMAGE_SIZE, QR_IMAGE_SIZE + 20, QImage::Format_RGB32); qrAddrImage.fill(0xffffff); QPainter painter(&qrAddrImage); painter.drawImage(0, 0, qrImage.scaled(QR_IMAGE_SIZE, QR_IMAGE_SIZE)); QFont font = GUIUtil::fixedPitchFont(); font.setPixelSize(fontSize); painter.setFont(font); QRect paddedRect = qrAddrImage.rect(); paddedRect.setHeight(QR_IMAGE_SIZE + 12); painter.drawText(paddedRect, Qt::AlignBottom | Qt::AlignCenter, info.address); painter.end(); ui->lblQRCode->setPixmap(QPixmap::fromImage(qrAddrImage)); ui->btnSaveAs->setEnabled(true); } } #endif } void ReceiveRequestDialog::on_btnCopyURI_clicked() { GUIUtil::setClipboard(GUIUtil::formatBitcoinURI(*cfg, info)); } void ReceiveRequestDialog::on_btnCopyAddress_clicked() { GUIUtil::setClipboard(info.address); } diff --git a/src/qt/receiverequestdialog.h b/src/qt/receiverequestdialog.h index eec7c83bf..788a79a3c 100644 --- a/src/qt/receiverequestdialog.h +++ b/src/qt/receiverequestdialog.h @@ -1,72 +1,76 @@ // Copyright (c) 2011-2016 The Bitcoin Core developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. #ifndef BITCOIN_QT_RECEIVEREQUESTDIALOG_H #define BITCOIN_QT_RECEIVEREQUESTDIALOG_H #include "walletmodel.h" #include #include #include #include +#include class OptionsModel; class Config; namespace Ui { class ReceiveRequestDialog; } QT_BEGIN_NAMESPACE class QMenu; QT_END_NAMESPACE /* Label widget for QR code. This image can be dragged, dropped, copied and * saved * to disk. */ class QRImageWidget : public QLabel { Q_OBJECT public: explicit QRImageWidget(QWidget *parent = 0); QImage exportImage(); public Q_SLOTS: void saveImage(); void copyImage(); protected: virtual void mousePressEvent(QMouseEvent *event) override; virtual void contextMenuEvent(QContextMenuEvent *event) override; private: QMenu *contextMenu; }; class ReceiveRequestDialog : public QDialog { Q_OBJECT public: explicit ReceiveRequestDialog(const Config *cfg, QWidget *parent = 0); ~ReceiveRequestDialog(); void setModel(OptionsModel *model); void setInfo(const SendCoinsRecipient &info); private Q_SLOTS: void on_btnCopyURI_clicked(); void on_btnCopyAddress_clicked(); void update(); private: Ui::ReceiveRequestDialog *ui; OptionsModel *model; SendCoinsRecipient info; const Config *cfg; }; +// exported for unittesting +QString ToCurrentEncoding(const QString &addr, const Config &); + #endif // BITCOIN_QT_RECEIVEREQUESTDIALOG_H diff --git a/src/qt/test/guiutiltests.cpp b/src/qt/test/guiutiltests.cpp index 2ebafb087..978a2f6f5 100644 --- a/src/qt/test/guiutiltests.cpp +++ b/src/qt/test/guiutiltests.cpp @@ -1,39 +1,62 @@ // Copyright (c) 2017 The Bitcoin developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. #include "guiutiltests.h" #include "chainparams.h" #include "config.h" #include "dstencode.h" #include "guiutil.h" +#include "receiverequestdialog.h" namespace { class UtilCfgDummy : public DummyConfig { public: UtilCfgDummy() : useCashAddr(false) {} void SetCashAddrEncoding(bool b) override { useCashAddr = b; } bool UseCashAddrEncoding() const override { return useCashAddr; } + const CChainParams &GetChainParams() const override { + return Params(CBaseChainParams::MAIN); + } private: bool useCashAddr; }; } // anon ns void GUIUtilTests::dummyAddressTest() { CChainParams ¶ms = Params(CBaseChainParams::MAIN); UtilCfgDummy cfg; std::string dummyaddr; cfg.SetCashAddrEncoding(false); dummyaddr = GUIUtil::DummyAddress(params, cfg); QVERIFY(!IsValidDestinationString(dummyaddr, params)); QVERIFY(!dummyaddr.empty()); cfg.SetCashAddrEncoding(true); dummyaddr = GUIUtil::DummyAddress(params, cfg); QVERIFY(!IsValidDestinationString(dummyaddr, params)); QVERIFY(!dummyaddr.empty()); } + +void GUIUtilTests::toCurrentEncodingTest() { + UtilCfgDummy config; + + // garbage in, garbage out + QVERIFY(ToCurrentEncoding("garbage", config) == "garbage"); + + QString cashaddr_pubkey = + "bitcoincash:qpm2qsznhks23z7629mms6s4cwef74vcwvy22gdx6a"; + QString base58_pubkey = "1BpEi6DfDAUFd7GtittLSdBeYJvcoaVggu"; + + config.SetCashAddrEncoding(true); + QVERIFY(ToCurrentEncoding(cashaddr_pubkey, config) == cashaddr_pubkey); + QVERIFY(ToCurrentEncoding(base58_pubkey, config) == cashaddr_pubkey); + + config.SetCashAddrEncoding(false); + QVERIFY(ToCurrentEncoding(cashaddr_pubkey, config) == base58_pubkey); + QVERIFY(ToCurrentEncoding(base58_pubkey, config) == base58_pubkey); +} diff --git a/src/qt/test/guiutiltests.h b/src/qt/test/guiutiltests.h index 0599e3796..6bf559a64 100644 --- a/src/qt/test/guiutiltests.h +++ b/src/qt/test/guiutiltests.h @@ -1,18 +1,19 @@ // Copyright (c) 2017 The Bitcoin developers // Distributed under the MIT software license, see the accompanying // file COPYING or http://www.opensource.org/licenses/mit-license.php. #ifndef BITCOIN_QT_TEST_GUIUTILTESTS_H #define BITCOIN_QT_TEST_GUIUTILTESTS_H #include #include class GUIUtilTests : public QObject { Q_OBJECT private Q_SLOTS: void dummyAddressTest(); + void toCurrentEncodingTest(); }; #endif // BITCOIN_QT_TEST_GUIUTILTESTS_H