HomePhabricator

Do not add random inbound peers to addrman.
eb3596f7c220Unpublished

Unpublished Commit ยท Learn More

Repository Importing: This repository is still importing.

Description

Do not add random inbound peers to addrman.

We should learn about new peers via address messages.

An inbound peer connecting to us tells us nothing about
its ability to accept incoming connections from us, so
we shouldn't assume that we can connect to it based on
this.

The vast majority of nodes on the network do not accept
incoming connections, adding them will only slow down
the process of making a successful connection in the
future.

Nodes which have configured themselves to not announce would prefer we
not violate their privacy by announcing them in GETADDR responses.

Details

Provenance
Gregory Maxwell <greg@xiph.org>Authored on Aug 25 2016, 23:42
schancelPushed on Jan 5 2018, 21:58
schancelPushed on Jan 5 2018, 21:39
schancelPushed on Jan 5 2018, 21:17
Parents
rSTAGING53f8f226bd1d: Merge #8462: Move AdvertiseLocal debug output to net category
Branches
Unknown
Tags
Unknown

Event Timeline

Gregory Maxwell <greg@xiph.org> committed rSTAGINGeb3596f7c220: Do not add random inbound peers to addrman. (authored by Gregory Maxwell <greg@xiph.org>).Aug 25 2016, 23:48