This is a backport of [[https://github.com/bitcoin/bitcoin/pull/16528 | core#16528]] [43b/43]
https://github.com/bitcoin/bitcoin/pull/16528/commits/223588b1bbc63dc57098bbd0baa48635e0cc0b82
This is the second part of the backport started in D10213, addressing
two of the remaining tests:
- wallet_basic.py
- wallet_keypool.py
These 2 tests requires some additional changes to adjust fees and
amounts,wallet_basic.py required adding `round_satoshi` when dividing the wallet balance by two, because previous changes in the test when using --descriptors cause the wallet to now have an odd number of satoshis.
For wallet_keypool.py, it only make sense to import one type of descriptor instead of the 3 types imported by Core, because we only have the LEGACY output type. as descriptor wallets can produce larger p2sh outputs
were previously the tests was producing p2pkh ouputs.We miss BECH32 (`wpkh(...)` descriptors) and P2SH_SEGWIT (`sh(wpkh(...))` descriptors)
The remaining test requires some fixing before it can be backported.
Depends on D10213