Change Details

This PR adds missing test coverage for disconnecting peers which don't offer the desirable service flags in their VERSION message. This check is relevant for the connection types "outbound-full-relay", "block-relay-only" and "addr-fetch" (see CNode::ExpectServicesFromConn(...)). Feeler connections always disconnect, which is also tested here. This also adds coverage for the logic introduced in PR #28170 ("p2p: adaptive connections services flags"). This is a backport of core#29279, core#29704 and core#29898 Depends on D18451

This PR adds missing test coverage for disconnecting peers which don't offer the desirable service flags in their VERSION message. This check is relevant for the connection types "outbound-full-relay", "block-relay-only" and "addr-fetch" (see CNode::ExpectServicesFromConn(...)). Feeler connections always disconnect, which is also tested here. This also adds coverage for the logic introduced in PR #28170 ("p2p: adaptive connections services flags"). This is a backport of [[https://github.com/bitcoin/bitcoin/pull/29279 | core#29279]], [[https://github.com/bitcoin/bitcoin/pull/29704 | core#29704]] and [[https://github.com/bitcoin/bitcoin/pull/29898 | core#29898]] Depends on D18451

This PR adds missing test coverage for disconnecting peers which don't offer the desirable service flags in their VERSION message. This check is relevant for the connection types "outbound-full-relay", "block-relay-only" and "addr-fetch" (see CNode::ExpectServicesFromConn(...)). Feeler connections always disconnect, which is also tested here. This also adds coverage for the logic introduced in PR #28170 ("p2p: adaptive connections services flags"). This is a backport of [[https://github.com/bitcoin/bitcoin/pull/29279 | core#29279]], core#29704 and core#29898[[https://github.com/bitcoin/bitcoin/pull/29704 | core#29704]] and [[https://github.com/bitcoin/bitcoin/pull/29898 | core#29898]] Depends on D18451