Change Details

fa6f402bde146f92ed131e0c9c8e15a55e723307 Call node->initError instead of InitError from GUI code (Russell Yanofsky) fad2502240a1c440ef03ac3f880475702e418275 init: Use InitError for all errors in bitcoind/qt (MarcoFalke) Pull request description: Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: ```sh BITCOIND=bitcoin-qt ./test/functional/test_runner.py feature_includeconf feature_config_args ACKs for top commit: hebasto: ACK fa6f402bde146f92ed131e0c9c8e15a55e723307 ryanofsky: utACK fa6f402bde146f92ed131e0c9c8e15a55e723307. Only changes since last review are removing more includes and adding Node::initError method to avoid accessing node `InitError` function and global variables from GUI code. Tree-SHA512: bd19e08dcea4019dfe40356bc5c63cb583cefed54b6c9dcfb82f1b5b00308d8e2b363549afcaea5e93bf83864dbe0917400c3b70f43a8a5bdff45c9cd34cc294 --- This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16366 | PR16366]]

**Merge #16366: init: Use InitError for all errors in bitcoind/qt** fa6f402 Call node->initError instead of InitError from GUI code (Russell Yanofsky) fad2502 init: Use InitError for all errors in bitcoind/qt (MarcoFalke) Pull request description: ``` Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: BITCOIND=bitcoin-qt ./test/functional/test_runner.py feature_includeconf feature_config_args ``` **Merge bitcoin#15864: Fix datadir handling** ffea41f Enable all tests in feature_config_args.py (Hennadii Stepanov) 66f5c17 Use CheckDataDirOption() for code uniformity (Hennadii Stepanov) 7e33a18 Fix datadir handling in bitcoin-cli (Hennadii Stepanov) b28dada Fix datadir handling in bitcoin-qt (Hennadii Stepanov) 5082409 Fix datadir handling in bitcoind (Hennadii Stepanov) 740d41c Add CheckDataDirOption() function (Hennadii Stepanov) c1f3251 Return absolute path early in AbsPathForConfigVal (Hennadii Stepanov) Pull request description: Fix bitcoin#15240, see: bitcoin#15240 (comment) Fix bitcoin#15745 Fix broken `feature_config_args.py` tests (disabled by MarcoFalke/bitcoin-core@fabe28a). All test are enabled now. This PR is alternative to bitcoin#13621. User's `$HOME` directory is not touched unnecessarily now. --- This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16366 | PR16366]] and [[https://github.com/bitcoin/bitcoin/pull/15864 | PR15864]]

fa6f402bde146f92ed131e0c9c8e15a55e723307**Merge #16366: init: Use InitError for all errors in bitcoind/qt** fa6f402 Call node->initError instead of InitError from GUI code (Russell Yanofsky) fad2502240a1c440ef03ac3f880475702e418275 init: Use InitError for all errors in bitcoind/qt (MarcoFalke) Pull request description: ``` Using the same InitError for startup error in the daemon and the gui makes it possible to run the tests with the gui again: ```sh BITCOIND=bitcoin-qt ./test/functional/test_runner.py feature_includeconf feature_config_args ``` ACKs for top commit:**Merge bitcoin#15864: Fix datadir handling** ffea41f Enable all tests in feature_config_args.py (Hennadii Stepanov) 66f5c17 Use CheckDataDirOption() for code uniformity (Hennadii Stepanov) 7e33a18 Fix datadir handling in bitcoin-cli (Hennadii Stepanov) b28dada Fix datadir handling in bitcoin-qt (Hennadii Stepanov) 5082409 Fix datadir handling in bitcoind (Hennadii Stepanov) 740d41c Add CheckDataDirOption() function (Hennadii Stepanov) c1f3251 Return absolute path early in AbsPathForConfigVal (Hennadii Stepanov) Pull request description: hebasto:Fix bitcoin#15240, see: bitcoin#15240 (comment) ACK fa6f402bde146f92ed131e0c9c8e15a55e723307Fix bitcoin#15745 ryanofsky:Fix broken `feature_config_args.py` tests (disabled by MarcoFalke/bitcoin-core@fabe28a). All test are enabled now. utACK fa6f402bde146f92ed131e0c9c8e15a55e723307. Only changes since last review are removing more includes and adding Node::initError method to avoid accessing node `InitError` function and global variables from GUI code. Tree-SHA512: bd19e08dcea4019dfe40356bc5c63cb583cefed54b6c9dcfb82f1b5b00308d8e2b363549afcaea5e93bf83864dbe0917400c3b70f43a8a5bdff45c9cd34cc294This PR is alternative to bitcoin#13621. User's `$HOME` directory is not touched unnecessarily now. --- This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16366 | PR16366]] and [[https://github.com/bitcoin/bitcoin/pull/15864 | PR15864]]