Change Details

Instead of (ab)using the existing `BlockValidity` flags to mark CBlockIndex entries which we haven't yet fully validated (but assume validity for use with UTXO snapshot loading), introduce a status flag that specifically marks an assumed-valid state. This state is then removed in RaiseValidity() when the block has actually been validated. This distinction will allow us to make the necessary changes to various parts of the system to facilitate assumeutxo/background chainstate validation but without leaking details like snapshot height, as we had done previously. Changes that actually make use of this flag follow in future commits. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/21526 | core#21526]] [4/12] https://github.com/bitcoin/bitcoin/pull/21526/commits/42b2520db93fd9feb3df4101654391fa7d3e2140 Depends on D12278

> chain: add and set ASSUMED_VALID_FLAG for assumeutxo > > Instead of (ab)using the existing `BlockValidity` flags to mark CBlockIndex entries which > we haven't yet fully validated (but assume validity for use with UTXO snapshot > loading), introduce a status flag that specifically marks an assumed-valid state. > > This state is then removed in RaiseValidity() when the block has actually been > validated. > > This distinction will allow us to make the necessary changes to various parts of the > system to facilitate assumeutxo/background chainstate validation but without leaking > details like snapshot height, as we had done previously. > validation: set ASSUMED_VALID_FLAG during snapshot load > > Mark the block index entries that are beneath the snapshot base block as > assumed-valid. Subsequent commits will make use of this flag in other > parts of the system. This is a backport of core#21526 [4/12] https://github.com/bitcoin/bitcoin/pull/21526/commits/42b2520db93fd9feb3df4101654391fa7d3e2140 https://github.com/bitcoin/bitcoin/pull/21526/commits/01a9b8fe719efab2c268dc738bc93cfbdf92edb7 Depends on D12278

Instead of (ab)using the existing `BlockValidity` flags to mark CBlockIndex entries which> chain: add and set ASSUMED_VALID_FLAG for assumeutxo we haven't yet fully validated (but assume validity for use with UTXO snapshot> loading), introduce a status flag that specifically marks an assumed-valid state. This state is then removed in RaiseValidity() when the block has actually been> Instead of (ab)using the existing `BlockValidity` flags to mark CBlockIndex entries which validated. This distinction will allow us to make the necessary changes to various parts of the> we haven't yet fully validated (but assume validity for use with UTXO snapshot > loading), introduce a status flag that specifically marks an assumed-valid state. > > This state is then removed in RaiseValidity() when the block has actually been > validated. > system to facilitate assumeutxo/background> This distinction will allow us to make the necessary chainstate validation but without leakingnges to various parts of the > system to facilitate assumeutxo/background chainstate validation but without leaking > details like snapshot height, as we had done previously. Changes that actually> validation: set ASSUMED_VALID_FLAG during snapshot load > > Mark the block index entries that are beneath the snapshot base block as > assumed-valid. Subsequent commits will make use of this flag follow in future commitsin other > parts of the system. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/21526 | core#21526]] [4/12] https://github.com/bitcoin/bitcoin/pull/21526/commits/42b2520db93fd9feb3df4101654391fa7d3e2140 https://github.com/bitcoin/bitcoin/pull/21526/commits/01a9b8fe719efab2c268dc738bc93cfbdf92edb7 Depends on D12278