Change Details

The alias spec redesign a few months ago silently broke a few `parseChronikTx` related elements. These should be patched together under this single diff as updating the unit test mock will break multiple unit test vectors. 1. The rendering of the alias name in the tx history tab was no longer being rendered. `parseChronikTx` was expecting the alias name to be the 2nd array element `parsedOpReturnArray[1]`, which based on the lastest alias spec is now the version number. The alias name is actually the 3rd element in the array now. The unit tests didn't pick this up because the unit test mock data was based on the old spec where the alias name was the 2nd element in the opreturn array. Mock now updated with a [[ https://explorer.e.cash/tx/f64608b13daf977008cfb96eb97082014c11cad5575956591a7ac9832d4fca9c | live example from explorer ]]. 2. The `xecAmount` property was showing the total sats associated with ALL outputs rather than just the alias registration fee paid. This is because the new spec now uses separate outputs for the OP_RETURN script and the actual registration payment to the IFP address. The current `parseChronikTx` assumes all output values not associated with the sending address is the actual send amount, which is only true for non-alias registration txs. Added an override where if `aliasFlag` is true then extract `output[1].value` as the registration fee. If this is accepted then I'll update the spec separately to mandate the payment fee as the 2nd output after the first OP_RETURN output. 3. The live alias registration tx was being incorrectly parsed as `incoming` by `parseChronikTx`'s unit test. This is because the hash160 `mockParseTxWallet` didn't match the hash160 from the live example taken from explorer. Added `mockParseAliasTxWallet` to chronikTxHistory mock. No issue with the code itself.

The alias spec redesign a few months ago silently broke a few `parseChronikTx` related elements. These should be patched together under this single diff as updating the unit test mock will break multiple unit test vectors. 1. The rendering of the alias name in the tx history tab was no longer being rendered. `parseChronikTx` was expecting the alias name to be the 2nd array element `parsedOpReturnArray[1]`, which based on the lastest alias spec is now the version number. The alias name is actually the 3rd element in the array now. The unit tests didn't pick this up because the unit test mock data was based on the old spec where the alias name was the 2nd element in the opreturn array. Mock now updated with a [[ https://explorer.e.cash/tx/f64608b13daf977008cfb96eb97082014c11cad5575956591a7ac9832d4fca9c | live example from explorer ]]. 2. The `xecAmount` property was showing the total sats associated with ALL outputs rather than just the alias registration fee paid. This is because the new spec now uses separate outputs for the OP_RETURN script and the actual registration payment to the IFP address. The current `parseChronikTx` assumes all output values not associated with the sending address is the actual send amount, which is only true for non-alias registration txs. Added an override where if `aliasFlag` is true then extract `output[1].value` as the registration fee. If this is accepted then I'll update the spec separately to mandate the payment fee as the 2nd output after the first OP_RETURN output. 3. The live alias registration tx was being incorrectly parsed as `incoming` by `parseChronikTx`'s unit test. This is because the hash160 `mockParseTxWallet` didn't match the hash160 from the live example taken from explorer. Added `mockParseAliasTxWallet` to chronikTxHistory mock. No issue with the code itself.

The alias spec redesign a few months ago silently broke a few `parseChronikTx` related elements. These should be patched together under this single diff as updating the unit test mock will break multiple unit test vectors. 1. The rendering of the alias name in the tx history tab was no longer being rendered. `parseChronikTx` was expecting the alias name to be the 2nd array element `parsedOpReturnArray[1]`, which based on the lastest alias spec is now the version number. The alias name is actually the 3rd element in the array now. The unit tests didn't pick this up because the unit test mock data was based on the old spec where the alias name was the 2nd element in the opreturn array. Mock now updated with a [[ https://explorer.e.cash/tx/f64608b13daf977008cfb96eb97082014c11cad5575956591a7ac9832d4fca9c | live example from explorer ]]. 2. The `xecAmount` property was showing the total sats associated with ALL outputs rather than just the alias registration fee paid. This is because the new spec now uses separate outputs for the OP_RETURN script and the actual registration payment to the IFP address. The current `parseChronikTx` assumes all output values not associated with the sending address is the actual send amount, which is only true for non-alias registration txs. Added an override where if `aliasFlag` is true then extract `output[1].value` as the registration fee. If this is accepted then I'll update the spec separately to mandate the payment fee as the 2nd output after the first OP_RETURN output. 3. The live alias registration tx was being incorrectly parsed as `incoming` by `parseChronikTx`'s unit test. This is because the hash160 `mockParseTxWallet` didn't match the hash160 from the live example taken from explorer. Added `mockParseAliasTxWallet` to chronikTxHistory mock. No issue with the code itself.