Change Details

The order of destructor cleanup is reverse of declaration order. Thus we need nSigChecksBlockLimiter to be declared before `control` which is the RAII on all script check worker threads having finished their work. (D5179)

See sanitizer log here, we have a use after scope: https://build.bitcoinabc.org/viewLog.html?buildId=29430&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=artifacts The order of destructor cleanup is reverse of declaration order. Thus we need `nSigChecksBlockLimiter` to be declared before `control` which is the RAII on all script check worker threads having finished their work. (D5179)

See sanitizer log here, we have a use after scope: https://build.bitcoinabc.org/viewLog.html?buildId=29430&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterAsan&tab=artifacts The order of destructor cleanup is reverse of declaration order. Thus we need `nSigChecksBlockLimiter` to be declared before `control` which is the RAII on all script check worker threads having finished their work. (D5179)