Change Details

``` Keep a references to chainparams, rather than calling the global Params() function every time it's needed. This is fine, since globalChainParams does not get updated once it's been set, and it's available at the point of constructing the PeerLogicValidation object. ``` Partial backport of core [[https://github.com/bitcoin/bitcoin/pull/19791 | PR19791]] (2/9): https://github.com/bitcoin/bitcoin/pull/19791/commits/2297b26b3ce95e935c0ebb8c38dabf19965054a5 This differs from the original PR by passing a `Config` instead of a `CChainParams` reference. This implies that there are now some unused config parameters which needs to be cleaned up in a later diff (all `NetEventInterface` methods).

``` Keep a references to chainparams, rather than calling the global Params() function every time it's needed. This is fine, since globalChainParams does not get updated once it's been set, and it's available at the point of constructing the PeerLogicValidation object. ``` Partial backport of core [[https://github.com/bitcoin/bitcoin/pull/19791 | PR19791]] (2/9): https://github.com/bitcoin/bitcoin/pull/19791/commits/2297b26b3ce95e935c0ebb8c38dabf19965054a5 This differs from the original PR by passing a `Config` instead of a `CChainParams` reference. The config is needed down the road, and provide a facility to retrieve the chainparams, so storing it makes it possible to have a simpler API. This implies that there are now some unused config parameters which needs to be cleaned up in a later diff (all `NetEventInterface` methods).

``` Keep a references to chainparams, rather than calling the global Params() function every time it's needed. This is fine, since globalChainParams does not get updated once it's been set, and it's available at the point of constructing the PeerLogicValidation object. ``` Partial backport of core [[https://github.com/bitcoin/bitcoin/pull/19791 | PR19791]] (2/9): https://github.com/bitcoin/bitcoin/pull/19791/commits/2297b26b3ce95e935c0ebb8c38dabf19965054a5 This differs from the original PR by passing a `Config` instead of a `CChainParams` reference. The config is needed down the road, and provide a facility to retrieve the chainparams, so storing it makes it possible to have a simpler API. `CChainParams` reference. This implies that there are now some unused config parameters which needs to be cleaned up in a later diff (all all `NetEventInterface` methods).