Change Details

- npm test - npm start - Open a wallet and manually simulate this edge case where the `wallet.Path1899.cashAddress` value contains a bitcoincash: prefixed address. The easiest way to achieve this is to temporarily add: ``` const { type, hash } = cashaddr.decode(wallet.Path1899.cashAddress); wallet.Path1899.cashAddress = cashaddr.encode('bitcoincash', type, hash); ``` near the top of `loadWalletFromStorageOnStartup` along with debug logs right after the getWallet() call. - Re-load cashtab then ensure debug logs reflect the detection of a non-eCash prefixed address for Path1899 and subsequent conversion to eCash prefix. - Repeat for the Path245 and Path145 derivation path cash addresses.

- npm test - npm start - Open a wallet and manually simulate this edge case where the `wallet.Path1899.cashAddress` value contains a bitcoincash: prefixed address. The easiest way to achieve this is to temporarily add `delete existingWallet.Path1899` to `getWallet()` in order to override `isLegacyMigrationRequired()` to always return true, which triggers `migrateLegacyWallet()`. Then add the following to `migrateLegacyWallet()` along with debug logs to show detection of a non-eCash prefixed address in Path1899: ``` const { type, hash } = cashaddr.decode(wallet.Path1899.cashAddress); wallet.Path1899.cashAddress = cashaddr.encode('bitcoincash', type, hash); ``` - Re-load cashtab then ensure debug logs reflect the detection of a non-eCash prefixed address for Path1899 and subsequent conversion to eCash prefix. - Repeat for the Path245 and Path145 derivation path cash addresses.

- npm test - npm start - Open a wallet and manually simulate this edge case where the `wallet.Path1899.cashAddress` value contains a bitcoincash: prefixed address. The easiest way to achieve this is to temporarily add `delete existingWallet.Path1899` to `getWallet()` in order to override `isLegacyMigrationRequired()` to always return true, which triggers `migrateLegacyWallet()`. The easiest way to achieve this is to temporarily addn add the following to `migrateLegacyWallet()` along with debug logs to show detection of a non-eCash prefixed address in Path1899: ``` const { type, hash } = cashaddr.decode(wallet.Path1899.cashAddress); wallet.Path1899.cashAddress = cashaddr.encode('bitcoincash', type, hash); ``` near the top of `loadWalletFromStorageOnStartup` along with debug logs right after the getWallet() call. - Re-load cashtab then ensure debug logs reflect the detection of a non-eCash prefixed address for Path1899 and subsequent conversion to eCash prefix. - Repeat for the Path245 and Path145 derivation path cash addresses.