Change Details

> This is split out from #18531 to just touch some RPC methods. Description from the main pr: > Motivation > > RPCArg names in the rpc help are currently only used for documentation. However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors). See section "bugs found" for a list of bugs that have been found as a result of the changes here. > > Changes > The changes here add an assert in the CRPCCommand constructor that the RPCArg names are identical to the ones in the CRPCCommand. This is a backport of core#19849 [1/2] https://github.com/bitcoin/bitcoin/pull/19849/commits/fa80c814874a2893e4323ba5148fba21d7f421cd

> This is split out from #18531 to just touch some RPC methods. Description from the main pr: > Motivation > > RPCArg names in the rpc help are currently only used for documentation. However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors). See section "bugs found" for a list of bugs that have been found as a result of the changes here. > > Changes > The changes here add an assert in the CRPCCommand constructor that the RPCArg names are identical to the ones in the CRPCCommand. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/19849 | core#19849]] [1/2] https://github.com/bitcoin/bitcoin/pull/19849/commits/fa80c814874a2893e4323ba5148fba21d7f421cd

> This is split out from #18531 to just touch some RPC methods. Description from the main pr: > Motivation > > RPCArg names in the rpc help are currently only used for documentation. However, in the future they could be used to teach the server the named arguments. Named arguments are currently registered by the CRPCCommands and duplicate the RPCArg names from the documentation. This redundancy is fragile, and has lead to errors in the past (despite having linters to catch those kind of errors). See section "bugs found" for a list of bugs that have been found as a result of the changes here. > > Changes > The changes here add an assert in the CRPCCommand constructor that the RPCArg names are identical to the ones in the CRPCCommand. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/19849 | core#19849]] [1/2] https://github.com/bitcoin/bitcoin/pull/19849/commits/fa80c814874a2893e4323ba5148fba21d7f421cd