Change Details

> It appears that invoking v = {}; for an std::vector<...> v is equivalent to v.clear(), which does not release its allocated memory. There are a number of places in the codebase where it appears to be used for that purpose however (mostly written by me). Replace those with std::vector<...>{}.swap(v); (using a helper function ClearShrink in util/vector.h). For now the net.cpp changes are not applicable, as they depend on V2Transport backports. The change is useful anyway even if we just apply it to the headersync data. IIUC we could save about multiple megabytes per peer involved in header pre-sync of memory that would otherwsise not be freed during the entire lifetime of the connection. `m_redownloaded_headers` is a buffer that can stores block headers during the redownload phase of header synchronization. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/28452 | core#28452]]

> It appears that invoking v = {}; for an std::vector<...> v is equivalent to v.clear(), which does not release its allocated memory. There are a number of places in the codebase where it appears to be used for that purpose however (mostly written by me). Replace those with std::vector<...>{}.swap(v); (using a helper function ClearShrink in util/vector.h). For now the net.cpp changes are not applicable, as they depend on V2Transport backports. The change is useful anyway even if we just apply it to the headersync data. IIUC we could save multiple megabytes of memory, that would otherwsise not be freed during the entire lifetime of the connection, per peer involved in header pre-sync . `m_redownloaded_headers` is a buffer that can stores block headers during the redownload phase of header synchronization. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/28452 | core#28452]]

> It appears that invoking v = {}; for an std::vector<...> v is equivalent to v.clear(), which does not release its allocated memory. There are a number of places in the codebase where it appears to be used for that purpose however (mostly written by me). Replace those with std::vector<...>{}.swap(v); (using a helper function ClearShrink in util/vector.h). For now the net.cpp changes are not applicable, as they depend on V2Transport backports. The change is useful anyway even if we just apply it to the headersync data. IIUC we could save about multiple megabytes per peer involved in header pre-synces of memory, that would otherwsise not be freed during the entire lifetime of the connection, per peer involved in header pre-sync . `m_redownloaded_headers` is a buffer that can stores block headers during the redownload phase of header synchronization. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/28452 | core#28452]]