Change Details

Previously CSeederNode::nStartingHeight was initialized only after receiving the version message. This caused a test in p2p_messaging_tests to intermittently fail on some platforms when nStartingHeight was a random value larger than 0. ``` FAILED: src/seeder/test/CMakeFiles/check-seeder-p2p_messaging_tests Running 6 test cases... ../../src/seeder/test/p2p_messaging_tests.cpp:38: error: in "p2p_messaging_tests/ban_too_many_headers": check ret == expectedState has failed [1 != 0] ../../src/seeder/test/p2p_messaging_tests.cpp:178: error: in "p2p_messaging_tests/ban_too_many_headers": check testNode->GetBan() == 0 has failed [100000 != 0] ``` Also modernize adjacent members with C++ 11 member initialization while we are touching this code.

Previously CSeederNode::nStartingHeight was initialized only after receiving the version message. This caused a test in p2p_messaging_tests to intermittently fail on some platforms when nStartingHeight was a random value larger than 0. ``` FAILED: src/seeder/test/CMakeFiles/check-seeder-p2p_messaging_tests Running 6 test cases... ../../src/seeder/test/p2p_messaging_tests.cpp:38: error: in "p2p_messaging_tests/ban_too_many_headers": check ret == expectedState has failed [1 != 0] ../../src/seeder/test/p2p_messaging_tests.cpp:178: error: in "p2p_messaging_tests/ban_too_many_headers": check testNode->GetBan() == 0 has failed [100000 != 0] ``` Also modernize adjacent members with C++ 11 member initialization and remove unused members `nHeaderStart` and `nMessageStart` while we are touching this code.

Previously CSeederNode::nStartingHeight was initialized only after receiving the version message. This caused a test in p2p_messaging_tests to intermittently fail on some platforms when nStartingHeight was a random value larger than 0. ``` FAILED: src/seeder/test/CMakeFiles/check-seeder-p2p_messaging_tests Running 6 test cases... ../../src/seeder/test/p2p_messaging_tests.cpp:38: error: in "p2p_messaging_tests/ban_too_many_headers": check ret == expectedState has failed [1 != 0] ../../src/seeder/test/p2p_messaging_tests.cpp:178: error: in "p2p_messaging_tests/ban_too_many_headers": check testNode->GetBan() == 0 has failed [100000 != 0] ``` Also modernize adjacent members with C++ 11 member initialization and remove unused members `nHeaderStart` and `nMessageStart` while we are touching this code.