Change Details

> The exact order of the if, is important, we first do `!MoneyRange(tx_out.nValue)` to make sure the amount is non-negative. and then `std::numeric_limits<CAmount>::max() - tx_out.nValue < nValueOut` checks that the addition cannot overflow (if we won't check that the amount is positive this check can also overflow! (by doing something like `max - -max`)) > and only then we make sure that the sum is also valid `!MoneyRange(nValueOut + tx_out.nValue`) > if any of these conditions fail we throw. This is a backport of Core PR18383

> The exact order of the if, is important, we first do `!MoneyRange(tx_out.nValue)` to make sure the amount is non-negative. and then `std::numeric_limits<CAmount>::max() - tx_out.nValue < nValueOut` checks that the addition cannot overflow (if we won't check that the amount is positive this check can also overflow! (by doing something like `max - -max`)) > and only then we make sure that the sum is also valid `!MoneyRange(nValueOut + tx_out.nValue`) > if any of these conditions fail we throw. This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/18383 | PR18383]]

> The exact order of the if, is important, we first do `!MoneyRange(tx_out.nValue)` to make sure the amount is non-negative. and then `std::numeric_limits<CAmount>::max() - tx_out.nValue < nValueOut` checks that the addition cannot overflow (if we won't check that the amount is positive this check can also overflow! (by doing something like `max - -max`)) > and only then we make sure that the sum is also valid `!MoneyRange(nValueOut + tx_out.nValue`) > if any of these conditions fail we throw. This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/18383 | PR18383]]