Change Details

``` This allows us to separate the initialization code from translations and error reporting. This change changes the caller semantics of LoadChainstate quitendrastically. To see that this change doesn't change behaviour, observe that: 1. Prior to this change, LoadChainstate returned false only in the "bad genesis block" failure case (by returning InitError()), indicating that the caller should immediately bail. After this change, the corresponding ERROR_BAD_GENESIS_BLOCK handler in src/init.cpp maintains behavioue by also bailing immediately. 2. The failed_* temporary booleans were only used to break out of the outer do/while(false) loop. They can therefore be safely removed. ``` Partial backport of core#23280: https://github.com/bitcoin/bitcoin/pull/23280/commits/ae9121f958a4124ea6238cad0c3f2acb8b9eb4bb# Depends on D12556.

``` This allows us to separate the initialization code from translations and error reporting. This change changes the caller semantics of LoadChainstate quitendrastically. To see that this change doesn't change behaviour, observe that: 1. Prior to this change, LoadChainstate returned false only in the "bad genesis block" failure case (by returning InitError()), indicating that the caller should immediately bail. After this change, the corresponding ERROR_BAD_GENESIS_BLOCK handler in src/init.cpp maintains behavioue by also bailing immediately. 2. The failed_* temporary booleans were only used to break out of the outer do/while(false) loop. They can therefore be safely removed. ``` Partial backport of [[https://github.com/bitcoin/bitcoin/pull/23280 | core#23280]]: https://github.com/bitcoin/bitcoin/pull/23280/commits/ae9121f958a4124ea6238cad0c3f2acb8b9eb4bb# Depends on D12556.

``` This allows us to separate the initialization code from translations and error reporting. This change changes the caller semantics of LoadChainstate quitendrastically. To see that this change doesn't change behaviour, observe that: 1. Prior to this change, LoadChainstate returned false only in the "bad genesis block" failure case (by returning InitError()), indicating that the caller should immediately bail. After this change, the corresponding ERROR_BAD_GENESIS_BLOCK handler in src/init.cpp maintains behavioue by also bailing immediately. 2. The failed_* temporary booleans were only used to break out of the outer do/while(false) loop. They can therefore be safely removed. ``` Partial backport of [[https://github.com/bitcoin/bitcoin/pull/23280 | core#23280:]]: https://github.com/bitcoin/bitcoin/pull/23280/commits/ae9121f958a4124ea6238cad0c3f2acb8b9eb4bb# Depends on D12556.