Change Details

Diff D17640 introduced a subtle and undetected bug: It ran the tx size estimation within tests using real signatures instead of EccDummy. However, the "leftover" calculation always uses EccDummy. Since Schnorr signatures are fixed length, this was undetected. But for ECDSA signatures, the tests would fail, as "real" signatures can have a different length than dummy signatures used for leftover calculation. This is not an issue on Bitcoin ABC, but on doged, these tests fail. This diff restores the old behavoir, which is also more robust and more correct, and makes tests compatible with doged.

Diff D17640 introduced a subtle and undetected bug: It ran the tx size estimation within tests using real signatures instead of EccDummy. However, the "leftover" calculation always uses EccDummy. Since Schnorr signatures are fixed length, this was undetected. But for ECDSA signatures, the tests fail, as "real" signatures can have a different length than dummy signatures used for leftover calculation. This diff restores the old behavoir, and additionally tests size estimation using ECDSA signatures to ensure we cover behavoir this in our tests.

Diff D17640 introduced a subtle and undetected bug: It ran the tx size estimation within tests using real signatures instead of EccDummy. However, the "leftover" calculation always uses EccDummy. Since Schnorr signatures are fixed length, this was undetected. But for ECDSA signatures, the tests would fail, as "real" signatures can have a different length than dummy signatures used for leftover calculation. This is not an issue on Bitcoin ABC, but on doged, these tests fail. This diff restores the old behavoir, which is also more robust and more correct, and makes tests compatible with dogedadditionally tests size estimation using ECDSA signatures to ensure we cover behavoir this in our tests.