Change Details

This accessor does more that its name implies, as it attempts to create a peer if it doesn't exists which males the API confusing. This was intended to be a test only method, but it sneaked outside of its original scope. This diff simplifies `getPeerId()` by making it a simple accessor, and use `registerProof()` instead when this is the expected behavior. Ref T1854.

This accessor does more that its name implies, as it attempts to create a peer if it doesn't exists which makes the API confusing. This was intended to be a test only method, but it sneaked outside of its original scope. This diff removes `getPeerId()` and use `registerProof()` instead when this is the expected behavior. The original behavior is now enforced as test-only by moving it to the friend test class. Ref T1854.

This accessor does more that its name implies, as it attempts to create a peer if it doesn't exists which malmakes the API confusing. This was intended to be a test only method, but it sneaked outside of its original scope. This diff simplifiremoves `getPeerId()` by making it a simple accessor,and use `registerProof()` instead when this is the expected behavior. and use `registerProof()` instead when this isThe original behavior is now enforced as test-only by moving it to the expected behaviorfriend test class. Ref T1854.