Change Details

This switches the Schnorr test to not rely on comptool (which is deprecated), and takes advantage of the newly backported P2PDataStore features. `bootstrap_p2p` and `reconnect_p2p` are borrowed from p2p_invalid_tx.py (introduced D3527). I've also taken some liberties to redo the setup process and the block-building process; hopefully it is clearer. The new setup doesn't rely on `time.time()` and doesn't care whether `setup_clean_chain` is True or False. Note to reviewers: I hope this can be a good template for other functional tests, including activations, so also review this in a general context where it will serve as an example to other tests.

This switches the Schnorr test to not rely on comptool (which is deprecated), and takes advantage of the newly backported P2PDataStore features. `bootstrap_p2p` and `reconnect_p2p` are borrowed from p2p_invalid_tx.py (introduced D3527). This nicely removes the need to rely on `-whitelist` for rejected blocks, instead we can send them and get "banned" (disconnected), and then reconnect. I've also added some logging to the test, while I'm at it.

This switches the Schnorr test to not rely on comptool (which is deprecated), and takes advantage of the newly backported P2PDataStore features. `bootstrap_p2p` and `reconnect_p2p` are borrowed from p2p_invalid_tx.py (introduced D3527). I've also taken some libertiesThis nicely removes the need to redo the setup process and thely on `-whitelist` for rejected block-building process;s, hopefully it is clearer.instead we can send them and get "banned" (disconnected), The new setup doesn'tand rely on `time.time()` and doesn't care whether `setup_clean_chain` is True or Falsethen reconnect. Note to reviewers: I hope this can be a good template for other functional tests, including activationsI've also added some logging to the test, so also review this in a general context where it will serve as an example to other testswhile I'm at it.