Change Details

Make the avalanche processor a unique ptr managed by the node context. Pass it via a reference to most of the code (net, net_processing, mining, RPC, ...), and via a raw pointer to the validation/chainstate code so that it remains an optional component and does not add more avalanche processor dependencies to bitcoin-chainstate. The `Chainstate` code will have access to the avalanche processor shortly after the chainstate is loaded, but not immediately (this preserves the previous behavior). A change in behavior introduced by this diff is that now only the active chainstate will use avalanche, not the background IBD chainstate in case a assumeutxo snapshot is loaded. I don't avalanche will ever be needed for background IBD, we can probabably assume that all blocks leading up to the snapshot base are already final. The only real complex change here is in processor_tests, because that test builds a fixture that has a processor, but some of the subtests then redeclare that processor (so it is affected by changes in ArgsManager, and it affects the `m_node.peermanager` component). Depends on D16223

Make the avalanche processor a unique ptr managed by the node context. Other components (net processing, validation, mining) keep a pointer to the processor. This allows us to keep running unit tests without initializing a processor for now. A potential change in behavior introduced by this diff is that now only the active chainstate will have a pointer to avalanche defined, not the background IBD chainstate in case a assumeutxo snapshot is loaded. I don't think avalanche will ever be needed for background IBD, we can probably assume that all blocks leading up to the snapshot base are already final. Note that for now the active chainstate is always defined immediately after init, and does not change during the lifetime of the bitcoind process. This will change in the future when the `loadtxoutset` RPC will be introduced and will change the active chainstate dynamically. We will need to add a `chainman.SetAvalancheProcessor(...)` somewhere when this time comes Depends on D16223

Make the avalanche processor a unique ptr managed by the node context. Pass it via a reference to most of the code Other components (net, net_ processing, mininging, RPCvalidation, ...),mining) keep a pointer to the processor. and via a raw pointer to the validation/chainstate code so that it remains an optional component and does not add more avalanche processor dependencies to bitcoin-chainstate. The `Chainstate` code will have access to the avalanche processor shortly after the chainstate is loadThis allows us to keep running unit tests without initializing a processor for now. A potential change in behavior introduced by this diff is that now only the active chainstate will have a pointer to avalanche defined, but not immediately (this preserves the previous behavior)not the background IBD chainstate in case a assumeutxo snapshot is loaded. A change in behavior introduced by this diff is that now only the active chainstate will use avalancheI don't think avalanche will ever be needed for background IBD, not the background IBD chainstate in case a assumeutxo snapshot is loaded. I don't avalanche will ever be needed for background IBDwe can probably assume that all blocks leading up to the snapshot base are already final. Note that for now the active chainstate is always defined immediately after init, we can probabably assume that all blocks leading up to the snapshot base are already final. The only real complex change here is in processor_tests,and does not change during the lifetime of the bitcoind process. because that test builds a fixturThis will change in the future when the `loadtxoutset` RPC will be introduced and will change that has a processor,e active chainstate dynamically. but some of the subtests then redeclare that processor (so it is affected by changes in ArgsManager, and it affects the `m_node.peermanager` component).We will need to add a `chainman.SetAvalancheProcessor(...)` somewhere when this time comes Depends on D16223