Change Details

When avalanche is not initialized we should not pass it as a net events interface to `CConnman::m_msgproc` as the codebase never checks for nullptr before dereferencing these interfaces.

When avalanche is not initialized we should not pass it as a net events interface to `CConnman::m_msgproc` as the codebase never checks for nullptr before dereferencing these interfaces. The `node.avalanche->startEventLoop(*node.scheduler)` obviously needs to be gated as well, or the node will not even start with `-avalanche=0` Add a functional test that starts the node with `avalanche=0` to catch these bugs. The first bug is caught by `self.restart_node(1, extra_args=["-avalanche=0"])`, the second bug related to net interface is caught by the block synchronization test.

When avalanche is not initialized we should not pass it as a net events interface to `CConnman::m_msgproc` as the codebase never checks for nullptr before dereferencing these interfaces. The `node.avalanche->startEventLoop(*node.scheduler)` obviously needs to be gated as well, or the node will not even start with `-avalanche=0` Add a functional test that starts the node with `avalanche=0` to catch these bugs. The first bug is caught by `self.restart_node(1, extra_args=["-avalanche=0"])`, the second bug related to net interface is caught by the block synchronization test.