Change Details

error(...) has many issues: - It is often used in the context of return error(...), implying that it has a "fancy" type, creating confusion with util::Result/Error - -logsourcelocations does not work with it, because it will pretend the error happened inside of logging.h - The log line contains ERROR: , as opposed to [error], like for other errors logged with LogError. Fix all issues by removing it. This is a backport of core#29236

error(...) has many issues: - It is often used in the context of return error(...), implying that it has a "fancy" type, creating confusion with util::Result/Error - -logsourcelocations does not work with it, because it will pretend the error happened inside of logging.h - The log line contains ERROR: , as opposed to [error], like for other errors logged with LogError. Fix all issues by removing it. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/29236 | core#29236]]

error(...) has many issues: - It is often used in the context of return error(...), implying that it has a "fancy" type, creating confusion with util::Result/Error - -logsourcelocations does not work with it, because it will pretend the error happened inside of logging.h - The log line contains ERROR: , as opposed to [error], like for other errors logged with LogError. Fix all issues by removing it. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/29236 | core#29236]]