Change Details

The banscore was always 0 or 100 (which causes disconnection), so we can simplify the logic by using a boolean. Also don't initialize the bool in net_processing, ensure that the function always sets it. This makes the code a bit easier to reason about, compared to the previous version when the banscore was sometimes set in net_processing and never overwritten, sometimes overwritten with a different value, and sometimes overwritten with the same value.

The banscore was always 0 or 100 (which causes disconnection), so we can simplify the logic by using a boolean without changing behavior. Also don't initialize the bool in net_processing, ensure that the function always sets it. This makes the code a bit easier to reason about, compared to the previous version when the banscore was sometimes set in net_processing and never overwritten, sometimes overwritten with a different value, and sometimes overwritten with the same value.

The banscore was always 0 or 100 (which causes disconnection), so we can simplify the logic by using a boolean without changing behavior. Also don't initialize the bool in net_processing, ensure that the function always sets it. This makes the code a bit easier to reason about, compared to the previous version when the banscore was sometimes set in net_processing and never overwritten, sometimes overwritten with a different value, and sometimes overwritten with the same value.