Change Details

Seems odd to have an option for non-deterministic tests when the goal should be for all tests to be deterministic. Can be reviewed with `--ignore-all-space`. This concludes backport of core#21592 https://github.com/bitcoin/bitcoin/pull/21592/commits/fa6183d7761eef8bb815aa888f0396e92e275f05 Notes: - finalization_tests assumed that the mocktime was later than the node startup time, because the finalization delay is check both against the startup time and current time - the 2 avalanche tests assumed that the blocks mined by the test setup were all mined with the same block time, so using the MTP of the tip as base time for following blocks made sense. Now the MTP of the base block is 6 seconds behind the tip, now it makes sense to use the time of the tip so as not to break the assumption that block time is always increasing and the MTP of the final tip will actually expire the proof.

Seems odd to have an option for non-deterministic tests when the goal should be for all tests to be deterministic. Can be reviewed with `--ignore-all-space`. This concludes backport of [[https://github.com/bitcoin/bitcoin/pull/21592 | core#21592]] https://github.com/bitcoin/bitcoin/pull/21592/commits/fa6183d7761eef8bb815aa888f0396e92e275f05 Notes: - finalization_tests assumed that the mocktime was later than the node startup time, because the finalization delay is check both against the startup time and current time - the 2 avalanche tests assumed that the blocks mined by the test setup were all mined with the same block time, so using the MTP of the tip as base time for following blocks made sense. Now the MTP of the base block is 6 seconds behind the tip, now it makes sense to use the time of the tip so as not to break the assumption that block time is always increasing and the MTP of the final tip will actually expire the proof.

Seems odd to have an option for non-deterministic tests when the goal should be for all tests to be deterministic. Can be reviewed with `--ignore-all-space`. This concludes backport of [[https://github.com/bitcoin/bitcoin/pull/21592 | core#21592]] https://github.com/bitcoin/bitcoin/pull/21592/commits/fa6183d7761eef8bb815aa888f0396e92e275f05 Notes: - finalization_tests assumed that the mocktime was later than the node startup time, because the finalization delay is check both against the startup time and current time - the 2 avalanche tests assumed that the blocks mined by the test setup were all mined with the same block time, so using the MTP of the tip as base time for following blocks made sense. Now the MTP of the base block is 6 seconds behind the tip, now it makes sense to use the time of the tip so as not to break the assumption that block time is always increasing and the MTP of the final tip will actually expire the proof.