Change Details

ninja ./bitcoind ./bitcoin-cli help <any rpc> Verify help text is similar to pre-patch Change rpc/blockchain.cpp:287 from {"blockhash", RPCArg::Type::STR_HEX, /* opt */ false, to {"timeout", RPCArg::Type::STR_HEX, /* opt */ false, ninja ./bitcoind ./bitcoin-cli help verifychain Confirm bitcoind crashes with the following error: bitcoind: ../src/rpc/util.cpp:263: RPCHelpMan::RPCHelpMan(const string&, const string&, const std::vector<RPCArg>&): Assertion `named_args.insert(arg.m_name).second' failed. Aborted

ninja ./bitcoind mkdir internalerror ./bitcoin-cli help > RPCs ./getrpchelps.sh RPCs internalerror grep -rnI Internal\ error internalerror The `grep` command's output should be empty. Script: {F4246191} Change the name of the second argument of an RPC to be the same as the first i.e. `waitforblock` in rpc/blockchain.cpp from {"blockhash", RPCArg::Type::STR_HEX, /* opt */ false, to {"timeout", RPCArg::Type::STR_HEX, /* opt */ false, ninja ./bitcoind ./bitcoin-cli help waitforblock Confirm bitcoind does not crash and that bitcoin-cli outputs the following error: Internal bug detected: 'named_args.insert(arg.m_name).second' You may report this issue here: https://github.com/Bitcoin-ABC/bitcoin-abc/issues

ninja ./bitcoind ./bitcoin-cli help <any rpc>mkdir internalerror Verify help text is similar to pre-patch ./bitcoin-cli help > RPCs ./getrpchelps.sh RPCs internalerror grep -rnI Internal\ error internalerror The `grep` command's output should be empty. Change rpc/blockchain.cpp:287Script: {F4246191} Change the name of the second argument of an RPC to be the same as the first i.e. `waitforblock` in rpc/blockchain.cpp from {"blockhash", RPCArg::Type::STR_HEX, /* opt */ false, to {"timeout", RPCArg::Type::STR_HEX, /* opt */ false, ninja ./bitcoind ./bitcoin-cli help verifychainwaitforblock Confirm bitcoind does not crashes withh and that bitcoin-cli outputs the following error:r: Internal bug detected: 'named_args.insert(arg.m_name).second' bitcoind: ../src/rpc/util.cpp:263: RPCHelpMan::RPCHelpMan(const string&, const string&, const std::vector<RPCArg>&): Assertion `named_args.insert(arg.m_name).second' failed.You may report this issue here: https://github.com/Bitcoin-ABC/bitcoin-abc/issues Aborted