Change Details

``` make check ninja check ninja check-devtools # run bitcoind for both mainnet and testnet bitcoind bitcoind --testnet # show help message generate_bestchainparams.py generate_bestchainparams.py -h generate_bestchainparams.py --help # show error generate_bestchainparams.py -t <some invalid hash> generate_bestchainparams.py -m <some invalid hash> generate_bestchainparams.py --cli <some invalid path> # generates expected output generate_bestchainparams.py --cli <path to bitcoin-cli> generate_bestchainparams.py --cli <path to bitcoin-cli> -m <some mainnet block hash or height> generate_bestchainparams.py --cli <path to bitcoin-cli> -t <some testnet block hash or height> generate_bestchainparams.py --cli <path to bitcoin-cli> -m <valid mainnet block> -t <valid testnet block> # saves output to file generate_bestchainparams.py --cli <path to bitcoin-cli> -m 588857 -t 1309000 > ../../src/chainparamsbestchain.h ```

``` make check ninja check ninja check-devtools show help message generate_chainparams_constants.py --help errors due to missing config/config params generate_chainparams_constants.py -c blah generate_chainparams_constants.py vim ~/.bitcoin/bitcoin.conf # add rpcuser generate_chainparams_constants.py vim ~/.bitcoin/bitcoin.conf # add rpcpassword run bitcoind for both mainnet and testnet bitcoind bitcoind --testnet generates mainnet output generate_chainparams_constants.py generates testnet output generate_chainparams_constants.py -a "127.0.0.1:18332" saves aggregated output to file generate_chainparams_constants.py -o ../../../src/chainparamsconstants.h generate_chainparams_constants.py -a "127.0.0.1:18332" -o ../../../src/chainparamsconstants.h saves aggregated output to file (generates the header you find in this diff) generate_chainparams_constants.py -o ../../../src/chainparamsconstants.h -b 000000000000000004425aeeb553758650da20031643fbfff0f53ac5dd1b39c3 generate_chainparams_constants.py -a "127.0.0.1:18332" -o ../../../src/chainparamsconstants.h -b 000000000000037b3419370d2306ada6b4f30ac9f01a1bec513eef69b8cd4eab ```

``` make check ninja check ninja check-devtools # run bitcoind for both mainnet and testnetshow help message bitcoind bitcoind --testnetgenerate_chainparams_constants.py --help # show help messageerrors due to missing config/config params generate_bestchainparams_constants.py -c blah generate_bestchainparams.py -hs_constants.py generate_bestchainparams.py --help # show errorvim ~/.bitcoin/bitcoin.conf # add rpcuser generate_bestchainparams.py -t <some invalid hash>_constants.py generate_bestchainparams.py -m <some invalid hash>vim ~/.bitcoin/bitcoin.conf # add rpcpassword run bitcoind for both mainnet and testnet generate_bestchainparams.py --cli <some invalid path>bitcoind bitcoind --testnet # generates expectedmainnet output generate_bestchainparams_constants.py --cli <path to bitcoin-cli> generates testnet output generate_bestchainparams.py --cli <path to bitcoin-cli> -m <some mainnet block hash or height>_constants.py -a "127.0.0.1:18332" saves aggregated output to file generate_bestchainparams.py --cli <path to bitcoin-cli> -t <some testnet block hash or height>_constants.py -o ../../../src/chainparamsconstants.h generate_bestchainparams.py --cli <path to bitcoin-cli> -m <valid mainnet block> -t <valid testnet block>_constants.py -a "127.0.0.1:18332" -o ../../../src/chainparamsconstants.h # saves output to filesaves aggregated output to file (generates the header you find in this diff) generate_chainparams_constants.py -o ../../../src/chainparamsconstants.h -b 000000000000000004425aeeb553758650da20031643fbfff0f53ac5dd1b39c3 generate_bestchainparams.py --cli <path to bitcoin-cli> -m 588857 -t 1309000 > _constants.py -a "127.0.0.1:18332" -o ../../../src/chainparamsbestchain.hconstants.h -b 000000000000037b3419370d2306ada6b4f30ac9f01a1bec513eef69b8cd4eab ```