Change Details

This is part 2 of 5 of the backport of Core PR17513 Depends on [[https://reviews.bitcoinabc.org/D7572 | D7572]] Note: Unlike the [[https://github.com/bitcoin/bitcoin/pull/17513/commits/a53e9895db7617c879858ca27e38e6aaf35f6075 | original commit]], this diff does not remove a circular dependency because of differences in the codebase (#IFDEF ENABLE_BIP70)

This is part 2 of 4 of the backport of Core PR17513. It includes commits [[https://github.com/bitcoin/bitcoin/pull/17513/commits/a53e9895db7617c879858ca27e38e6aaf35f6075 | a53e989]] and [[https://github.com/bitcoin/bitcoin/pull/17513/commits/567cb44eb95785c8df93a3844207d17f4c390372 | 567cb44 ]]. Additional changes were necessary on our side to remove the circular dependency because of codebase divergence related to BIP70 support. The PaymentServer::fetchPaymentACK method was changed to use a interfaces::Wallet& instead of a WalletModel*. Depends on [[https://reviews.bitcoinabc.org/D7572 | D7572]]

This is part 2 of 54 of the backport of Core PR17513. It includes commits [[https://github.com/bitcoin/bitcoin/pull/17513/commits/a53e9895db7617c879858ca27e38e6aaf35f6075 | a53e989]] and [[https://github.com/bitcoin/bitcoin/pull/17513/commits/567cb44eb95785c8df93a3844207d17f4c390372 | 567cb44 ]]. Additional changes were necessary on our side to remove the circular dependency because of codebase divergence related to BIP70 support. The PaymentServer::fetchPaymentACK method was changed to use a interfaces::Wallet& instead of a WalletModel*. Depends on [[https://reviews.bitcoinabc.org/D7572 | D7572]] Note: Unlike the [[https://github.com/bitcoin/bitcoin/pull/17513/commits/a53e9895db7617c879858ca27e38e6aaf35f6075 | original commit]], this diff does not remove a circular dependency because of differences in the codebase (#IFDEF ENABLE_BIP70)