Change Details

User-facing error messages should not leak internal implementation details like function names. Update the MEMPOOL_REJECTED error string from "Transaction rejected by AcceptToMemoryPool" to the more generic "Transaction rejected by mempool". Also update the MEMPOOL_ERROR error message from "AcceptToMemoryPool failed" to the more precise "Mempool internal error" since this error indicates and internal (e.g. logic/hardware/etc) failure, and not a transaction rejection. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/23173 | core#23173]] https://github.com/bitcoin/bitcoin/pull/23173/commits/36167faea92c97ddea7403280a5074073c8e5f90

User-facing error messages should not leak internal implementation details like function names. Update the MEMPOOL_REJECTED error string from "Transaction rejected by AcceptToMemoryPool" to the more generic "Transaction rejected by mempool". Also update the MEMPOOL_ERROR error message from "AcceptToMemoryPool failed" to the more precise "Mempool internal error" since this error indicates and internal (e.g. logic/hardware/etc) failure, and not a transaction rejection. These error messages are not covered by tests because they are overwritten with more precise error messages from the ATMP validation state in `sendrawtransaction`. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/23173 | core#23173]] https://github.com/bitcoin/bitcoin/pull/23173/commits/36167faea92c97ddea7403280a5074073c8e5f90

User-facing error messages should not leak internal implementation details like function names. Update the MEMPOOL_REJECTED error string from "Transaction rejected by AcceptToMemoryPool" to the more generic "Transaction rejected by mempool". Also update the MEMPOOL_ERROR error message from "AcceptToMemoryPool failed" to the more precise "Mempool internal error" since this error indicates and internal (e.g. logic/hardware/etc) failure, and not a transaction rejection. These error messages are not covered by tests because they are overwritten with more precise error messages from the ATMP validation state in `sendrawtransaction`. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/23173 | core#23173]] https://github.com/bitcoin/bitcoin/pull/23173/commits/36167faea92c97ddea7403280a5074073c8e5f90