Change Details

Currently, Chronik crashes when reorging a block with conflicting chained transactions, because the order of removal of transactions in the node is not in reverse topological order.

Currently, Chronik crashes when disconnecting a block with children in the mempool, because the order of removal of transactions in the node is not in reverse topological order. This problem was introduced in eec0e0c7b0f08e9a388063fc6028b95a9c56d63c, specifically where `TransactionRemovedFromMempool` is called in topological order (i.e. parents first), but should've been called in reverse-topological order (i.e. children first), which this diff fixes. Chronik depends on the removal to happen in reverse-topological order (i.e. children first), otherwise, it might remove UTXOs from the index before they're added, crashing the node. This is what happened a few times on both NNG and in-node Chronik.

Currently, Chronik crashes when reorgdisconnecting a block with conflicting chained transactionshildren in the mempool, because the order of removal of transactions in the node is not in reverse topological order. This problem was introduced in eec0e0c7b0f08e9a388063fc6028b95a9c56d63c, specifically where `TransactionRemovedFromMempool` is called in topological order (i.e. parents first), but should've been called in reverse-topological order (i.e. children first), which this diff fixes. Chronik depends on the removal to happen in reverse-topological order (i.e. children first), otherwise, it might remove UTXOs from the index before they're added, crashing the node. This is what happened a few times on both NNG and in-node Chronik.