Change Details

``` This simple refactoring PR changes the interface for the SipHash arbitrary-data Write method to take a Span<unsigned char> instead of having to pass data and length. (Span<std::byte> seems to be more modern, but vectors of unsigned char are still used prety much everywhere where SipHash is called, and I didn't find it very appealing having to clutter the code with Make(Writable)ByteSpan helpers). ``` Backport of core#28085.

``` This simple refactoring PR changes the interface for the SipHash arbitrary-data Write method to take a Span<unsigned char> instead of having to pass data and length. (Span<std::byte> seems to be more modern, but vectors of unsigned char are still used prety much everywhere where SipHash is called, and I didn't find it very appealing having to clutter the code with Make(Writable)ByteSpan helpers). ``` Backport of [[https://github.com/bitcoin/bitcoin/pull/28085 | core#28085]].

``` This simple refactoring PR changes the interface for the SipHash arbitrary-data Write method to take a Span<unsigned char> instead of having to pass data and length. (Span<std::byte> seems to be more modern, but vectors of unsigned char are still used prety much everywhere where SipHash is called, and I didn't find it very appealing having to clutter the code with Make(Writable)ByteSpan helpers). ``` Backport of [[https://github.com/bitcoin/bitcoin/pull/28085 | core#28085]].