Change Details

The seeder currently only bans misbehaving nodes. With D5380, this change will allow the seeder to eventually ban a node on the wrong chain. The previous issue noted in D5380 was that the seeder could not differentiate between an IBD node and a node on the wrong chain. An IBD node should not be banned while the other type should be banned. Given enough time, a good node should finish its IBD and pass TestNode(). On the other hand, a node on the wrong chain very likely won't change become good later on. Depends on D5380, D5880 Review note: The seeder is currently unable to reach the unbanning logic while it is running. In order for a node to be unbanned, the seeder must be restarted with the `--wipeban` option enabled. As such banned nodes are effectively banned forever.

The seeder currently only bans misbehaving nodes. With D5380, this change will allow the seeder to eventually ban a node on the wrong chain. The previous issue noted in D5380 was that the seeder could not differentiate between an IBD node and a node on the wrong chain. An IBD node should not be banned while the other type should be banned. Given enough time, a good node should finish its IBD and pass TestNode(). On the other hand, a node on the wrong chain very likely won't change become good later on. Depends on D5380 and D5800 Review note: The seeder is currently unable to reach the unbanning logic while it is running. In order for a node to be unbanned, the seeder must be restarted with the `--wipeban` option enabled. As such banned nodes are effectively banned forever.

The seeder currently only bans misbehaving nodes. With D5380, this change will allow the seeder to eventually ban a node on the wrong chain. The previous issue noted in D5380 was that the seeder could not differentiate between an IBD node and a node on the wrong chain. An IBD node should not be banned while the other type should be banned. Given enough time, a good node should finish its IBD and pass TestNode(). On the other hand, a node on the wrong chain very likely won't change become good later on. Depends on D5380, and D588000 Review note: The seeder is currently unable to reach the unbanning logic while it is running. In order for a node to be unbanned, the seeder must be restarted with the `--wipeban` option enabled. As such banned nodes are effectively banned forever.