Change Details

The RandomOrphan function and the function ecdsa_signature_parse_der_lax in pubkey.cpp were causing non-deterministic test coverage. Force seed in the beginning of the test to make it deterministic. The seed is selected carefully so that all branches of the function ecdsa_signature_parse_der_lax are executed. Prior to this fix, the test was exhibiting non-deterministic coverage since none of the ECDSA signatures that were generated during the test had leading zeroes in either R, S, or both, resulting in some branches of said function not being executed. The seed ensures that both conditions are hit. Removed denialofservice_tests test entry from the list of non-deterministic tests in the coverage script. This is a backport of [[https://github.com/bitcoin/bitcoin/pull/16878 | core#16878]]

> The RandomOrphan function and the function ecdsa_signature_parse_der_lax > in pubkey.cpp were causing non-deterministic test coverage. > > Force seed in the beginning of the test to make it deterministic. > The seed is selected carefully so that all branches of the function > ecdsa_signature_parse_der_lax are executed. Prior to this fix, the test > was exhibiting non-deterministic coverage since none of the ECDSA > signatures that were generated during the test had leading zeroes in > either R, S, or both, resulting in some branches of said function not > being executed. The seed ensures that both conditions are hit. > This is a backport of [[https://github.com/bitcoin/bitcoin/pull/16878 | core#16878]]

> The RandomOrphan function and the function ecdsa_signature_parse_der_lax > in pubkey.cpp were causing non-deterministic test coverage. Force seed in the beginning of the test to make it deterministic. Th> > Force seed is selected carefully so that all branches of the functionn the beginning of the test to make it deterministic. ecdsa_signature_parse_der_lax are executed. Prior to this fix,> The seed is selected carefully so that all branches of the testfunction was exhibiting non-deterministic coverage since none of> ecdsa_signature_parse_der_lax are executed. Prior to this fix, the ECDSAtest signatures that were generated during the test had leading zeroes in> was exhibiting non-deterministic coverage since none of the ECDSA either R, S, or both, resulting in some branches of said function not> signatures that were generated during the test had leading zeroes in being executed.> either R, S, The seed ensures thator both conditions are hit. Removed denialofservice_tests test entry from the list of non-deterministic, resulting in some branches of said function not tests in the coverage script.> being executed. The seed ensures that both conditions are hit. > This is a backport of [[https://github.com/bitcoin/bitcoin/pull/16878 | core#16878]]