Change Details

PR17573: > Exposes a generic dead-simple "SeedEvent" interface, but currently just used for net messages. This PR caused CI failures on Windows, and was patched the day after its merge with the following: PR17670 > This moves events_hasher and events_mutex into RNGState() in random.cpp. This guarantees (through the existing GetRNGState() function) that the mutex is always created before any events are added, even when that happens inside global initializers. > > Fixes the issue reported here: [[https://github.com/bitcoin/bitcoin/pull/17573#issuecomment-561828251 | #17573 (comment)]], and includes the annotation from #17666). This is a backport of Core PR17573 and PR17670

[[https://github.com/bitcoin/bitcoin/pull/17573 | PR17573]]: > Exposes a generic dead-simple "SeedEvent" interface, but currently just used for net messages. This PR caused CI failures on Windows, and was patched the day after its merge with the following: [[https://github.com/bitcoin/bitcoin/pull/17670 | PR17670]] > This moves events_hasher and events_mutex into RNGState() in random.cpp. This guarantees (through the existing GetRNGState() function) that the mutex is always created before any events are added, even when that happens inside global initializers. > > Fixes the issue reported here: [[https://github.com/bitcoin/bitcoin/pull/17573#issuecomment-561828251 | #17573 (comment)]], and includes the annotation from #17666). This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/17573 | PR17573]] and [[https://github.com/bitcoin/bitcoin/pull/17670 | PR17670]]

[[https://github.com/bitcoin/bitcoin/pull/17573 | PR17573:]]: > Exposes a generic dead-simple "SeedEvent" interface, but currently just used for net messages. This PR caused CI failures on Windows, and was patched the day after its merge with the following: [[https://github.com/bitcoin/bitcoin/pull/17670 | PR17670]] > This moves events_hasher and events_mutex into RNGState() in random.cpp. This guarantees (through the existing GetRNGState() function) that the mutex is always created before any events are added, even when that happens inside global initializers. > > Fixes the issue reported here: [[https://github.com/bitcoin/bitcoin/pull/17573#issuecomment-561828251 | #17573 (comment)]], and includes the annotation from #17666). This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/17573 | PR17573]] and [[https://github.com/bitcoin/bitcoin/pull/17670 | PR17670]]