Change Details

Under certain circumstances the mempool will accept things, then not relay to any peers because the computed feerate is insufficient. Use the rounding-down behavior in GetFee to match both mempool acceptance and wallet logic, with minimal changes. Description of the issue in unmerged PR16500: > Currently fee filter and mempool/wallet will disagree on the sufficiency of minrelay fee transactions when the min relay rate is not % 1000 = 0. The wallet and mempool will allow a transaction to be created and entered into mempool, but then peers that have the same rate as a fee filter will not receive the transaction because of the undershooting that occurs in GetFee. This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16507 | PR16507]] Note: the second commit of the PR (make CFeeRate constructor explicit) seems to be already implemented on our side. This revision contains the first and third commit: https://github.com/bitcoin/bitcoin/pull/16507/commits/8e59af55aaf1b196575084bce2448af02d97d745 https://github.com/bitcoin/bitcoin/pull/16507/commits/eb7b78165966f2c79da71b993c4c4d793e37297f

Under certain circumstances the mempool will accept things, then not relay to any peers because the computed feerate is insufficient. Use the rounding-down behavior in GetFee to match both mempool acceptance and wallet logic, with minimal changes. Description of the issue: > Currently fee filter and mempool/wallet will disagree on the sufficiency of minrelay fee transactions when the min relay rate is not % 1000 = 0. The wallet and mempool will allow a transaction to be created and entered into mempool, but then peers that have the same rate as a fee filter will not receive the transaction because of the undershooting that occurs in GetFee. This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16507 | PR16507]] It includes following commits: https://github.com/bitcoin/bitcoin/pull/16507/commits/8e59af55aaf1b196575084bce2448af02d97d745 https://github.com/bitcoin/bitcoin/pull/16507/commits/eb7b78165966f2c79da71b993c4c4d793e37297f The [[https://github.com/bitcoin/bitcoin/pull/16507/commits/6a51f7951716d6d6fc0f9b56028f3a0dd02b61c8 | ignored commit]] is not relevant because the `CFeeRate` constructor is already explicit, in Bitcoin ABC. See D3313 for why this is the case.

Under certain circumstances the mempool will accept things, then not relay to any peers because the computed feerate is insufficient. Use the rounding-down behavior in GetFee to match both mempool acceptance and wallet logic, with minimal changes. Description of the issue in unmerged PR16500: > Currently fee filter and mempool/wallet will disagree on the sufficiency of minrelay fee transactions when the min relay rate is not % 1000 = 0. The wallet and mempool will allow a transaction to be created and entered into mempool, but then peers that have the same rate as a fee filter will not receive the transaction because of the undershooting that occurs in GetFee. This is a backport of Core [[https://github.com/bitcoin/bitcoin/pull/16507 | PR16507]] Note: the second commit of the PR (make CFeeRate constructor explicit) seems to be already implemented on our side. This revision contains the first and third commitIt includes following commits: https://github.com/bitcoin/bitcoin/pull/16507/commits/8e59af55aaf1b196575084bce2448af02d97d745 https://github.com/bitcoin/bitcoin/pull/16507/commits/eb7b78165966f2c79da71b993c4c4d793e37297f The [[https://github.com/bitcoin/bitcoin/pull/16507/commits/6a51f7951716d6d6fc0f9b56028f3a0dd02b61c8 | ignored commit]] is not relevant because the `CFeeRate` constructor is already explicit, in Bitcoin ABC. See D3313 for why this is the case.