Page MenuHomePhabricator

[Cashtab] Use latest chronik-client
ClosedPublic

Authored by bytesofman on Apr 28 2024, 21:08.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC91020cd9d366: [Cashtab] Use latest chronik-client
Summary

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
upgrade-cc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28781
Build 57100: Build Diffcashtab-tests
Build 57099: arc lint + arc unit

Event Timeline

emack requested changes to this revision.Apr 29 2024, 14:34
emack added a subscriber: emack.

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Right now references to timeFirstSeen seems to already assume it's a number rather than a string. Is it currently being converted to number somewhere?

image.png (167×618 px, 30 KB)

This revision now requires changes to proceed.Apr 29 2024, 14:34

Upgrade chronik-client so we get timeFirstSeen as a number and not a string

Right now references to timeFirstSeen seems to already assume it's a number rather than a string. Is it currently being converted to number somewhere?

image.png (167×618 px, 30 KB)

it just happens to be working now due to javascript accidents, i.e.

image.png (56×98 px, 1 KB)

but cashtab is right to assume it is a number. older version chronik-client is wrong in not deliving the number.

ok, but don't let Tobias see this

This revision is now accepted and ready to land.Apr 30 2024, 03:18
This revision was automatically updated to reflect the committed changes.