[Cashtab] Add support for Malaysian Ringgit
ClosedPublic
Actions

Authored by bytesofman on Mon, Apr 29, 17:12.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC15b0788f25c2: [Cashtab] Add support for Malaysian Ringgit

Summary

Add support for setting foreign currency to MYR

T3562

Test Plan

Proofread to confirm correct ticker and symbol. npm start and confirm price makes sense.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, Apr 29, 17:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 29, 17:12

bytesofman published this revision for review.Mon, Apr 29, 17:13

bytesofman edited the summary of this revision. (Show Details)

bytesofman edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B28793: Diff 47480.Mon, Apr 29, 17:16

Coingecko feed on google vs cashtab. Is this delta within an acceptable threshold?

This revision now requires changes to proceed.Tue, Apr 30, 04:04

In D16076#363948, @emack wrote:

Coingecko feed on google vs cashtab. Is this delta within an acceptable threshold?

We aren't in the business of adjudicating proper forex arbitrage.

Ultimately, we are trusting coingecko to provide accurate forex. Cashtab is designed to disable fiat currency features if the API is down.

In this case, coingecko probably has better forex-specific crypto data than google. google results are basically garbage these days. would be classic google if those prices came from coingecko but a team of 30 people spent 6 months optimizing the feature so that it's providing a result that has been cached for 48 hours.

emack accepted this revision.Tue, Apr 30, 13:45

This revision is now accepted and ready to land.Tue, Apr 30, 13:45

Closed by commit rABC15b0788f25c2: [Cashtab] Add support for Malaysian Ringgit (authored by bytesofman). · Explain WhyTue, Apr 30, 13:55

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC15b0788f25c2: [Cashtab] Add support for Malaysian Ringgit.