Page MenuHomePhabricator
People Fabien

Fabien (Fabien)
UserAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Oct 7 2018, 09:05 (292 w, 6 d)
Roles
Administrator
Slack Username
Fabien

Recent Activity
View All

Yesterday

Fabien accepted D16174: Add simulation-based CCoinsViewCache fuzzer.
Fri, May 17, 12:16
Fabien accepted D16180: util: improve streams.h:FindByte() performance.
Fri, May 17, 09:42
Fabien accepted D16179: [bench] add streams findbyte.
Fri, May 17, 09:37
Fabien requested changes to D16174: Add simulation-based CCoinsViewCache fuzzer.
Fri, May 17, 09:36

Thu, May 16

Fabien closed D16173: Replace May 15, 2024 activation with Nov 15.
Thu, May 16, 10:28
Fabien committed rABC4faa4923ec82: Replace May 15, 2024 activation with Nov 15 (authored by Fabien).
Replace May 15, 2024 activation with Nov 15
Thu, May 16, 10:28
Fabien accepted D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.
Thu, May 16, 10:27
Fabien requested review of D16173: Replace May 15, 2024 activation with Nov 15.
Thu, May 16, 09:26
Fabien requested changes to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

now you know :)

Thu, May 16, 08:19
Fabien accepted D16162: coins: add Sync() method to allow flush without cacheCoins drop.
Thu, May 16, 08:11
Fabien accepted D16161: test: refactor: clarify the coins simulation.
Thu, May 16, 07:59
Fabien added a comment to D16156: test: Create InsecureRandMoneyAmount() helper, de-duplicate add_coin methods.

@bot build-linux32 build-linux-arm build-linux-aarch64

Thu, May 16, 07:57

Wed, May 15

Fabien accepted D16169: [token server + chronik-client + mock-chronik-client + ecash-herald] Remove legacy Dockerfile(s).
Wed, May 15, 19:07
Fabien accepted D16170: [ecash-lib] Update CI to also build ecashaddrjs now that chronik-client pulls this from the monorepo.
Wed, May 15, 18:56
Fabien closed D16168: Add a checkpoint after the May 15 2024 upgrade.
Wed, May 15, 14:58
Fabien committed rABC9b6e6fe6eb5f: Add a checkpoint after the May 15 2024 upgrade (authored by Fabien).
Add a checkpoint after the May 15 2024 upgrade
Wed, May 15, 14:58
Fabien accepted D16167: [e.cash] Remove unused upgrade countdown.
Wed, May 15, 14:43
teamcity awarded D16168: Add a checkpoint after the May 15 2024 upgrade a Haypence token.
Wed, May 15, 14:38
Fabien added a comment to D16168: Add a checkpoint after the May 15 2024 upgrade.

@bot build-ibd

Wed, May 15, 14:38
Fabien updated the diff for D16168: Add a checkpoint after the May 15 2024 upgrade.

Fix testnet height, hash was correct

Wed, May 15, 14:28
Fabien requested review of D16168: Add a checkpoint after the May 15 2024 upgrade.
Wed, May 15, 13:59
Fabien accepted D16166: [e.cash] Mark upgrade complete in navbar.
Wed, May 15, 13:32
Fabien accepted D16164: [ecash-herald] Finish deprecating unused API.
Wed, May 15, 13:30
Fabien closed D16165: [website] Show upgrade completed.
Wed, May 15, 13:29
Fabien committed rABCWEBfc5cc5cd33f0: [website] Show upgrade completed (authored by Fabien).
[website] Show upgrade completed
Wed, May 15, 13:29
Fabien requested review of D16165: [website] Show upgrade completed.
Wed, May 15, 13:25
Fabien accepted D16163: [e.cash] Update upgrade page for completed upgrade - 2024-05-15.
Wed, May 15, 13:11
Fabien accepted D16155: Move random test util code from setup_common to random.
Wed, May 15, 11:46
Fabien accepted D16154: refactor: Move fs.* to util/fs.*.
Wed, May 15, 11:39
Fabien accepted D16153: Add missing includes in assumptions.h and chainstate.cpp.
Wed, May 15, 07:44
Fabien accepted D16134: [chronik-client]+[alias-server]+[examples] Use local dep instead of npm.
Wed, May 15, 07:43

Tue, May 14

Fabien accepted D16152: misc fixes for file syncing.
Tue, May 14, 09:22
Fabien added a comment to D16152: misc fixes for file syncing.

@bot build-win64 build-linux64 build-osx

Tue, May 14, 08:12
Fabien accepted D16151: refactor: Extract util/fs_helpers from util/system.
Tue, May 14, 08:09
Fabien accepted D16150: refactor: Move error() from util/system.h to logging.h.
Tue, May 14, 08:04
Fabien accepted D16149: refactor: Extract util/exception from util/system.
Tue, May 14, 07:59
Fabien added inline comments to D16134: [chronik-client]+[alias-server]+[examples] Use local dep instead of npm.
Tue, May 14, 07:53
Fabien accepted D16138: [ecash-lib] Copy chronik to docker image.
Tue, May 14, 07:52
Fabien accepted D16135: [mock-chronik-client] use local deps.
Tue, May 14, 07:49

Mon, May 13

Fabien accepted D16145: refactor: Use move semantics in `CCheckQueue::Loop`.
Mon, May 13, 14:17
Fabien accepted D16148: clang-tidy: Fix modernize-use-default-member-init in `CScriptCheck`.
Mon, May 13, 14:00
Fabien accepted D16147: test: Default initialize `should_freeze` to `true`.
Mon, May 13, 14:00
Fabien accepted D16146: refactor: Drop no longer used `swap` member functions.
Mon, May 13, 13:59
Fabien added a comment to D16145: refactor: Use move semantics in `CCheckQueue::Loop`.

@bot build-asan

Mon, May 13, 13:59
Fabien accepted D16144: refactor: Use move semantics in `CCheckQueue::Add`.
Mon, May 13, 13:56
Fabien added a comment to D16144: refactor: Use move semantics in `CCheckQueue::Add`.

@bot build-asan

Mon, May 13, 13:48
Fabien accepted D16143: refactor: Avoid CScriptCheck::swap.

nvm it's in the stack

Mon, May 13, 13:47
Fabien added inline comments to D16143: refactor: Avoid CScriptCheck::swap.
Mon, May 13, 13:46
Fabien accepted D16142: [ecash-lib] Prepare ecash-lib for 0.1.0 release.
Mon, May 13, 13:39
Fabien accepted D16111: [ecash-lib] Add agora advertisements (ads) of offers for AgoraOneshot.
Mon, May 13, 13:36

Fri, May 10

Fabien requested changes to D16111: [ecash-lib] Add agora advertisements (ads) of offers for AgoraOneshot.
Fri, May 10, 07:49

Thu, May 9

Fabien added a comment to D16138: [ecash-lib] Copy chronik to docker image.

You had the same test plan in D16131, how come it didn't work ? Did you run your test plan ?

Thu, May 9, 18:53
Fabien closed D16136: [e.cash] Improve upgrade version wording.
Thu, May 9, 10:03
Fabien committed rABCc5bcb743624f: [e.cash] Improve upgrade version wording (authored by Fabien).
[e.cash] Improve upgrade version wording
Thu, May 9, 10:03
Fabien closed D16137: [nsis] Fix build error due to images not found.
Thu, May 9, 10:03
Fabien committed rABC1a331b6bc2b1: [nsis] Fix build error due to images not found (authored by Fabien).
[nsis] Fix build error due to images not found
Thu, May 9, 10:03
teamcity awarded D16137: [nsis] Fix build error due to images not found a Haypence token.
Thu, May 9, 09:26
Fabien added a comment to D16137: [nsis] Fix build error due to images not found.

@bot build-win64

Thu, May 9, 09:26
Fabien requested review of D16137: [nsis] Fix build error due to images not found.
Thu, May 9, 09:25
Fabien requested review of D16136: [e.cash] Improve upgrade version wording.
Thu, May 9, 09:24
Fabien requested changes to D16135: [mock-chronik-client] use local deps.

Please check the CI failures

Thu, May 9, 07:15
Fabien accepted D16133: [token-server] Use monorepo hosted dependencies instead of npm.
Thu, May 9, 07:15
Fabien accepted D16132: [ecash-herald] Use monorepo deps instead of npm.
Thu, May 9, 07:14
Fabien accepted D16131: [ecash-lib] Add another stage to handle rust reqs for ecash-wasm build.
Thu, May 9, 07:10

Wed, May 8

Fabien closed D16128: [doc] Minor improvments on the teamcity agent readme.
Wed, May 8, 13:21
Fabien committed rABC6ba7635cb3e7: [doc] Minor improvments on the teamcity agent readme (authored by Fabien).
[doc] Minor improvments on the teamcity agent readme
Wed, May 8, 13:21
Fabien closed D16127: [gitian] Remove gitian.
Wed, May 8, 13:21
Fabien committed rABC3facbd5e1414: [gitian] Remove gitian (authored by Fabien).
[gitian] Remove gitian
Wed, May 8, 13:21
Fabien accepted D16126: [ecash-lib] Dockerfile for CI publication to npm.
Wed, May 8, 13:09
Fabien accepted D16129: [Cashtab] Remove local legacy Dockerfile.
Wed, May 8, 13:07
Fabien accepted D16130: [Cashtab] Stop using Title for Tx History.
Wed, May 8, 12:59
Fabien accepted D16112: [Cashtab] Set rewards eligibility to true on countdown expiration.
Wed, May 8, 11:58
Fabien requested review of D16128: [doc] Minor improvments on the teamcity agent readme.
Wed, May 8, 09:57
Fabien updated the diff for D16127: [gitian] Remove gitian.

Rebase

Wed, May 8, 09:49
Fabien requested review of D16127: [gitian] Remove gitian.
Wed, May 8, 09:48
Fabien requested changes to D16126: [ecash-lib] Dockerfile for CI publication to npm.

file looks good except for the hash check which is useless

Wed, May 8, 08:12
Fabien accepted D16125: [Cashtab] Use monorepo dependencies instead of npm.

Very nice !

Wed, May 8, 08:06
Fabien requested changes to D16112: [Cashtab] Set rewards eligibility to true on countdown expiration.
Wed, May 8, 07:58
Fabien added inline comments to D16112: [Cashtab] Set rewards eligibility to true on countdown expiration.
Wed, May 8, 07:58

Tue, May 7

Fabien abandoned D14737: [CI] Temporarly disable building chronik for windows.
Tue, May 7, 18:02
Fabien accepted D16124: Split non/kernel chainparams.
Tue, May 7, 13:11
Fabien added a comment to D16119: [chronik-client] Support websocket subscriptions to tokenId.
In D16119#365095, @emack wrote:

Is there anywhere I can read up on the concept of an SLP Mint Vault referenced in this diff?

Tue, May 7, 09:36
Fabien accepted D16121: [explorer] Remove redundant token transaction info.

Just saw the dependency diff

Tue, May 7, 07:34
Fabien accepted D16120: [explorer] Differentiate between NFT group and child token types.
Tue, May 7, 07:33
Fabien requested changes to D16121: [explorer] Remove redundant token transaction info.
Tue, May 7, 07:33
Fabien added a comment to D16121: [explorer] Remove redundant token transaction info.

What about NFT ?

Tue, May 7, 07:32
Fabien accepted D16117: get config via ChainstateManager when it is reachable.
Tue, May 7, 07:30
Fabien requested changes to D16112: [Cashtab] Set rewards eligibility to true on countdown expiration.
Tue, May 7, 07:18
Fabien added inline comments to D16112: [Cashtab] Set rewards eligibility to true on countdown expiration.
Tue, May 7, 07:15

Mon, May 6

Fabien accepted D16116: [chronik] get consensus params via chainman.
Mon, May 6, 13:56
Fabien accepted D16114: Decouple ChainParams from ArgsManager, add factory functions.
Mon, May 6, 13:55
Fabien accepted D16118: [ecash-herald] back out avalanche peername.
Mon, May 6, 13:39
Fabien added inline comments to D16116: [chronik] get consensus params via chainman.
Mon, May 6, 12:40
Fabien requested changes to D16114: Decouple ChainParams from ArgsManager, add factory functions.
Mon, May 6, 12:22
Fabien accepted D16104: refactor: Move calculation logic out from `CheckSequenceLocksAtTip()`.
Mon, May 6, 11:33
Fabien closed D16115: [guix] Better SHA256SUMS format.
Mon, May 6, 11:31
Fabien committed rABCd6f7cb05623c: [guix] Better SHA256SUMS format (authored by Fabien).
[guix] Better SHA256SUMS format
Mon, May 6, 11:31
Fabien added inline comments to D16088: [chronik-client] Support lokad id endpoints.
Mon, May 6, 08:51
Fabien requested changes to D16114: Decouple ChainParams from ArgsManager, add factory functions.

Fuzzer is broken, back to your queue

Mon, May 6, 08:44
Fabien requested review of D16115: [guix] Better SHA256SUMS format.
Mon, May 6, 08:42