Differential D11451

[avalanche] Fix proof voting response type
ClosedPublic
Actions

Authored by sdulfari on May 11 2022, 23:26.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe6e75c178b54: [avalanche] Fix proof voting response type

Summary

AvalancheVoteError is used for voting on blocks. The tests happen to pass because the underlying integer
is the same as expected. This patch uses the correct AvalancheProofVoteResponse instead.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_proof_voting.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sdulfari created this revision.May 11 2022, 23:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 11 2022, 23:26

sdulfari requested review of this revision.May 11 2022, 23:26

Harbormaster completed remote builds in B19006: Diff 33489.May 11 2022, 23:37

Fabien accepted this revision.May 12 2022, 06:17

This revision is now accepted and ready to land.May 12 2022, 06:17

Closed by commit rABCe6e75c178b54: [avalanche] Fix proof voting response type (authored by sdulfari). · Explain WhyMay 12 2022, 06:42

This revision was automatically updated to reflect the committed changes.

sdulfari added a commit: rABCe6e75c178b54: [avalanche] Fix proof voting response type.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_proof_voting.py

15 lines

Diff 33492

View Options

test/functional/abc_p2p_avalanche_proof_voting.py

[avalanche] Fix proof voting response typeClosedPublicActions